From cf7926889b6c2cdd7e841f101669accdd83c7384 Mon Sep 17 00:00:00 2001 From: Donovan Jones Date: Wed, 24 Feb 2010 13:33:02 +1300 Subject: [PATCH] Bug 2505 - remove unnecessary -w and replace with use warnings; Signed-off-by: Chris Cormack Signed-off-by: Galen Charlton --- installer/externalmodules.pl | 3 ++- misc/cronjobs/advance_notices.pl | 2 +- misc/cronjobs/cleanup_database.pl | 2 +- misc/cronjobs/create_koc_db.pl | 2 +- misc/cronjobs/longoverdue.pl | 2 +- misc/cronjobs/overdue_notices.pl | 2 +- misc/cronjobs/process_message_queue.pl | 2 +- misc/cronjobs/runreport.pl | 2 +- misc/cronjobs/serialsUpdate.pl | 2 +- misc/cronjobs/stats/monthly_circulation_statistics.pl | 3 ++- misc/cronjobs/stats/monthly_new_items_statistics.pl | 4 +++- misc/cronjobs/stats/monthly_new_patron_statistics.pl | 3 ++- misc/maintenance/fix_accountlines_date.pl | 3 ++- misc/perlmodule_rm.pl | 5 ++++- misc/spellcheck_suggest/make_spellcheck_suggest.pl | 4 +++- 15 files changed, 26 insertions(+), 15 deletions(-) diff --git a/installer/externalmodules.pl b/installer/externalmodules.pl index 4be9965885..42eb4b7ef1 100755 --- a/installer/externalmodules.pl +++ b/installer/externalmodules.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # This Script can be used to provide a list of ALL external modules ***used*** (uncommented) in Koha. # It provides you not only the list of modules BUT ALSO the files that uses those modules. @@ -6,6 +6,7 @@ use strict; +use warnings; use C4::Context; my $dir=C4::Context->config('intranetdir'); qx(grep -r "^ *use" $dir | grep -v "C4\|strict\|vars" >/tmp/modulesKoha.log); diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index 59a51349db..46dc3f873d 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2008 LibLime # diff --git a/misc/cronjobs/cleanup_database.pl b/misc/cronjobs/cleanup_database.pl index f583ef467f..20481f55b4 100755 --- a/misc/cronjobs/cleanup_database.pl +++ b/misc/cronjobs/cleanup_database.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2009 PTFS, Inc. # diff --git a/misc/cronjobs/create_koc_db.pl b/misc/cronjobs/create_koc_db.pl index a38e764ce0..ccc4a5bae2 100755 --- a/misc/cronjobs/create_koc_db.pl +++ b/misc/cronjobs/create_koc_db.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # 2008 Kyle Hall diff --git a/misc/cronjobs/longoverdue.pl b/misc/cronjobs/longoverdue.pl index 5560c942a5..cd0cbd6564 100755 --- a/misc/cronjobs/longoverdue.pl +++ b/misc/cronjobs/longoverdue.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl #----------------------------------- # Copyright 2008 LibLime # diff --git a/misc/cronjobs/overdue_notices.pl b/misc/cronjobs/overdue_notices.pl index d4475394d1..04a5a0fa97 100755 --- a/misc/cronjobs/overdue_notices.pl +++ b/misc/cronjobs/overdue_notices.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2008 Liblime # diff --git a/misc/cronjobs/process_message_queue.pl b/misc/cronjobs/process_message_queue.pl index 0321082e3e..4ff29a4bdf 100755 --- a/misc/cronjobs/process_message_queue.pl +++ b/misc/cronjobs/process_message_queue.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2008 LibLime # diff --git a/misc/cronjobs/runreport.pl b/misc/cronjobs/runreport.pl index 9e011e6602..bb91b156b6 100755 --- a/misc/cronjobs/runreport.pl +++ b/misc/cronjobs/runreport.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # # Copyright 2008 Liblime # diff --git a/misc/cronjobs/serialsUpdate.pl b/misc/cronjobs/serialsUpdate.pl index 67c94b6ee2..1de5a48436 100755 --- a/misc/cronjobs/serialsUpdate.pl +++ b/misc/cronjobs/serialsUpdate.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # Copyright 2008 SARL Biblibre # diff --git a/misc/cronjobs/stats/monthly_circulation_statistics.pl b/misc/cronjobs/stats/monthly_circulation_statistics.pl index 57d273b854..1d8ab9f6b9 100755 --- a/misc/cronjobs/stats/monthly_circulation_statistics.pl +++ b/misc/cronjobs/stats/monthly_circulation_statistics.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl #----------------------------------- # Script Name: circstats.pl # Script Version: 1.0 @@ -30,6 +30,7 @@ # Suite 330, Boston, MA 02111-1307 USA # use strict; +use warnings; # UNCOMMENT the following lines if running from a command line # print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) "; diff --git a/misc/cronjobs/stats/monthly_new_items_statistics.pl b/misc/cronjobs/stats/monthly_new_items_statistics.pl index 746cbb87a1..d5df701b6e 100755 --- a/misc/cronjobs/stats/monthly_new_items_statistics.pl +++ b/misc/cronjobs/stats/monthly_new_items_statistics.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl #----------------------------------- # Script Name: addstats.pl # Script Version: 1.0 @@ -29,6 +29,8 @@ # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place, # Suite 330, Boston, MA 02111-1307 USA +use warnings; + # UNCOMMENT the following lines if running from a command line # print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) "; # chomp($_ = ); diff --git a/misc/cronjobs/stats/monthly_new_patron_statistics.pl b/misc/cronjobs/stats/monthly_new_patron_statistics.pl index 7b5cbdfe88..2ef2a1433f 100755 --- a/misc/cronjobs/stats/monthly_new_patron_statistics.pl +++ b/misc/cronjobs/stats/monthly_new_patron_statistics.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl #----------------------------------- # Script Name: borrstats.pl # Script Version: 1.0 @@ -30,6 +30,7 @@ # Suite 330, Boston, MA 02111-1307 USA # use strict; +use warnings; # UNCOMMENT the following lines if running from a command line # print "THIS SCRIPT produces a comma-separated values file of circulation statistics for a given month and year.\n\nDo you wish to continue? (y/n) "; diff --git a/misc/maintenance/fix_accountlines_date.pl b/misc/maintenance/fix_accountlines_date.pl index de7cfae427..94a33cdaea 100755 --- a/misc/maintenance/fix_accountlines_date.pl +++ b/misc/maintenance/fix_accountlines_date.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl # # Copyright (C) 2008 LibLime # @@ -18,6 +18,7 @@ # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. use strict; +use warnings; BEGIN { # find Koha's Perl modules # test carefully before changing this diff --git a/misc/perlmodule_rm.pl b/misc/perlmodule_rm.pl index 82e34c6a12..4dc3b64ff6 100755 --- a/misc/perlmodule_rm.pl +++ b/misc/perlmodule_rm.pl @@ -1,5 +1,8 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl + # Remove a perl module + +use warnings; use ExtUtils::Packlist; use ExtUtils::Installed; diff --git a/misc/spellcheck_suggest/make_spellcheck_suggest.pl b/misc/spellcheck_suggest/make_spellcheck_suggest.pl index 097e792986..1b81a2b900 100755 --- a/misc/spellcheck_suggest/make_spellcheck_suggest.pl +++ b/misc/spellcheck_suggest/make_spellcheck_suggest.pl @@ -1,4 +1,4 @@ -#!/usr/bin/perl -w +#!/usr/bin/perl ## This Script creates a Koha suggest and spellcheck database ## for those features as visible on LibLime's opac: opac.liblime.com ## It also contains the needed specs for creating a table of @@ -14,6 +14,8 @@ ## TODO: add suggest features, merge the two of them? ## There are a few configurable variables. +use warnings; + ## CONFIGURABLE VARIABLES #################### ## # These are the tags that have meaningful data -- 2.11.0