Clay Fouts [Mon, 22 Jul 2013 19:33:44 +0000 (12:33 -0700)]
Micro update: 4.16.3
Ryan Higgins [Mon, 22 Jul 2013 18:24:22 +0000 (11:24 -0700)]
Merge pull request #478 from rych/syspref_bug
[#
53548549] Duplicate holds followup.
Ryan Higgins [Mon, 22 Jul 2013 17:51:20 +0000 (10:51 -0700)]
[#
53548549] Duplicate holds followup.
Allows multiple holds to be placed on a single title.
Requires multiple 'ok' popup clicks, but the javascript
needs to be rewritten to prevent that.
Clay Fouts [Mon, 22 Jul 2013 15:44:43 +0000 (08:44 -0700)]
[#
53481867] (fixup) Use proper syspref API in GetDelimiterChoices()
Clay Fouts [Fri, 19 Jul 2013 17:12:18 +0000 (10:12 -0700)]
Micro update: 4.16.2
Clay Fouts [Fri, 19 Jul 2013 17:06:03 +0000 (10:06 -0700)]
[#
52749573] Catch still more solrsync exceptions
Clay Fouts [Thu, 18 Jul 2013 18:40:50 +0000 (11:40 -0700)]
Merge pull request #477 from wagnerj/PT53577373
[#
53577373] Add authority link search to XSLT 830
Jane Wagner [Thu, 18 Jul 2013 12:06:32 +0000 (12:06 +0000)]
[#
53577373] Add authority link search to XSLT 830
The 830 link in both staff and OPAC was doing a series title
search by default, not searching against the authority RCN.
Clay Fouts [Wed, 17 Jul 2013 19:20:06 +0000 (12:20 -0700)]
Merge pull request #476 from rych/syspref_bug
[#
53548549] nudge holds block logic on already-reserved titles.
Ryan Higgins [Wed, 17 Jul 2013 17:17:46 +0000 (10:17 -0700)]
[#
53548549] nudge holds block logic on already-reserved titles.
Logic is fragile and needs to be refactored,
but hopefully this change will give desired
behavior without side-effects.
Clay Fouts [Tue, 16 Jul 2013 23:52:31 +0000 (16:52 -0700)]
Merge pull request #475 from rych/syspref_bug
[#
53481867] Casing problem in Syspref causes holds shelf action crash.
Ryan Higgins [Tue, 16 Jul 2013 21:39:36 +0000 (14:39 -0700)]
[#
53481867] Casing problem in Syspref causes holds shelf action crash.
Clay Fouts [Tue, 16 Jul 2013 00:04:59 +0000 (17:04 -0700)]
Micro update: 4.16.1
Clay Fouts [Mon, 8 Jul 2013 18:03:32 +0000 (11:03 -0700)]
[#
42577819] (fixup) Include standard-id in Solr schema.xml
Clay Fouts [Tue, 2 Jul 2013 20:56:01 +0000 (13:56 -0700)]
[#
52749573] Remove uncaught exception possibility from solrsync
The "next unless $doc" evaluates $doc as a string, and that
prompts the Koha::Solr::Document overloading to call the
underlying to_xml() method. This method can fail if there
are render errors, and doing so in this code section means
that the exception does not get caught.
Clay Fouts [Thu, 27 Jun 2013 22:07:08 +0000 (15:07 -0700)]
Minor update: 4.16.0
Clay Fouts [Tue, 25 Jun 2013 20:51:31 +0000 (13:51 -0700)]
Micro update: 4.15.8
Clay Fouts [Tue, 25 Jun 2013 19:45:32 +0000 (12:45 -0700)]
Merge pull request #473 from dlbptfs/PT44086709
[#
44086709] Reading history retention - preference in patron record not ...
Clay Fouts [Tue, 25 Jun 2013 19:41:58 +0000 (12:41 -0700)]
Merge pull request #471 from wagnerj/PT51649105
[#
51649105] Rearrange system preferences; move unused ones
Clay Fouts [Tue, 25 Jun 2013 19:39:14 +0000 (12:39 -0700)]
Merge pull request #469 from wagnerj/PT51483347
[#
51483347] add 866$z to XSLT display
Clay Fouts [Tue, 25 Jun 2013 19:38:45 +0000 (12:38 -0700)]
Merge pull request #468 from dlbptfs/PT40301087
[#
40301087] Differing hold expiration date between DB table and notice
Clay Fouts [Tue, 25 Jun 2013 19:37:23 +0000 (12:37 -0700)]
Merge pull request #467 from dlbptfs/PT50984189
[#
50984189] Expired holds appear on OPAC side but NOT displaying title f...
Clay Fouts [Tue, 25 Jun 2013 19:36:09 +0000 (12:36 -0700)]
Merge pull request #466 from dlbptfs/PT31400651
[#
31400651] Error adding total for Defaults for this Library
Clay Fouts [Tue, 25 Jun 2013 19:35:23 +0000 (12:35 -0700)]
Merge pull request #465 from wagnerj/PT49666551
[#
49666551] Add printed music formats to advanced search subtypes
Clay Fouts [Tue, 25 Jun 2013 19:34:43 +0000 (12:34 -0700)]
Merge pull request #461 from wagnerj/PT49526067
[#
49526067] revise 8xx XSLT display to include subfield t
David Birmingham [Fri, 21 Jun 2013 19:08:16 +0000 (15:08 -0400)]
[#
44086709] Reading history retention - preference in patron record not being followed
The main issue was the anonymise_previous_borrowers.pl cron script not
being run when the KeepPreviousBorrower syspref was turned ON.
There was, however, an issue with the placement of the call to the
AnonymiseIssueHistory subroutine. It was occurring before the latest
return was _MarkIssueReturned. As a result, it was still in the issues
table and not immediately anonymized.
Clay Fouts [Fri, 21 Jun 2013 00:26:55 +0000 (17:26 -0700)]
[#
52077905] Add further subfield exceptions to authority matching
Also remove bundled version of NACO module, adding dependency on
CPAN-installed version.
Jane Wagner [Wed, 19 Jun 2013 17:52:21 +0000 (17:52 +0000)]
[#
51649105] Rearrange system preferences; move unused ones
Moved unused or irrelevant system preferences to a new Ignore
tab. Hid the following ones entirely from display:
BibliosCataloging
insecure
marc
marcflavour
Clay Fouts [Wed, 19 Jun 2013 14:45:56 +0000 (07:45 -0700)]
[#
50884419] Actually hide hidden sysprefs
Clay Fouts [Wed, 31 Oct 2012 21:45:26 +0000 (14:45 -0700)]
[#
38767751] Add batch upload resiliency to solrsync
The solrsync tool uploads renders documents in batches (of 100
by default). If one of those turns out to be rejected by the Solr
server for a schema violation or some such, the entire batch gets
rejected. This patch modifies the failure handling so that
solrsync splits the batch and recursively retries the upload with
smaller and smaller portions of the batch, failing only on the
documents that are specifically objected to by the Solr schema.
Secondarily, it renames the "--batch_size" command line parameter
to "--batch-size" to conform with convention.
jwt01 [Wed, 12 Jun 2013 12:38:23 +0000 (12:38 +0000)]
[#
51483347] add 866$z to XSLT display
Add subfield z (public note) to 866 display in staff and
OPAC XSLT details.
Clay Fouts [Tue, 11 Jun 2013 15:19:25 +0000 (08:19 -0700)]
[#
51486797] Apply correct pref name for borrowerRelationship
Clay Fouts [Thu, 6 Jun 2013 17:16:32 +0000 (10:16 -0700)]
[#
50884419] fixups to installer and pref setter
David Birmingham [Thu, 6 Jun 2013 18:03:59 +0000 (14:03 -0400)]
[#
40301087] Differing hold expiration date between DB table and notice
The hold expiration date was getting updated in the message_queue table
as a result of off days set via the calender tool, but was not showing
up in the actual email/print notice. The problem was the expiration date
was being recalculated in the Letters::parseletter subroutine.
David Birmingham [Tue, 4 Jun 2013 23:13:40 +0000 (19:13 -0400)]
[#
50984189] Expired holds appear on OPAC side but NOT displaying title for staff
There was an issue on the staff side where the code was always anticipating
an item number. Since an "any record" hold is not originally attached to a
specific item, this is not always the case. Added additional logic to account
for this particular situation.
Clay Fouts [Tue, 4 Jun 2013 20:51:20 +0000 (13:51 -0700)]
Micro update: 4.15.7
Clay Fouts [Mon, 3 Jun 2013 23:31:11 +0000 (16:31 -0700)]
[#
50884419] Lots of fixes to syspref handling and normalization
Modifies systempreferences DB schema to store only
variable/value pairs. All other fields are derived from
the values in the defaults file.
Adds a "tags" value to each variable. This is a list
of tabs on which a pref should be included in the prefs
editor. Currently only the first value is supported.
Prefs are no longer case insensitive. The update script
makes an effort to normalize syspref names to the
canonical version.
Removes abililty for the editor to add new prefs, delete
prefs, or edit their type, explanation, options, etc.
There was never a legit use case for this functionality,
and it has the potential to cause considerable trouble.
Attempts to retrieve bogus prefs now result in croaks
rather than warnings.
It's now possible to change a syspref's description
without running incrementing the db schema version.
Clay Fouts [Fri, 24 May 2013 00:43:27 +0000 (17:43 -0700)]
[#
50376721] Use NACO normalization in authority matching
See http://www.loc.gov/aba/pcc/naco/normrule-2.html
Apply normalization rules to authorities and bib headings
to account for typical defects in heading values. This
also removes Solr searching from the match process, instead
storing the normalized value in the database. This obviates
the recently created auth_cache table, so that is dropped.
Clay Fouts [Wed, 29 May 2013 20:24:45 +0000 (13:24 -0700)]
[#
51023687] Add SearchByRcn syspref
Turning on this sypref (the default) will cause Koha to link
heading searches of authors and subjects with the linked_rcn
field. Disabling the pref employs a value search.
Note that this does not address the existing bug where value
searches are constructed using only the $a rather than the
whole field.
David Birmingham [Fri, 31 May 2013 22:59:07 +0000 (18:59 -0400)]
[#
31400651] Error adding total for Defaults for this Library
SQL statements were expecting an extra parameter to be pushed to them
in a couple of cases.
jwt01 [Fri, 31 May 2013 12:54:49 +0000 (12:54 +0000)]
[#
49666551] Add printed music formats to advanced search subtypes
Added Printed Music (leader 6 c or d) to subtype format search
options for staff and OPAC advanced search.
Clay Fouts [Thu, 30 May 2013 13:40:56 +0000 (06:40 -0700)]
Merge pull request #464 from dlbptfs/PT50774187
[#
50774187] SIP_RenewOnIssue conflict with max issue circ rule
David Birmingham [Wed, 29 May 2013 21:06:41 +0000 (17:06 -0400)]
[#
50774187] SIP_RenewOnIssue conflict with max issue circ rule
When the SIP_RenewOnIssue syspref is ON, there was insufficient logic to
handle the case where the max issue circ rule for a given item type was
reached. This resulted in the renewal not occurring.
Clay Fouts [Wed, 22 May 2013 23:00:31 +0000 (16:00 -0700)]
[#
46930265] Include entire 245 for Solr title sorting
Clay Fouts [Tue, 21 May 2013 23:17:33 +0000 (16:17 -0700)]
[#
50306713] Properly update and delete cached authority heading values
Clay Fouts [Tue, 21 May 2013 21:47:17 +0000 (14:47 -0700)]
[#
50003917] Patron barcode matches display incomplete data
I hate to repeat myself, but sometimes expedience rules the day.
Clay Fouts [Fri, 17 May 2013 22:42:18 +0000 (15:42 -0700)]
DB rev increment
Clay Fouts [Fri, 17 May 2013 22:41:01 +0000 (15:41 -0700)]
Merge pull request #462 from frogomatic/PT5557764A
[delivers PT5557764] Port of Standing Orders code to LK
Clay Fouts [Fri, 17 May 2013 22:33:25 +0000 (15:33 -0700)]
[#
50015971] Further raise limit of linked bibs
Clay Fouts [Fri, 17 May 2013 22:29:44 +0000 (15:29 -0700)]
[#
50007653] Move edit/generate buttons for serials collection
Clay Fouts [Fri, 17 May 2013 22:18:54 +0000 (15:18 -0700)]
[#
50016503] Display $0 in MARCdetail.pl views
jwt01 [Tue, 14 May 2013 14:10:02 +0000 (14:10 +0000)]
[#
45854197] Workaround for EBSCO's broken EDS availability checker
Activation of this feature is done by creating a config file option:
<option name="explicit_availability">STRING</option>
The value of "STRING" can be whatever value or even a zero-length string.
The value will be set as the value of the $q subfield of any 952 tags
that have *no* $q already. If the tag has an existing $q subfield, this
option will make no change.
c.f. LAK #
41832679
William White [Wed, 15 May 2013 01:34:49 +0000 (01:34 +0000)]
Add module reference
Clay Fouts [Tue, 14 May 2013 18:42:52 +0000 (11:42 -0700)]
[#
25948787] Initialize javascript variable
The "dotransfer" form input wasn't being added in some
cases, causing a JS runtime error when the "ignore"
button was pushed for a pending hold.
William White [Mon, 13 May 2013 19:55:15 +0000 (19:55 +0000)]
[delivers PT5557764] Port of Standing Orders code to LK
Clay Fouts [Mon, 13 May 2013 18:45:47 +0000 (11:45 -0700)]
Fix record counter for auth import
jwt01 [Mon, 13 May 2013 17:41:30 +0000 (17:41 +0000)]
[#
49526067] revise 8xx XSLT display to include subfield t
Revise earlier 800/810/811 display change so that it now
shows both subfields a and t
Clay Fouts [Fri, 10 May 2013 16:34:08 +0000 (09:34 -0700)]
Merge pull request #460 from ctfliblime/PT49605843-dupe-issues
[#
49605843] Eliminate duplicated item issues
Clay Fouts [Fri, 10 May 2013 16:33:43 +0000 (09:33 -0700)]
Merge pull request #459 from wagnerj/PT49599431
[#
49599431] Hide password change boxes
Clay Fouts [Thu, 9 May 2013 21:09:59 +0000 (14:09 -0700)]
[#
49605843] Eliminate duplicated item issues
jwt01 [Thu, 9 May 2013 15:43:32 +0000 (15:43 +0000)]
[#
49599431] Hide password change boxes
If the staff user does not have permission to change a
staff password, hide the change boxes. Previously, an
error message appeared but the boxes still displayed.
Clay Fouts [Thu, 9 May 2013 05:27:10 +0000 (22:27 -0700)]
[#
24766391 fixup] Generalize checks for item availability
Adds two functions to C4::Circulation, IsItemAvailable()
and BiblioIsAvailableAt(), aimed at consolidating the logic
to determine whether or not a given item is sitting on
the shelf available for checkout.
Clay Fouts [Mon, 6 May 2013 20:54:08 +0000 (13:54 -0700)]
[#
48583869/#
49228801] Fix more authority pager quirks
Clay Fouts [Fri, 3 May 2013 23:37:00 +0000 (16:37 -0700)]
[#
39137907] Include extended attributes in patron searches
Using the 'SearchExtendedPatronAttributes' syspref, libraries can
opt to include extended attribute values when conducting patron
searches via C4::SearchMember(). This includes the main page
search, nav bar search, circ search, and possibly other search
interfaces.
Note that this option potentially has a very high cost associated
with it in that the borrower_attributes.attributes values are not
indexed. A full table search is required for these searches. The
time required to complete a search query will increase linearly
with the number of staff_searchable rows in the table.
Clay Fouts [Fri, 3 May 2013 18:30:38 +0000 (11:30 -0700)]
Micro update: 4.15.6
Clay Fouts [Fri, 3 May 2013 15:30:21 +0000 (08:30 -0700)]
Revert "[#
44806147] Force AND-ing of grouped search terms"
This reverts commit
e7475c9ee46a19f7e9aa694c42e0f1ef766c29ef.
Clay Fouts [Fri, 3 May 2013 15:26:44 +0000 (08:26 -0700)]
Merge pull request #458 from wagnerj/PT49148271
[#
49148271] Limit breadcrumb bib edit link
jwt01 [Fri, 3 May 2013 14:53:11 +0000 (14:53 +0000)]
[#
49148271] Limit breadcrumb bib edit link
Limit edit item breadcrumb link to bib record to
users with superlibrarian or edit_bibliographic
permissions.
Clay Fouts [Fri, 3 May 2013 00:00:27 +0000 (17:00 -0700)]
Merge pull request #456 from wagnerj/PT45526759-rev3
[#
45526759] fix installer syntax
Clay Fouts [Thu, 2 May 2013 23:59:50 +0000 (16:59 -0700)]
Merge pull request #457 from wagnerj/PT49145115
[#
49145115] Fix display problem with Firefox and RSS
jwt01 [Thu, 2 May 2013 17:49:18 +0000 (17:49 +0000)]
[#
49145115] Fix display problem with Firefox and RSS
Fixes problem with creating/displaying RSS feed in Firefox
Clay Fouts [Thu, 2 May 2013 00:23:38 +0000 (17:23 -0700)]
Small cleanups in solrsync and C4::Items
Clay Fouts [Wed, 1 May 2013 14:59:33 +0000 (07:59 -0700)]
[#
39138291] fixup: correctly call GetCircControlBranch
jwt01 [Thu, 2 May 2013 12:17:14 +0000 (12:17 +0000)]
[#
45526759] fix installer syntax
Fix .sql syntax in a couple of installer files
Clay Fouts [Wed, 1 May 2013 15:16:14 +0000 (08:16 -0700)]
Merge pull request #455 from wagnerj/PT49063335
[#
49063335] Minor fixes to 505 display
Clay Fouts [Wed, 1 May 2013 15:12:14 +0000 (08:12 -0700)]
Merge pull request #454 from wagnerj/PT46622533
[#
46622533] Add 264abc to staff and OPAC display
jwt01 [Wed, 1 May 2013 15:07:41 +0000 (15:07 +0000)]
[#
49063335] Minor fixes to 505 display
Fixing typo, spacing issues.
jwt01 [Wed, 1 May 2013 13:12:40 +0000 (13:12 +0000)]
[#
46622533] Add 264abc to staff and OPAC display
Add the RDA field 264 subfields a, b, c to staff and OPAC
results and display XSLT, with labels based on second
indicator.
Clay Fouts [Wed, 1 May 2013 00:33:22 +0000 (17:33 -0700)]
Micro update: 4.15.5
Clay Fouts [Wed, 1 May 2013 00:27:30 +0000 (17:27 -0700)]
[#
21296233] Show all subscriptions in OPAC detail
Clay Fouts [Tue, 30 Apr 2013 21:25:28 +0000 (14:25 -0700)]
Clear up some warns
Clay Fouts [Tue, 30 Apr 2013 21:22:08 +0000 (14:22 -0700)]
Fix edge case that could crash solrsync
Testing the conditional "unless $doc" causes $doc
to be tested as a string value, which in turn
causes the stringify operator to unroll the doc data
into and XML string. If there's an error in rendering
the XML (char encoding, etc.), XML::Easy will die.
Even in the successful case, turning the doc to XML
is expensive. Testing for definedness rather than truth
is cheap and won't die.
Clay Fouts [Tue, 30 Apr 2013 21:21:16 +0000 (14:21 -0700)]
[#
48704245] Fix case of multiple subfields included in more_subfields_xml
Clay Fouts [Mon, 29 Apr 2013 18:50:11 +0000 (11:50 -0700)]
Merge remote-tracking branch 'origin/ptfs-master' into ptfs-master
Clay Fouts [Mon, 29 Apr 2013 18:49:28 +0000 (11:49 -0700)]
Merge remote-tracking branch 'sjw/PT31401085-rev' into ptfs-master
Conflicts:
koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tmpl
Clay Fouts [Mon, 29 Apr 2013 18:40:46 +0000 (11:40 -0700)]
Merge pull request #412 from wagnerj/PT33078631
[#
33078631] Remove obsolete syspref emailLibrarianWhenHoldIsPlaced
Clay Fouts [Mon, 29 Apr 2013 17:41:29 +0000 (10:41 -0700)]
Micro update: 5.15.4
Clay Fouts [Fri, 26 Apr 2013 19:32:12 +0000 (12:32 -0700)]
[#
24766391] Improve accuracy of checking title's availability
Clay Fouts [Fri, 26 Apr 2013 16:57:56 +0000 (09:57 -0700)]
[#
30168727] Display session checkouts on circ screen
The list of "session checkouts" is derived from looking at the
list of all checkouts made to the same patron within the past
10 minutes. This allows the librarian to briefly interrupt the
checkout flow (for a search, question about fines, whatever)
and return to the circ screen still seeing the current issue
stack.
However if a patron, for example, were to checkout out a stack
of books with a self-check station and then go to the counter
to check out a special resrve book, the librarian's screen will
still show the entire stack of books even though that librarian
did not personally check them out.
Clay Fouts [Fri, 26 Apr 2013 06:03:13 +0000 (23:03 -0700)]
[#
39138291] Use branch email for DUE/PREDUE from address
Clay Fouts [Thu, 25 Apr 2013 22:22:40 +0000 (15:22 -0700)]
[#
21296233] Restore "Serials" tab in OPAC title detail view
Clay Fouts [Wed, 24 Apr 2013 23:32:23 +0000 (16:32 -0700)]
[#
44086709] Include public and private items notes into Solr keyword index
Clay Fouts [Wed, 24 Apr 2013 23:31:31 +0000 (16:31 -0700)]
[#
48704245] Include more_subfields_xml with GetMarcWithItems()
Clay Fouts [Tue, 23 Apr 2013 23:48:33 +0000 (16:48 -0700)]
[#
30482891/#
45622583] Alphabetize patron attribute values
Clay Fouts [Tue, 23 Apr 2013 23:07:01 +0000 (16:07 -0700)]
[#
48583869] Force correct entries_per_page for authorities
Clay Fouts [Tue, 23 Apr 2013 22:39:11 +0000 (15:39 -0700)]
[#
48599865] Raise max of linked bibs
Clay Fouts [Tue, 23 Apr 2013 22:15:32 +0000 (15:15 -0700)]
[#
48584845] Ignore punctuation in authority sorting
Clay Fouts [Tue, 23 Apr 2013 22:03:01 +0000 (15:03 -0700)]
[#
46720347] Clear unused subfield values when assigning new authority
Clay Fouts [Tue, 23 Apr 2013 21:10:26 +0000 (14:10 -0700)]
[#
44806147] Force AND-ing of grouped search terms
Clay Fouts [Tue, 23 Apr 2013 21:07:29 +0000 (14:07 -0700)]
[#
48612413] Simplify C4::Matcher::_normalize()