Clay Fouts [Wed, 10 Aug 2011 23:40:10 +0000 (16:40 -0700)]
Micro release: 4.8.10
Clay Fouts [Wed, 10 Aug 2011 21:29:46 +0000 (14:29 -0700)]
[delivers #
16861699] Inject Biblios iframe link URL via $KOHA_CONF
In addition to $ENV{BIBLIOS_LINK} this option can now be added
through a <biblios_link>URL</biblios_link> tag within the
<config> section of the koha-conf.xml file.
Clay Fouts [Fri, 5 Aug 2011 22:23:41 +0000 (15:23 -0700)]
Micro release: 4.8.9
Ha Quach [Wed, 11 May 2011 20:31:17 +0000 (16:31 -0400)]
[Fixes #
16684897] Holds queue displaying incorrect call numbers
This fix uses items.itemcallnumber instead of tmp_holdsqueue.itemcallnumber.
A schema change is needed in the future to use foreign keys instead of
static stale data.
Clay Fouts [Fri, 5 Aug 2011 21:51:19 +0000 (14:51 -0700)]
Micro release: 4.8.8
Ha Quach [Fri, 5 Aug 2011 21:32:13 +0000 (17:32 -0400)]
swap itemnumber and reservenumber in FillReserve w/ unshift
Clay Fouts [Fri, 5 Aug 2011 20:13:55 +0000 (13:13 -0700)]
Merge pull request #130 from hgq/11_13_rmDupesHoldsQueue
11 13 rm dupes holds queue
Ha Quach [Fri, 5 Aug 2011 20:04:58 +0000 (16:04 -0400)]
one more place for dupecheck in build_holds_queue.pl
Clay Fouts [Fri, 5 Aug 2011 19:04:02 +0000 (12:04 -0700)]
Micro release: 4.8.7
Clay Fouts [Fri, 5 Aug 2011 18:58:18 +0000 (11:58 -0700)]
More C4::Members::GetMember specs
Clay Fouts [Fri, 5 Aug 2011 18:49:53 +0000 (11:49 -0700)]
[delivers #
16677493] Error when viewing patron lists
Clay Fouts [Fri, 5 Aug 2011 18:40:48 +0000 (11:40 -0700)]
Micro release: 4.8.6
Clay Fouts [Fri, 5 Aug 2011 18:39:42 +0000 (11:39 -0700)]
Merge pull request #129 from hgq/11_12_pt1667219_4_08
11 12 pt1667219 4 08
Clay Fouts [Fri, 5 Aug 2011 18:37:59 +0000 (11:37 -0700)]
Completely specify GetMember package
Ha Quach [Fri, 5 Aug 2011 17:48:15 +0000 (13:48 -0400)]
[#
16672179] internal server error on confirm checkout hold override
- fixed wrong way to get superlibrarian permission
- fixed namespace problem in Circulation.pm calling ModReserve
Clay Fouts [Thu, 4 Aug 2011 22:29:59 +0000 (15:29 -0700)]
Micro release: 4.8.5
Clay Fouts [Thu, 4 Aug 2011 22:28:59 +0000 (15:28 -0700)]
[#
16468403] (fixup) Account for discrepancy in itype definition
Clay Fouts [Thu, 4 Aug 2011 15:46:16 +0000 (08:46 -0700)]
[#
16029551] (fixup) Was dereferencing a non-reference
Clay Fouts [Wed, 3 Aug 2011 21:39:12 +0000 (14:39 -0700)]
Micro release: 4.8.4
Clay Fouts [Wed, 3 Aug 2011 21:37:11 +0000 (14:37 -0700)]
Merge pull request #124 from hgq/11_10_pt16468403_4_08
11 10 pt16468403 4 08
Ha Quach [Wed, 3 Aug 2011 20:43:34 +0000 (16:43 -0400)]
[#
16468403] fix no userenv branch when running longoverdue cron
and we do a MarkLostItemsReturned upon a Lost+Charge on issued item,
and we have to get the branch for looking up which issuing rule to use
Clay Fouts [Fri, 29 Jul 2011 19:13:00 +0000 (12:13 -0700)]
Merge pull request #103 from ctfliblime/PT16371557-4_08
Pt16371557 4 08
Clay Fouts [Thu, 28 Jul 2011 23:03:50 +0000 (16:03 -0700)]
[#
16042719] (followup) Normalize null options and default values of sysprefs
Clay Fouts [Thu, 28 Jul 2011 19:31:22 +0000 (12:31 -0700)]
[delivers #
16371557] Cordon off administrative functions from web access
Directories such as misc/ C4/ Koha/ and so on should not be accessible
via URI. This patch uses middleware to exclude access to shell-only
areas.
DEPENDENCIES:
* ADDS: Plack::Middleware::Status
Clay Fouts [Wed, 27 Jul 2011 23:19:52 +0000 (16:19 -0700)]
[delivers #
16336385] Deprecate Koha::Plack::ScrubStatus
DEPENDENCIES:
* ADDS: Plack::Middleware::Header
Clay Fouts [Wed, 27 Jul 2011 22:44:33 +0000 (15:44 -0700)]
Merge pull request #100 from ctfliblime/PT16029551-4_08
Pt16029551 4 08
Clay Fouts [Wed, 27 Jul 2011 21:29:16 +0000 (14:29 -0700)]
[delivers #
16029551] COinS calculator dying on unchecked return value
If, as in the case of a newly deleted title, an OPAC search result list
includes a title that no longer exists, the COinS creator would die
from accessing an unchecked return value. This patch explicitly croaks
in that case and places catch()es within the caller to emit a simple
warn instead of dying.
Clay Fouts [Mon, 25 Jul 2011 20:18:59 +0000 (13:18 -0700)]
Micro release: 4.8.3
Clay Fouts [Mon, 25 Jul 2011 20:16:41 +0000 (13:16 -0700)]
Merge pull request #94 from hgq/11_02_pt16152385_4_08
11 02 pt16152385 4 08
Ha Quach [Mon, 25 Jul 2011 17:35:12 +0000 (13:35 -0400)]
[fixes #
16152385] our above subroutines in main under Plack... this needs to
be done in so many places
Clay Fouts [Fri, 22 Jul 2011 19:02:29 +0000 (12:02 -0700)]
Merge pull request #91 from hgq/10_10_pt14149993_4_08
10 10 pt14149993 4 08
Ha Quach [Fri, 22 Jul 2011 16:10:13 +0000 (12:10 -0400)]
minor tweaks:
- suppress Perl warning of uninit var in numeric comparison of
$lasttime when there isn't any (maybe we logged out properly?)
- Plack eval()'s expect clean exits, so installer.pl was backwards
and never reached login page after Web installation step 3,
cannot exit nonzero
Ha Quach [Thu, 21 Jul 2011 16:35:10 +0000 (12:35 -0400)]
[#
15592081] differentiate verbiage between returned and renewed in fines
Ha Quach [Mon, 18 Jul 2011 14:33:18 +0000 (10:33 -0400)]
[fixes #
14149993] make a transfer at checkin: lost, notlost, &c. Other fixes:
- fix undef Perl warning in mapping in fines.pl
- fix overdue from datedue calculation, was using object instead of ISO date
from issues
- finally finished work on refund owed for backdate checkin resulting
in downward adjustment of fine
- converted Yes|No option to Continue prompt: Remove from patron's Lost Items
- retested and fixed some lost prompts +notissued/issued, +hold/nohold, &c.
Ha Quach [Mon, 18 Jul 2011 14:33:18 +0000 (10:33 -0400)]
[fixes #
14999551] fix general case of lost:missing (not lost+charge),
notissued, noholds. Tested against other cases:
case 1) lostNcharge+nohold+notissued
1.a. checkin at A - OK
1.b. checkin at B - OK
1.b.ii. had previous transfer - OK
case 2) lostMissing+nothold+notissued
2.a. checkin at A - OK, click <OK> and form will now submit
2.b. checkin at B
2.b.i. no prior transfer - OK
2.b.ii. have prior transfer - OK
Ha Quach [Mon, 18 Jul 2011 14:33:18 +0000 (10:33 -0400)]
[addresses #
15528107 and #
15895609] more holds and tranfer fixes
- handle case: item already waiting at pickup branch, checkin at pickup
branch; relax previous assumption that item is permanent collection (not always true)
- allow ignore hold upon checkin at pickup library and not yet waiting
(don't automatically set hold to waiting in AddReturn())
Ha Quach [Mon, 18 Jul 2011 14:33:18 +0000 (10:33 -0400)]
[Fixes #
15841545] some fixes for intransit holds
- <Confirm and transfer> button was dead
- patron details: On Holds tab was displaying both intransit and waiting
- put intransit and add to branchtransfers when notlost, notissued
* TODO: fault tolerance for intransit but no entry in branchtransfers
Ha Quach [Fri, 15 Jul 2011 20:29:20 +0000 (16:29 -0400)]
[fixes #
15483899] longoverdue script needs to honor syspref MarkLostItemsReturned
Clay Fouts [Thu, 21 Jul 2011 23:42:48 +0000 (16:42 -0700)]
Merge pull request #90 from ctfliblime/PT15591737-4_08
Pt15591737 4 08
Clay Fouts [Thu, 21 Jul 2011 23:42:27 +0000 (16:42 -0700)]
Merge pull request #88 from ctfliblime/PT16042719-4_08
Pt16042719 4 08
Clay Fouts [Thu, 21 Jul 2011 23:08:04 +0000 (16:08 -0700)]
[delivers #
15591737] Fix improper use of cache handles
C4::Koha::GetAuthorisedValue had been improperly refactored
to use the CHI cache object handle rather than the computed
cache contents. This of course resulted in all calls to
GetAuthorisedValue to return undef.
Clay Fouts [Thu, 21 Jul 2011 17:35:17 +0000 (10:35 -0700)]
[delivers #
16042719] Installer should load default sysprefs
Clay Fouts [Wed, 20 Jul 2011 23:24:29 +0000 (16:24 -0700)]
Micro release: 4.8.2
David Birmingham [Mon, 18 Jul 2011 21:50:07 +0000 (17:50 -0400)]
PT15596575: SCLS sandbox failed ITG selfcheck (HIGH -- SC 15960)
Previous processing of the item due date was written as if the date was
a C4::Dates object. It isn't, so I removed the call to its output method.
David Birmingham [Fri, 15 Jul 2011 20:17:06 +0000 (16:17 -0400)]
PT13633157: OPAC not obeying 942$n bib suppression setting (SC #14321)
If the framework allows the biblionumber (999$c) field to be displayed and
edited within the MARC editor, then this results in an additional 999$c value
being added to the MARC record. This is because the code already pulled the
biblionumber from the biblio table. This patch removes the addition of the
extra 999$c field, although this field shouldn't really be editable in the
first place.
Ha Quach [Fri, 15 Jul 2011 17:46:35 +0000 (13:46 -0400)]
[fixes #
15236079] spine label typo Spilt to Split
Clay Fouts [Wed, 20 Jul 2011 22:37:14 +0000 (15:37 -0700)]
Merge pull request #80 from hgq/10_07_pt14986797_4_08
10 07 pt14986797 4 08
Ha Quach [Wed, 20 Jul 2011 18:50:00 +0000 (14:50 -0400)]
[fixes #
14986797] fixes for fastadd
- in circulation, allow creation of bib and item using FA framework which,
after deliberation, is decided to be hardcoded rather than controlled by
syspref. If the FA framework doesn't exist yet, the librarian will get
a friendly warning message but can proceed w/ fastadd and checkout using
default framework
- get 952$c explicitly (the barcode) for displaying at top of framework in
additem.pl, eliminating the bug that the field's text never displayed
and merely left behind a hyphen since code previously used regex instead
of hash keys. This also incidentally fixes the bug that attempting to
submit the form fails due to a JS error with trying to pass rmBarcode
over a nondisplaying field
Clay Fouts [Thu, 14 Jul 2011 23:49:03 +0000 (16:49 -0700)]
Micro release: 4.8.1
Clay Fouts [Thu, 14 Jul 2011 21:05:04 +0000 (14:05 -0700)]
Update Makefile.PL with new dependencies
Clay Fouts [Thu, 14 Jul 2011 21:10:11 +0000 (14:10 -0700)]
[delivers #
15796177] Enable setting of timezone in $KOHA_CONF
Koha can't rely on environment variables if using Plack
with multiple libraries since those vars could vary from
instance to instance. This patch allows setting TZ based
on instance-specific configuration info.
Additionally, this displays the active local time on the
about.pl page.
Clay Fouts [Thu, 14 Jul 2011 21:09:47 +0000 (14:09 -0700)]
Have middleware copy existing %ENV into localized %ENV
Clay Fouts [Tue, 12 Jul 2011 16:43:25 +0000 (09:43 -0700)]
Neglected to include JSON module from C4::Context
Clay Fouts [Tue, 12 Jul 2011 00:12:44 +0000 (00:12 +0000)]
Minor release: 4.8.0
Clay Fouts [Tue, 12 Jul 2011 00:06:18 +0000 (17:06 -0700)]
Merge pull request #57 from ctfliblime/PT14668229
PTFS PT
11434853 remove paging from Holds Queue Report
Clay Fouts [Tue, 12 Jul 2011 00:05:59 +0000 (17:05 -0700)]
Merge pull request #56 from hgq/08_07_pt15475375_head
[Fixes #
15475375] goto UpdateStats differently in UpdateFine()
Clay Fouts [Mon, 11 Jul 2011 23:57:58 +0000 (23:57 +0000)]
Merge branch 'ptfs-master' of git@github.com:pjones9/ptfs-master into ptfs-master
Clay Fouts [Mon, 11 Jul 2011 23:53:41 +0000 (16:53 -0700)]
Merge pull request #55 from hgq/08_06_pt15169665_head
08 06 pt15169665 head
Ha Quach [Thu, 7 Jul 2011 14:34:16 +0000 (10:34 -0400)]
[Fixes #
15466993] tweak verbiage of debt collect by using notmanual flag
Clay Fouts [Mon, 11 Jul 2011 23:22:11 +0000 (23:22 +0000)]
[delivers #
14668229] Broken advanced search with branch groups
Parentheses were missing from around branches list.
Ha Quach [Thu, 7 Jul 2011 21:38:24 +0000 (17:38 -0400)]
[Fixes #
15475375] goto UpdateStats differently in UpdateFine()
depending on insert (fine_new) or update (fine_update)
Ha Quach [Thu, 7 Jul 2011 20:39:54 +0000 (16:39 -0400)]
[Fixes #
15169665] use locale dateformat from syspref instead of hardcoded
US date.
Ha Quach [Thu, 7 Jul 2011 19:33:21 +0000 (15:33 -0400)]
[Fixes #
15484033] stray code was preventing processing of refund
owed for payment on lost item upon actual checkin
Clay Fouts [Thu, 7 Jul 2011 00:32:54 +0000 (00:32 +0000)]
Merge branch 'ptfs-master' of git@github.com:pjones9/ptfs-master into ptfs-master
Clay Fouts [Thu, 7 Jul 2011 00:11:56 +0000 (00:11 +0000)]
[#
15440423] Fix several XSS vectors
As listed in http://en.securitylab.ru/lab/PT-2011-05.
Clay Fouts [Wed, 6 Jul 2011 18:35:36 +0000 (11:35 -0700)]
Merge pull request #51 from hgq/08_03_pt1531769_head
[Fixes #
15351769] regex was failing to match November for hold resumedate
Clay Fouts [Wed, 6 Jul 2011 18:27:36 +0000 (11:27 -0700)]
Merge pull request #50 from hgq/08_01_pt14997333
resubmit for [Fixes #
14997333] really fix problem of found=NULL,priority=0:
Kyle M Hall [Wed, 6 Jul 2011 13:16:06 +0000 (13:16 +0000)]
[delivers #
15409175] Editing receipt templates requires wrong perms
SCLS-CIRC-2200-1 - Receipt Templates - BugFix - Fix Permissions
Ha Quach [Tue, 5 Jul 2011 16:53:41 +0000 (12:53 -0400)]
[Fixes #
15351769] regex was failing to match November for hold resumedate
Ha Quach [Thu, 30 Jun 2011 19:38:00 +0000 (15:38 -0400)]
[Fixes #
14997333] really fix problem of found=NULL,priority=0:
GetOtherReserves() should be deprecated. Anytime priorities or
found status change, all the Reserves.pm routines call _Normalize*,
so there's no need to decrement priorities anymore. Also, when we
requeue the impossible case of Waiting at A but checkin at B, requeue
as bib-level hold.
Clay Fouts [Tue, 5 Jul 2011 05:32:50 +0000 (05:32 +0000)]
Update code micro version to 4.7.3
Clay Fouts [Tue, 5 Jul 2011 05:29:36 +0000 (22:29 -0700)]
Fix Koha::RoseDB to work with Plack-local contexts
Clay Fouts [Sat, 2 Jul 2011 17:43:57 +0000 (10:43 -0700)]
Fix error in C4::Context::DESTROY()
Clay Fouts [Sat, 2 Jul 2011 00:55:50 +0000 (17:55 -0700)]
Rely on default Plack staff resolver by default in app.psgi
Clay Fouts [Sat, 2 Jul 2011 00:53:29 +0000 (17:53 -0700)]
Add benchmarking Plack middleware
Clay Fouts [Sat, 2 Jul 2011 00:52:51 +0000 (17:52 -0700)]
Provide default Plack staff resolver function
Clay Fouts [Sat, 2 Jul 2011 00:52:11 +0000 (17:52 -0700)]
[delivers #
15285829] Provide a function to resolve Plack localizer configuration
Clay Fouts [Sat, 2 Jul 2011 00:50:23 +0000 (17:50 -0700)]
Update Plack's method of canonicalizing the hostname
Clay Fouts [Fri, 1 Jul 2011 23:46:33 +0000 (16:46 -0700)]
[delivers #
15284861] Explicitly tear down Z39.50 connections
Clay Fouts [Fri, 1 Jul 2011 00:06:01 +0000 (17:06 -0700)]
Merge pull request #49 from hgq/08_02_pt5928993
[Fixes #
5928993] fix regex in CCL query to correctly capture
Clay Fouts [Thu, 30 Jun 2011 23:50:34 +0000 (16:50 -0700)]
Merge pull request #46 from hgq/07_05_pt13091533_head
[Fixes #
13091533] autoBarcode off: do blank barcode on Add+Duplicate
Clay Fouts [Thu, 30 Jun 2011 23:28:47 +0000 (16:28 -0700)]
Merge pull request #44 from hgq/07_04_pt15121665_head
[Fixes #
15121665] prevent double-submit of checkin form when pressing Ent
Clay Fouts [Thu, 30 Jun 2011 23:24:46 +0000 (23:24 +0000)]
Merge branch 'ptfs-master' of git@github.com:pjones9/ptfs-master into ptfs-master
Clay Fouts [Thu, 30 Jun 2011 23:06:02 +0000 (23:06 +0000)]
Allow for dynamic multi-instance servicing
By handing off a hash of hostname-to-KOHA_CONF mappings to the
Koha::Plack::Localize middleware via the host_map parameter,
a single running Plack instance can be used to service multiple
installations for distinct libraries. The absence of this
parameter causes the traditional $ENV{KOHA_CONF} to be used.
It may be useful in the future to also add a "host_mapper"
parameter which could be handed a coderef that would return
the appropriate config file based on any number of factors.
Ha Quach [Thu, 30 Jun 2011 20:19:14 +0000 (16:19 -0400)]
[Fixes #
5928993] fix regex in CCL query to correctly capture
from and to daterange, actually was not end of string
Clay Fouts [Thu, 30 Jun 2011 17:47:05 +0000 (10:47 -0700)]
Fix for inaccessible $template variable in receipt template editor
Clay Fouts [Thu, 30 Jun 2011 16:54:14 +0000 (16:54 +0000)]
Merge branch 'ptfs-master' of git@github.com:pjones9/ptfs-master into ptfs-master
Clay Fouts [Wed, 29 Jun 2011 17:41:18 +0000 (10:41 -0700)]
Merge pull request #47 from ctfliblime/PT15117555
PTFS PT
11434853 remove paging from Holds Queue Report
Clay Fouts [Wed, 29 Jun 2011 17:23:15 +0000 (10:23 -0700)]
[delivers #
15123975, #
15117555] Authval code caching hooked to wrong key
Single-quoting the cache key was causing all authval codes to
reference the first lookup that gets called. Interpolating the
string fixes this.
Ha Quach [Tue, 28 Jun 2011 20:26:12 +0000 (16:26 -0400)]
[Fixes #
13091533] autoBarcode off: do blank barcode on Add+Duplicate
Ha Quach [Tue, 28 Jun 2011 17:27:32 +0000 (13:27 -0400)]
[Fixes #
15121665] prevent double-submit of checkin form when pressing Enter,
esp. in IE. After observing IE's behavior on the screen, I noticed that IE
emulates actually pressing on the Submit button. Previous code submitted
the form once in setOverride*() upon capturing the Entering key and again
upon submitting the form by pressing the Submit button. I split up the
functionality of submitting the form so that pressing the Enter key does
not submit the form. Also tested against other browsers and works OK.
Clay Fouts [Mon, 27 Jun 2011 21:54:05 +0000 (21:54 +0000)]
Merge branch 'ptfs-master' of git@github.com:pjones9/ptfs-master into ptfs-master
Clay Fouts [Mon, 27 Jun 2011 21:53:53 +0000 (14:53 -0700)]
Merge pull request #42 from hgq/07_03_pt13590281_head
[addresses #
13590281] comment out broken syspref ReservesNeedReturns
Clay Fouts [Mon, 27 Jun 2011 21:44:07 +0000 (21:44 +0000)]
Update code micro version to 4.7.2
Ha Quach [Mon, 27 Jun 2011 16:21:57 +0000 (12:21 -0400)]
[addresses #
13590281] comment out broken syspref ReservesNeedReturns
Clay Fouts [Sat, 25 Jun 2011 04:27:38 +0000 (21:27 -0700)]
Merge branch 'opac-speedup-many-items' into ptfs-master
Clay Fouts [Sat, 25 Jun 2011 04:21:49 +0000 (21:21 -0700)]
Add flexibility to how staff vs. OPAC interface is determined
Clay Fouts [Sat, 25 Jun 2011 01:55:16 +0000 (18:55 -0700)]
Rename C4::Plack::* to Koha::Plack::*
Clay Fouts [Sat, 25 Jun 2011 01:40:40 +0000 (18:40 -0700)]
Eliminate duplicate item details collection in OPAC
If the OPAC is using XSLT for search results display it does
not need to gather item details when collating search result
data. This patch simply triggers that process based on those
conditions.
Clay Fouts [Sat, 25 Jun 2011 01:36:08 +0000 (18:36 -0700)]
Remove abandoned data collection in C4::Items
I can find no evidence of this data being read from any templates
or library functions.