Stéphane Delaune [Mon, 26 Nov 2012 09:24:05 +0000 (10:24 +0100)]
Bug 5635: bulkmarcimport new parameters & features followup
Stéphane Delaune [Mon, 23 Jul 2012 08:49:31 +0000 (10:49 +0200)]
Bug 5635: bulkmarcimport new parameters & features
Matthias Meusburger [Tue, 27 Nov 2012 14:22:06 +0000 (15:22 +0100)]
Revert "AM123: update the bulkmarcimport.pl script
This reverts commit
11326516c381b2c58782ba129078e009a2e48fac.
Jonathan Druart [Tue, 27 Nov 2012 10:17:30 +0000 (11:17 +0100)]
MT10156: FIX translation for cataloguing/merge.tt
Adrien Saurat [Mon, 26 Nov 2012 13:57:43 +0000 (14:57 +0100)]
MT10568: adds CI-3M book desensitizer support
Two systempreferences needed :
CI-3M (on/off)
CI-3M:AuthorizedIPs (contains IP which will activate messages)
Julian Maurice [Fri, 23 Nov 2012 15:23:40 +0000 (16:23 +0100)]
Merge remote branch 'kohac/ft/MT10482_BZ7673' into wip/am123
Julian Maurice [Fri, 23 Nov 2012 15:22:24 +0000 (16:22 +0100)]
MT10482: Disable plugins if item_limited_edition is enabled
Matthias Meusburger [Thu, 22 Nov 2012 09:29:14 +0000 (10:29 +0100)]
Fix kohaversion and updatedatabase so it's consistent
Matthias Meusburger [Wed, 21 Nov 2012 16:46:04 +0000 (17:46 +0100)]
MT5783, Follow-up: Use the serialsFieldsToAV syspref to tell from which marc field the authorised values must be retrieved.
Claire Hernandez [Tue, 20 Nov 2012 11:30:29 +0000 (12:30 +0100)]
MT 10551 fix french translation
Julian Maurice [Mon, 19 Nov 2012 13:11:20 +0000 (14:11 +0100)]
Bug 9044: Provide item selection in record detail page (staff client)
This patch add a column in the items table of catalogue/detail.pl that
contains checkboxes for item selection and a drop-down list of actions
that can be executed for the selection of items.
Currently available actions are:
- Delete selected items: redirect to batch items deletion
- Modify selected items: redirect to batch items modification
These actions replace the two menu entries corresponding to the same
action.
Item selection is only enabled if the new syspref
StaffDetailItemSelection is ON.
Actions are not displayed if user doesn't have the right permissions.
Julian Maurice [Mon, 19 Nov 2012 13:08:33 +0000 (14:08 +0100)]
Revert "Bug 9044: Provide item selection in record detail page (staff client)"
This reverts commit
5ca3c6148e9a2c3cee06c749a80cdd112dafffa8.
Conflicts:
installer/data/mysql/updatedatabase.pl
Claire Hernandez [Wed, 14 Nov 2012 16:32:25 +0000 (17:32 +0100)]
fix merge mistake
Matthias Meusburger [Tue, 19 Apr 2011 14:12:11 +0000 (16:12 +0200)]
MT4076, follow-up: Fix logout problem on merge
Conflicts:
cataloguing/merge.pl
cataloguing/merge_ajax.pl
Matthias Meusburger [Thu, 14 Apr 2011 14:41:47 +0000 (16:41 +0200)]
MT4076, follow-up: Adds permissions on shelves and fix fast cataloging
- Adds manage_shelves and merge_from_shelves permissions
- Allows fast_cataloging to work even if limited_item_edition is set
Conflicts:
C4/VirtualShelves.pm
C4/VirtualShelves/Page.pm
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tmpl
kohaversion.pl
Julian Maurice [Fri, 9 Nov 2012 14:16:52 +0000 (15:16 +0100)]
Bug 9044: Provide item selection in record detail page (staff client)
This patch add a column in the items table of catalogue/detail.pl that
contains checkboxes for item selection and a drop-down list of actions
that can be executed for the selection of items.
Currently available actions are:
- Delete selected items: redirect to batch items deletion
- Modify selected items: redirect to batch items modification
These actions replace the two menu entries corresponding to the same
action.
Item selection is only enabled if the new syspref
StaffDetailItemSelection is ON.
Actions are not displayed if user doesn't have the right permissions.
Julian Maurice [Fri, 9 Nov 2012 08:02:25 +0000 (09:02 +0100)]
Bug 9034: Add CSS rule to reduce width of items table
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Julian Maurice [Fri, 9 Nov 2012 15:19:20 +0000 (16:19 +0100)]
Bug 9034: Add sorting and filtering on items table (catalogue/detail.pl)
This patch introduces a new javascript plugin for dataTables
(columnFilter).
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Owen Leonard [Tue, 17 Apr 2012 15:21:14 +0000 (11:21 -0400)]
Bug 5184 - Upgrade jQuery to the latest version (staff client)
Upgrade jQuery in the staff client. Besides the change
to the jQuery file syntax has been changed wherever this
syntax was written:
$(foo).attr("checked","");
The new correct way to un-check a checkbox:
$(foo).removeAttr("checked");
I also removed some JavaScript altogether from
branch-transfer-limits.tt which used the old syntax but
which wasn't used on the page at all anymore.
Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Admin User Koha [Fri, 9 Nov 2012 15:23:13 +0000 (16:23 +0100)]
am123 - specific translation changes
Matthias Meusburger [Thu, 8 Nov 2012 15:46:42 +0000 (16:46 +0100)]
Bug 7684, Follow-up: multiple fixes for inventory
- Fix item statuses handling
- Fix unitialised value warnings
Jonathan Druart [Thu, 8 Nov 2012 11:00:55 +0000 (12:00 +0100)]
AM123: update the bulkmarcimport.pl script
Matthias Meusburger [Wed, 31 Oct 2012 14:08:18 +0000 (15:08 +0100)]
Bug 7684, Follow-up: multiple fixes for inventory
- Get translated columns.def
Admin User Koha [Wed, 31 Oct 2012 13:52:11 +0000 (14:52 +0100)]
am123 - specific transtaltion (trad)
Alex Arnaud [Wed, 31 Oct 2012 13:16:08 +0000 (14:16 +0100)]
Merge remote branch 'kohac/am123/ft/MT10463' into wip/am123
Conflicts solved:
koha-tmpl/intranet-tmpl/prog/en/includes/patron-search-box.inc
Alex Arnaud [Wed, 31 Oct 2012 13:14:27 +0000 (14:14 +0100)]
Revert "prepare apharp"
This reverts commit
2ab099662addb525676dc5fa59a2d96a5f6ad7ac.
Conflicts solved:
apharp/log/apharp-error-log
Alex Arnaud [Wed, 31 Oct 2012 13:00:47 +0000 (14:00 +0100)]
MT 10463 - Rebase apharp module on 3.8.5
- Mapping file are now in __KOHA_CONF_DIR__,
- Log file are now in koha log directory.
Matthias Meusburger [Wed, 31 Oct 2012 10:34:08 +0000 (11:34 +0100)]
Fix updatedatabase and kohaversion
Matthias Meusburger [Mon, 15 Oct 2012 13:37:07 +0000 (15:37 +0200)]
MT5783, Follow-up: Use mappings instead of fields
Matthias Meusburger [Tue, 27 Sep 2011 13:46:20 +0000 (15:46 +0200)]
MT3973: Make previous serial automatically available when collecting a new one
- Fix: test if $defaultvalues is defined (true) before trying to access it
as a hash
- Also change itype for previous serial, according to subscription.previousitemtype
MT3973, Follow-up: Make previous serial automatically available when collecting a new one
- GetPreviousSerialid is now based on serialid and status, which is more reliable than planneddate
MT3973, Follow-up: Make previous serial automatically available when collecting a new one
- Remove unuseful warn
Conflicts:
installer/data/mysql/sysprefs.sql
Matthias Meusburger [Wed, 2 Mar 2011 14:40:46 +0000 (15:40 +0100)]
MT5783: Adds various 995 to subscriptions
MT5783: Auto-selection of new subscription values when creating an item on serials-edit.pl
- Authorised values' names must match corresponding subscription column name
(ie: for domains, authorised values' name must be domain, to match subscription.domain)
MT5783, Follow-up: Auto-selection of new subscription values when creating an item on serials-edit.pl
- Adds empty item type
- Sort origins by hash values (and not keys)
- Removes a lot of unwanted warnings in log file
- Field prefill also works for supplemental issues
MT5783, Follow-up : prevent side-effect on MT6139
MT5783, Follow-up: Adds empty default value for origin and domain
Conflicts:
installer/data/mysql/updatedatabase.pl
Matthias Meusburger [Tue, 30 Oct 2012 14:02:45 +0000 (15:02 +0100)]
Bug 7684, Follow-up: multiple fixes for inventory
- Prevent getlanguage function from crashing when query is not provided.
Jonathan Druart [Mon, 29 Oct 2012 15:20:36 +0000 (16:20 +0100)]
Bug 7679: Followup: circulation statistics wizard improvements
Julian Maurice [Mon, 29 Oct 2012 13:15:05 +0000 (14:15 +0100)]
Bug 8801: Remove 'Delete all items' menu entry
and code in catalogue/additem.pl related to 'delallitems' operation.
Julian Maurice [Tue, 9 Oct 2012 15:01:58 +0000 (17:01 +0200)]
Bug 7674: Open shelf browser in appropriate tab
If you click on "Browse shelf" under "<mylibrary> holdings", shelf
browser should open under this tab.
If you click on "Browse shelf" under "other holdings" tab, it should
open under "other holdings" tab.
Paul Poulain [Fri, 21 Sep 2012 08:36:56 +0000 (10:36 +0200)]
Bug 7674: Separate items in two tabs on biblio detail page (staff+opac)
Two tabs: "<branch> holdings" / "Other holdings"
"<branch> holdings" tab contains items whose homebranch is the current branch.
"Other holdings" tab contains all other items.
If current branch is not set (connected with mysql user or not logged in
(opac)), the display is unchanged (1 tab "Holdings")
Claire Hernandez [Tue, 16 Oct 2012 09:14:21 +0000 (11:14 +0200)]
Revert "MT10233: Add translation for 'Item callnumber'"
Voir :
https://wiki.biblibre.com/doku.php?id=doc:koha:traduction:procedure
This reverts commit
f3b455e1399b3485ced596b5992a19bf0dab531a.
Claire Hernandez [Tue, 16 Oct 2012 09:13:48 +0000 (11:13 +0200)]
am123 - specific translation (init)
Julian Maurice [Fri, 21 Sep 2012 10:05:19 +0000 (12:05 +0200)]
Bug 8801: Add menu entry to delete items in batch
In catalogue/detail.pl you can now select "Delete items in batch" in
"Edit" menu. You are redirected to batchMod.pl for chosing which items
have to be deleted.
You need to have 'tools.items_batchdel' permission to see this menu
entry.
Signed-off-by: Marc Veron <veron@veron.ch>
Works as expected.
Amit Gupta [Wed, 18 Apr 2012 11:11:28 +0000 (16:41 +0530)]
Bug 7739 - Batch edit items of a title
A new option - Edit items in batch - is made available under the menu - Edit - in the catalog detail page. When this option is selected the tool batch item modification is called with all items under this biblio passed as parameters.
User can then edit all items of this biblio in batch. Once changes are saved the "done" link takes the user back to the catalog detail page of this biblio.
To test:
Navigate to catalog detail page of any biblio with one or more item records. Use the option "Edit items in batch" from the "Edit" menu. Modify the items in batch, say the collction code or lost status. Press "Save", verify that changes have been effected in the confirmation screen. Use the "Done" link to navigate back to the catalog detail page.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Julian Maurice [Mon, 20 Aug 2012 06:57:42 +0000 (08:57 +0200)]
Bug 7678: follow-up to pass QA
Check input parameters to avoid SQL injection
Rewrite a for loop for readability
Julian Maurice [Wed, 10 Oct 2012 08:26:52 +0000 (10:26 +0200)]
Revert "Bug 7678: follow-up to pass QA"
This reverts commit
466b65ba75ce38f4359cf2907f869f20a2c22acc.
Julian Maurice [Tue, 9 Oct 2012 12:29:16 +0000 (14:29 +0200)]
MT10233: Add translation for 'Item callnumber'
Julian Maurice [Tue, 9 Oct 2012 12:09:22 +0000 (14:09 +0200)]
MT10209: Missing code from master for Bug 7993
Julian Maurice [Mon, 20 Aug 2012 06:57:42 +0000 (08:57 +0200)]
Bug 7678: follow-up to pass QA
Check input parameters to avoid SQL injection
Rewrite a for loop for readability
Matthias Meusburger [Tue, 9 Oct 2012 09:50:28 +0000 (11:50 +0200)]
Bug 7684, Follow-up: multiple fixes for inventory
- As css class "datepickerfrom" is not yet present in this version,
revert to the old-fashioned DHTML Calendar setup
Matthias Meusburger [Thu, 23 Aug 2012 14:02:52 +0000 (16:02 +0200)]
Bug 7684: multiple fixes for inventory
* when a file was uploaded and the comparison with catalogue range
requested, the comparison was wrong: the logic was wrong
* items that were not supposed to be scanned (ie: supposed to be on another shelf)
didn't had the author and title, it was hard to retrieve them on the shelved
* some useful fields were missing, like homebranch, location, status
* the CSV export contained all the item information. It should contain the same
informations as the screen
Behaviour now:
* scan a list of barcode & select a range of location
* if a barcode has been scanned and should not be (mis placed item), the information is displayed
* if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column
Matthias Meusburger [Mon, 8 Oct 2012 15:18:29 +0000 (17:18 +0200)]
Revert "Bug 7684: multiple fixes for inventory"
This reverts commit
adf7f4c4de08eba400fdac56d36b67c97fb516cb.
(Uses tmpl instead of tt)
Julian Maurice [Thu, 20 Sep 2012 10:12:31 +0000 (12:12 +0200)]
Bug 8746: rebuild_zebra_sliced.sh now export/index records as MARCXML
This avoid indexing failures due to "bad offset" or "bad length" error
with ISO2709 format
+ minor improvements:
- --length parameter is optional. If not given, it will execute the
right sql query to find the number of records to index
- new parameter --reset-index. If set, index is reset before indexing
Stéphane Delaune [Mon, 17 Sep 2012 13:45:12 +0000 (15:45 +0200)]
rebuild_zebra_sliced.zsh
Stéphane Delaune [Mon, 17 Sep 2012 08:48:49 +0000 (10:48 +0200)]
fix error on C4/Acquisition.pm for updateAM123 to 38
Stéphane Delaune [Fri, 7 Sep 2012 11:31:26 +0000 (13:31 +0200)]
reset updatedatabase.pl
Alex Arnaud [Wed, 15 Sep 2010 11:50:21 +0000 (13:50 +0200)]
WS apogee / harpege - Modification de l'interface des cartes
Stéphane Delaune [Fri, 7 Sep 2012 11:06:48 +0000 (13:06 +0200)]
prepare apharp
Julian Maurice [Thu, 23 Aug 2012 11:36:15 +0000 (13:36 +0200)]
Bug 7993: Several bug fixes
- Re-display text input for sql params that are not linked to a list of
values
- Fix passing report id to template
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Srdjan [Mon, 20 Aug 2012 07:20:15 +0000 (09:20 +0200)]
Bug 7993 Follow-up
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Srdjan [Tue, 15 May 2012 01:07:59 +0000 (13:07 +1200)]
Bug 7993: Save reports with Group/Subgroup hierarchy
This should make saved reports more manageable.
Group/Subgroup hierarchy is stored in authorised_values,
categories REPORT_GROUP and REPORT_SUBGROUP, connected by
REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value
Database changes:
* authorised_values: expanded category to 16 chars
* created default set of REPORT_GROUP authorised values to match
hardcoded report areas
* reports_dictionary: replaced area int with report_area text, converted
values
* saved_sql: added report_area, report_group and report_subgroup;
report_area is not currently used, saved for the record
C4/Reports/Guided.pm:
* Replaced Area numeric values with the mnemonic codes
* get_report_areas(): returns hardcoded areas list
* created get_report_areas(): returns full hierarchy (groups with belonging
subgroups)
* save_report(): changed iterface, accepts fields hashref as input
* update_sql(): changed iterface, accepts id and fields hashref as input
* get_saved_reports():]
- join to authorised_values to pick group and subgroup name
- accept group and subgroup filter params
* get_saved_report():
- changed iterface, return record hashref
- join to authorised_values to pick group and subgroup name
* build_authorised_value_list(): new sub, moved code from
reports/guided_reports.pl
* Updated interfaces in:
cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report()
reports/dictionary.pl: get_report_areas()
reports/guided_reports.pl
reports/guided_reports_start.tt:
* Reports list:
- added group/subgroup filter
- display area/group/subgroup for the reports
* Create report wizard:
- carry area to the end
- select group and subgroup when saving the report; group defaults to area,
useful when report groups match areas
* Update report and Create from SQL: added group/subgroup
* Amended reports/guided_reports.pl accordingly
Conflicts:
C4/Reports/Guided.pm
admin/authorised_values.pl
installer/data/mysql/kohastructure.sql
installer/data/mysql/updatedatabase.pl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl
misc/cronjobs/runreport.pl
reports/dictionary.pl
reports/guided_reports.pl
Rebased 2012/07/02 by Jared Camins-Esakov
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Stéphane Delaune [Fri, 7 Sep 2012 10:06:00 +0000 (12:06 +0200)]
prepare 7993
Jonathan Druart [Thu, 30 Aug 2012 13:31:14 +0000 (15:31 +0200)]
Bug 7992: New plugin stocknumberAV
Bugzilla description (from delaye):
1 / Create a list of authorised values(INVENTORY_NUMBER). In which the
code is the prefix and the description the last number assigned.
2/A space between the prefix and number.
3 / From a holding record, after indicate the prefix when you click on
the plugin -> koha search the last number from authorised values
assigned in the list and increment n +1 level meter
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as advertised (see provisos below). Tested the following:
1) INVENTORY category has only authorised value 'PR' => PR prefix filled
in, everything else gives an error.
2) INVENTORY category has two authorised values, both work.
3) INVENTORY category has no authorised values, nothing is incremented
4) Barcode contains numbers, nothing is changed.
Two potential gotchas (neither of them significant enough to warrant
changing, in my opinion):
1) Prefixes must consist only of uppercase alphabetical characters.
2) Negative numbers are padded with zeros to the left of the negative
sign.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Jonathan Druart [Thu, 3 May 2012 12:58:25 +0000 (14:58 +0200)]
Bug 7991: Add itemcallnumber into the serial collection tab
This patch adds a new column containing the itemcallnumber value into
the serial collection tab (opac detail).
930$a for UNIMARC
852$h for others
Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(Added Stephane Delaye's sign off at the same time as mine)
As this view has never worked with MARC21, I am comfortable signing
off on the fact that the patch does not in any way impact the MARC21
display.
Julian Maurice [Tue, 24 Jul 2012 11:30:23 +0000 (13:30 +0200)]
Bug 7896: follow-up: Allow translation of strings
Julian Maurice [Tue, 3 Apr 2012 15:30:36 +0000 (17:30 +0200)]
Bug 7896: Acq statistics wizard: add filters and cell values
- Possibility to select for line and column: items.homebranch and
items.ccode
- Possibility to filter on these fields
- Possibility to count unique biblios (count(distinct biblionumber)),
ordered amount and spent amount (based on aqorders.datereceived)
Filtering on item homebranch and ccode works only on items that were
created at ordering or receiving (ie items are linked to an order)
Some refactoring is done, mainly replacing switch-like if statements by
given/when
Matthias Meusburger [Thu, 23 Aug 2012 14:02:52 +0000 (16:02 +0200)]
Bug 7684: multiple fixes for inventory
* when a file was uploaded and the comparison with catalogue range
requested, the comparison was wrong: the logic was wrong
* items that were not supposed to be scanned (ie: supposed to be on another shelf)
didn't had the author and title, it was hard to retrieve them on the shelved
* some useful fields were missing, like homebranch, location, status
* the CSV export contained all the item information. It should contain the same
informations as the screen
Behaviour now:
* scan a list of barcode & select a range of location
* if a barcode has been scanned and should not be (mis placed item), the information is displayed
* if you choose "compare barcodes list to result option", the resulting list contains all items that have been scanned and those that were supposed to be. Any item not in both list appears with a specific message on the last column
Julian Maurice [Wed, 8 Aug 2012 15:02:19 +0000 (17:02 +0200)]
Bug 7679: circulation statistics wizard improvements
- Add patron branch to the list of possible rows, columns, and filters
- Add extended patron attributes to the list of possible rows, columns,
and filters
- Allow to group period by hour
- Allow to translate filter names
Julian Maurice [Mon, 20 Aug 2012 06:57:42 +0000 (08:57 +0200)]
Bug 7678: follow-up to pass QA
Check input parameters to avoid SQL injection
Rewrite a for loop for readability
Matthias Meusburger [Fri, 20 Apr 2012 15:36:17 +0000 (17:36 +0200)]
Bug 7678: Adds extended patron attributes in patron reports
This patch allows to choose row and column amongst extended patron
attributes and to filter on them in reports/borrower_stats.pl
Signed-off-by: Marc Veron <veron@veron.ch>
Great, I was looking for such a feature.
Patch works as expected.
Matthias Meusburger [Fri, 30 Mar 2012 11:52:38 +0000 (13:52 +0200)]
Bug 7673 : New patron permissions
This patch adds the following permissions:
- editcatalogue.limited_item_edition: Limit item modification to barcode, status and note
- editcatalogue.delete_all_items: Delete all items at once
- tools.items_limited_batchmod: Limit batch item modification to item status
Julian Maurice [Mon, 13 Aug 2012 14:34:35 +0000 (16:34 +0200)]
Bug 7583 follow-up: Prevent users to cancel receipt if they can't
Disable the link for cancelling instead of displaying an error message
after the click. This is only valid if parent order line is received,
not if it's deleted.
When the user gets his mouse over the disabled link, he gets a message
telling him which order (ordernumber) blocks him so he knows immediately
which receipt to cancel.
Also improve error messages for non technical people
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Julian Maurice [Wed, 8 Aug 2012 09:06:45 +0000 (11:06 +0200)]
Bug 7583: Cancel a receipt
In acqui/parcel.pl, there is now the possibility to cancel a receipt.
In "Already received" table, just click on "Cancel receipt" and the
order line will go back to pending orders.
If it was a partial receipt, order line is merged to its 'parent' line.
Attached items are modified so that they become attached to the merged
order line.
If AcqCreateItem is 'receiving', attached items are deleted.
If an order line was first partially received, and then completed. You
must cancel the 'parent' order line before cancelling the 'child'.
Signed-off-by: Marc Veron <veron@veron.ch>
The patch behaves like expected, and the feature is really helpfull.
Just a tiny remark about the following message:
-------------
Cannot cancel receipt. Possible reasons :
You are trying to cancel the receipt of an order line whose parent order line is already received. Cancel this parent order line and retry.
-------------
Maybe it would be good
- to explain a little bit more why it happend and re-word the message for non technical people (not everybody understands 'parent' the same way)
- prevent the situation to happen (e.g. forbid order lines to be deleted if they are already received) - but that would be in the scope of an other bug, I think.
I think such things could be fixed in the future during the ongoing work for Acquisitions module. Signing off.
Alex Arnaud [Fri, 2 Sep 2011 09:40:40 +0000 (11:40 +0200)]
Bug 6835 - Ability to specify types of email address in overdue_notices.pl
Adds the -email option to overdue_notices.pl, which is repeatable
-email value can be:
- 'email'
- 'emailpro' or
- 'B_email'
- perltidy done
- in production for a BibLibre customer
- validated by the customer
Signed-off-by: Claire Hernandez <claire.hernandez@biblibre.com>
Chris Cormack [Sat, 22 Sep 2012 18:40:25 +0000 (06:40 +1200)]
Merge remote-tracking branch 'tamil/3.8.5-translate' into 3.8.x
Chris Cormack [Sat, 22 Sep 2012 18:36:19 +0000 (06:36 +1200)]
Bumping version number for release
Frédéric Demians [Sat, 22 Sep 2012 06:03:45 +0000 (08:03 +0200)]
3.8.5 Translation Update
Chris Cormack [Sat, 22 Sep 2012 00:23:21 +0000 (12:23 +1200)]
Updated the release notes
Tomas Cohen Arazi [Thu, 23 Aug 2012 15:58:52 +0000 (12:58 -0300)]
Bug 6617 - Wrong first indicator value in test
Testing the first indicator value=2 should be used for labeling 'Partial content'.
Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Fri, 21 Sep 2012 21:30:51 +0000 (09:30 +1200)]
Release notes for 3.8.5
David Cook [Tue, 4 Sep 2012 02:19:41 +0000 (12:19 +1000)]
Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client
Changes the subscription note from the opac "notes" to the proper staff client "internalnotes" field.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Katrin Fischer [Wed, 22 Aug 2012 20:33:26 +0000 (22:33 +0200)]
Bug 3782: Remove broken z39.50 targets from sample files
Removes NYPL and NYU from the list of sample z39.50 servers, because
they don't work or only work inconsistently.
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fridolyn SOMERS [Thu, 19 Jul 2012 09:37:16 +0000 (11:37 +0200)]
Bug 8275: xml parsing error when the webservice GetPatronInfo/show_loans is called
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Tue, 18 Sep 2012 09:23:42 +0000 (11:23 +0200)]
Bug 8336 follow-up, tabs to space
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Fri, 29 Jun 2012 17:43:28 +0000 (18:43 +0100)]
Bug 8336 Support Sip Renewal Transaction
Renewals were being rejected for incorrect reasons
Checking was being done against the wrong object
Add more informative messages on failure
Correctly set due_date for renewal response
Avoid crashing the SIPServer because it handles RenewAll
incorrectly
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Mon, 17 Sep 2012 17:00:05 +0000 (19:00 +0200)]
Bug 8765 follow-up replace tabs by spaces
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
David Cook [Wed, 12 Sep 2012 21:00:13 +0000 (07:00 +1000)]
Bug 8765 - Add series title to intranet search results
Patch adds series title to intranet search results, so that the
series volume is no longer displayed on its own.
It also removes the comma that comes before the series volume as
this is unnecessary punctuation that creates duplicate punctuation
in search results.
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Mark Tompsett [Mon, 3 Sep 2012 03:00:32 +0000 (11:00 +0800)]
Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping
In the Koha Administration screen, clicking
Keywords to MARC mapping triggered an uninitialized $op warning
in the koha error logs. Added a "|| q{}" to ensure it is set.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Wed, 5 Sep 2012 13:03:13 +0000 (14:03 +0100)]
Bug 8727 Minor stylistic change to help text
indexing not indexation
some minor grammatical changes
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fridolyn SOMERS [Thu, 9 Aug 2012 10:43:20 +0000 (12:43 +0200)]
Bug 7690: hidelostitems not working in Normal Display
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested by toggling both the hidelostitems preference and the
OpacHiddenItems preference. Both work as expected in the normal
search results display.
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Mark Tompsett [Mon, 3 Sep 2012 04:27:58 +0000 (12:27 +0800)]
Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl
An array boundary check was after a comparison using the array.
By changing the logic which had " and ( $j < $cnt)" to be at the
beginning "( $j < $cnt ) and ", the warning is no longer shown
in the error log.
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fridolyn SOMERS [Thu, 30 Aug 2012 16:42:26 +0000 (18:42 +0200)]
Bug 8705: Software error on help of main page
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fridolyn SOMERS [Mon, 17 Sep 2012 11:03:17 +0000 (13:03 +0200)]
Bug 8420: tool statisticfines.pl(bz 6858) and hourly loan(bz5549)
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Mon, 17 Sep 2012 07:34:08 +0000 (19:34 +1200)]
Bug 7409 : Missing dependency on DBD::Mock
Chris Cormack [Sun, 16 Sep 2012 09:50:33 +0000 (21:50 +1200)]
Bug 7409 : Fixing typo
Tomas Cohen Arazi [Mon, 3 Sep 2012 18:01:38 +0000 (15:01 -0300)]
Bug 8520 - Authorities summary incorrect on posible duplicate notice
We didn't notice this one with jcamins when we fixed this bug.
Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Thu, 16 Aug 2012 17:19:20 +0000 (18:19 +0100)]
Bug 8653 remove erroneous whitespace blocking indexing
The superfluous whitespace after the definition of subject
tag $9s is causing an error when carried over into dom config
files so that the authority links fail to index
Also removed the (harmless) trailing space in the equivalent
Unimarc files
A good editor and git can help in not creating excess whitespace
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Paul Poulain [Fri, 14 Sep 2012 13:59:50 +0000 (15:59 +0200)]
Bug 8743 follow-up, throw a more explanatory error message
When testing bug 8743, I discovered a missing index in my authority file.
The error message was
"CCL parsing error (10014) Unknown qualifier ZOOM"
which is not very helpfull because it does not show the query that was made.
This patch add the query itself after the zebra error
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Jared Camins-Esakov [Sun, 9 Sep 2012 12:18:05 +0000 (08:18 -0400)]
Bug 8743: ZOOM error when merging authority change to biblios
The merge fails and the following errors appear in the log:
[Sun Sep 02 23:38:10 2012] [error] [client 75.149.175.233] ZOOM error 25
"Specified element set name not valid for specified database" (addinfo:
"F") from diag-set 'Bib-1', referer:
http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010
[Sun Sep 02 23:38:11 2012] [error] [client 75.149.175.233] Premature end of
script headers: authorities.pl, referer:
http://****/cgi-bin/koha/authorities/authorities.pl?authid=3010
Test plan:
1) Set dontmerge to "Do"
2) Find an authority that is linked to a bib record.
3) Edit the main entry of the authority.
4) Save the authority record.
5) Notice that you got a nasty error and the bib record was not updated.
6) Apply patch.
7) Edit the main entry of the authority again (you can just set it back
to what it was to start with).
8) Save authority record.
9) Notice that there was no error, and the bib record was updated.
10) Sign off.
Signed-off-by: Doug Kingston <dpk@randomnotes.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 16 Sep 2012 08:12:58 +0000 (20:12 +1200)]
Bug 8002 : Database bump
Jonathan Druart [Thu, 6 Sep 2012 14:03:42 +0000 (16:03 +0200)]
Bug 8002: FIX Change datatype from varchar 1 to 10 for borrower_attribute_types.category_code
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Conflicts:
installer/data/mysql/updatedatabase.pl
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Colin Campbell [Tue, 28 Aug 2012 13:34:55 +0000 (14:34 +0100)]
Bug 6976 Close loophole allowing borrowers extra holds via opac
The check that the max number of reserves has
not been reached needs to take account of the fact
that we may have added enouch reserves to
reach the limit while this script is running.
Add a check against the incrementing count
The variable canreserve was only used when looping
through multiple holds but was not being
reinitialized on every iteration
make variable local to loop it is used in and
initialize to zero
Have used perltidy to correct the indention of
the while loop as it was misleading to the reader
Some numeric comparisons were using a string operator
fix them before strange bugs manifest themselves
The loophole manifests thus:
borrowers are only allowed Y holds.
If holds are done individually, it is
obeying that law i.e. X has held Y separate books –
when I tried to do a 6th
book it told me that I could not place a hold.
However, if a borrower checks the catalogue,
gets the intial list up and clicks items on the “results”
box and then clicks “place hold” they can hold more than Y
items Please enter the commit message for your changes. Lines starting
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Chris Cormack [Sun, 16 Sep 2012 07:48:43 +0000 (19:48 +1200)]
Bug 7409 : Missing dependency on libtest-mockmodule-perl
Jared Camins-Esakov [Fri, 7 Sep 2012 14:58:53 +0000 (10:58 -0400)]
Bug 8447: Make sure we have enough subfields for broader_headings
Thanks to wajasu for providing the debugging information, as I cannot
seem to duplicate the problem, even seeing where it could come from.
Fix corrects cases where upon save, a software error complaing about
indicators being wrong as a side effect of a poorly autogenerated
biblio/authority record.
Behvior with this fix causes existing bilio data to to be preserved
while linking to the authority via subtag 9.
Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>