koha-ffzg.git
9 years agoforce CGI qw(-utf8) uri_escape
Dobrica Pavlinusic [Tue, 10 Mar 2015 00:08:00 +0000 (01:08 +0100)]
force CGI qw(-utf8)

9 years agoKRT-4338 -- fix year-stocknumber
Dobrica Pavlinusic [Mon, 9 Mar 2015 23:53:14 +0000 (00:53 +0100)]
KRT-4338 -- fix year-stocknumber

9 years agoforce use CGI qw( -utf8 ) even under plack
Dobrica Pavlinusic [Mon, 9 Mar 2015 22:27:10 +0000 (23:27 +0100)]
force use CGI qw( -utf8 ) even under plack

9 years agoalways decode utf-8 in uri_unescape
Dobrica Pavlinusic [Mon, 9 Mar 2015 21:10:50 +0000 (22:10 +0100)]
always decode utf-8 in uri_unescape

9 years agoBug 13793: Make the installer output the result of the updates under Plack
Jonathan Druart [Wed, 4 Mar 2015 10:51:56 +0000 (11:51 +0100)]
Bug 13793: Make the installer output the result of the updates under Plack

Test plan:
0/ Start plack for intranet
1/ Create a new entry in updatedatabase.pl, something like:

$DBversion = "3.19.00.013";
if(CheckVersion($DBversion)) {
    print "Upgrade to $DBversion done (Bug test plack - This is a
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is anoter
est)\n";
    print "Upgrade to $DBversion done (Bug test plack - This is a third
est)\n";
    warn "this is an error";
}
and modify the kohaversion.pl accordingly.
You can also warn something to simulate an error.
2/ Go on the mainpage (or wherever you want), you should be redirected
to the installer
3/ Notice that the output of the updatedatabase is displayed on the
screen.
4/ Confirm that new files have been created in your Koha log directory
(check the logdir entry in your koha conf file).
5/ Confirm that the output is still displayed without Plack.

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
9 years agoadd stocknumber to catalogue detail normal display
Dobrica Pavlinusic [Wed, 18 Feb 2015 14:15:33 +0000 (15:15 +0100)]
add stocknumber to catalogue detail normal display

9 years agoKRT-4338 -- create barcode and stocknumber when receiving items in acq
Dobrica Pavlinusic [Mon, 16 Feb 2015 16:02:10 +0000 (17:02 +0100)]
KRT-4338 -- create barcode and stocknumber when receiving items in acq

9 years agomarc21 filed 008 - ffzg plugins modifications
Marijana Glavica [Tue, 7 Oct 2014 12:45:59 +0000 (14:45 +0200)]
marc21 filed 008 - ffzg plugins modifications

9 years agoaditional local value builders with tt template
Dobrica Pavlinusic [Mon, 15 Sep 2014 08:43:52 +0000 (10:43 +0200)]
aditional local value builders with tt template

9 years agofix value builder template extension to tt
Dobrica Pavlinusic [Fri, 5 Sep 2014 08:55:01 +0000 (10:55 +0200)]
fix value builder template extension to tt

9 years agofix keyboard shortcuts offset
Dobrica Pavlinusic [Tue, 26 Aug 2014 16:46:23 +0000 (18:46 +0200)]
fix keyboard shortcuts offset

9 years agocheckout/in books only on 3M reader
Dobrica Pavlinusic [Mon, 14 Apr 2014 13:05:18 +0000 (15:05 +0200)]
checkout/in books only on 3M reader

otherwise, we can't secure/unsecure books

9 years agoF4 to program tag
Dobrica Pavlinusic [Fri, 4 Apr 2014 12:45:02 +0000 (14:45 +0200)]
F4 to program tag

9 years agosearch catalog using barcode
Dobrica Pavlinusic [Fri, 4 Apr 2014 11:29:44 +0000 (13:29 +0200)]
search catalog using barcode

9 years agoalways respect check in tab if selected
Dobrica Pavlinusic [Thu, 3 Apr 2014 15:01:06 +0000 (17:01 +0200)]
always respect check in tab if selected

9 years agofirst change security and then submit form
Dobrica Pavlinusic [Thu, 3 Apr 2014 14:06:03 +0000 (16:06 +0200)]
first change security and then submit form

This allows librarians to remote book from reader as soon as page is
submitted instead of waiting for page load and one RFID scan to
correctly change tag security.

9 years agobetter extraction of script name
Dobrica Pavlinusic [Thu, 3 Apr 2014 14:03:53 +0000 (16:03 +0200)]
better extraction of script name

9 years agoremote debug output
Dobrica Pavlinusic [Thu, 3 Apr 2014 12:01:30 +0000 (14:01 +0200)]
remote debug output

9 years agocall rfid_secure JSONP only if security changed
Dobrica Pavlinusic [Thu, 3 Apr 2014 11:57:34 +0000 (13:57 +0200)]
call rfid_secure JSONP only if security changed

9 years agodisable rfid refresh before page load
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:36:30 +0000 (11:36 +0200)]
disable rfid refresh before page load

9 years agoadded javascript from Biblio::RFID
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:36:03 +0000 (11:36 +0200)]
added javascript from Biblio::RFID

9 years agocreate ip directory with correct permissions
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:34:02 +0000 (11:34 +0200)]
create ip directory with correct permissions

9 years agoregister rfid reader
Dobrica Pavlinusic [Thu, 3 Apr 2014 09:33:14 +0000 (11:33 +0200)]
register rfid reader

records local (intranet) address and address inside vmware (behind NAT)
for access from local browser

9 years agomove script to rfid directory
Dobrica Pavlinusic [Tue, 1 Apr 2014 09:35:37 +0000 (11:35 +0200)]
move script to rfid directory

9 years agoffzg_inventarna_knjiga needs itemnumber
Dobrica Pavlinusic [Fri, 7 Mar 2014 15:39:25 +0000 (16:39 +0100)]
ffzg_inventarna_knjiga needs itemnumber

9 years agolookup borrower data using SmartX card data
Dobrica Pavlinusic [Thu, 6 Feb 2014 11:02:33 +0000 (12:02 +0100)]
lookup borrower data using SmartX card data

9 years agoupdate and install hr-HR language
Dobrica Pavlinusic [Tue, 5 Nov 2013 15:16:24 +0000 (16:16 +0100)]
update and install hr-HR language

9 years agoadded stocknumber in red to items detail page
Dobrica Pavlinusic [Tue, 5 Nov 2013 14:53:20 +0000 (15:53 +0100)]
added stocknumber in red to items detail page

9 years agoffzg-stocknumber: replace YUI with jquery
Dobrica Pavlinusic [Mon, 4 Nov 2013 12:04:52 +0000 (13:04 +0100)]
ffzg-stocknumber: replace YUI with jquery

9 years agoFFZG #390 - Signatura ZS - jquery changed location
Dobrica Pavlinusic [Mon, 4 Nov 2013 11:37:26 +0000 (12:37 +0100)]
FFZG #390 - Signatura ZS - jquery changed location

9 years agofamfamfam silk images
Marijana Glavica [Sun, 3 Nov 2013 19:43:25 +0000 (20:43 +0100)]
famfamfam silk images

9 years agocustom OPAC details template
Marijana Glavica [Sun, 3 Nov 2013 15:27:55 +0000 (16:27 +0100)]
custom OPAC details template

9 years agocustom intranet templates
Marijana Glavica [Sun, 3 Nov 2013 15:26:55 +0000 (16:26 +0100)]
custom intranet templates

9 years agocustom intranet templates
Marijana Glavica [Sun, 3 Nov 2013 13:43:46 +0000 (14:43 +0100)]
custom intranet templates

9 years agoMARC21slim2OPACResultsFFZG.xsl
Marijana Glavica [Tue, 22 Oct 2013 12:44:20 +0000 (14:44 +0200)]
MARC21slim2OPACResultsFFZG.xsl

9 years agocustom xsl for MARC21slim2intranetDetailISBD.xsl
Marijana Glavica [Thu, 17 Oct 2013 15:15:52 +0000 (17:15 +0200)]
custom xsl for MARC21slim2intranetDetailISBD.xsl

9 years agoFFZG stocknumber - use last year until 15th of january
Dobrica Pavlinusic [Tue, 1 Jan 2013 22:43:20 +0000 (23:43 +0100)]
FFZG stocknumber - use last year until 15th of january

9 years agoKoha-FFZG#1517: Actual cost kod zaprimanja je 0 a trebalo bi prepisati Budgeted cost
Dobrica Pavlinusic [Thu, 12 Jul 2012 10:43:01 +0000 (12:43 +0200)]
Koha-FFZG#1517: Actual cost kod zaprimanja je 0 a trebalo bi prepisati Budgeted cost

9 years agokeybord shortcuts for circulation
Marijana Glavica [Tue, 26 Jun 2012 11:39:36 +0000 (13:39 +0200)]
keybord shortcuts for circulation

9 years agopersistent location of RFID chip based on itemnumber
Dobrica Pavlinusic [Wed, 22 Feb 2012 19:23:31 +0000 (20:23 +0100)]
persistent location of RFID chip based on itemnumber

9 years agoadded autocomplete="off"
Dobrica Pavlinusic [Fri, 10 Feb 2012 14:44:04 +0000 (15:44 +0100)]
added autocomplete="off"

9 years agoauto-focus barcode field on load
Dobrica Pavlinusic [Fri, 10 Feb 2012 14:38:57 +0000 (15:38 +0100)]
auto-focus barcode field on load

9 years agoredirect to printer REST only if barcode was found
Dobrica Pavlinusic [Thu, 9 Feb 2012 21:26:54 +0000 (22:26 +0100)]
redirect to printer REST only if barcode was found

9 years agoadded form to print another barcode
Dobrica Pavlinusic [Thu, 9 Feb 2012 17:08:38 +0000 (18:08 +0100)]
added form to print another barcode

9 years agocorrectly encode utf8 callnumbers
Dobrica Pavlinusic [Thu, 9 Feb 2012 14:10:50 +0000 (15:10 +0100)]
correctly encode utf8 callnumbers

9 years agoopac-sendbasket.tt is not translatable
Marijana Glavica [Tue, 31 Jan 2012 21:02:01 +0000 (22:02 +0100)]
opac-sendbasket.tt is not translatable

this file was made manualy, not by translate tool, so that is
why it is commited to the repository

9 years agoAdding user email to message sent from cart
Marijana Glavica [Tue, 31 Jan 2012 19:50:51 +0000 (20:50 +0100)]
Adding user email to message sent from cart

9 years agofix currency exchange rates
Dobrica Pavlinusic [Fri, 27 Jan 2012 10:54:47 +0000 (11:54 +0100)]
fix currency exchange rates

9 years agoHNB currency update
Dobrica Pavlinusic [Wed, 25 Jan 2012 21:09:49 +0000 (22:09 +0100)]
HNB currency update

9 years agoinsert RFID chip position using javascript
Dobrica Pavlinusic [Thu, 5 Jan 2012 14:46:56 +0000 (15:46 +0100)]
insert RFID chip position using javascript

9 years agoAdding RFID tags to items using catalogue/moredetail template
Marijana Glavica [Wed, 28 Dec 2011 21:15:13 +0000 (22:15 +0100)]
Adding RFID tags to items using catalogue/moredetail template

9 years agonew inventory number confirmation
Dobrica Pavlinusic [Tue, 24 Jan 2012 19:56:34 +0000 (20:56 +0100)]
new inventory number confirmation

9 years agoopen items editor instad of normal view in received orders list
Marijana Glavica [Fri, 20 Jan 2012 06:17:48 +0000 (07:17 +0100)]
open items editor instad of normal view in received orders list

9 years agoFFZG stocknumber value_builder plugin for YEAR-NR
Dobrica Pavlinusic [Tue, 17 Jan 2012 19:04:08 +0000 (20:04 +0100)]
FFZG stocknumber value_builder plugin for YEAR-NR

Squashed commit of the following:

commit 87ff20b8470895b3261a408c503ca3d0f5130025
Author: Dobrica Pavlinusic <dpavlin@rot13.org>
Date:   Tue Jan 17 19:47:27 2012 +0100

    stocknumber in YEAR-NR format

commit 9084f5a1199d9305570da122d3b383f2b2662bf8
Author: Dobrica Pavlinusic <dpavlin@rot13.org>
Date:   Tue Jan 17 18:30:11 2012 +0100

    begin value builder for inventory book

9 years agoinsert RFID chip position using javascript
Dobrica Pavlinusic [Thu, 5 Jan 2012 14:46:56 +0000 (15:46 +0100)]
insert RFID chip position using javascript

9 years agoRFID position pictures
Dobrica Pavlinusic [Wed, 4 Jan 2012 15:08:40 +0000 (16:08 +0100)]
RFID position pictures

9 years agocorner images for library menu
Marijana Glavica [Thu, 5 Jan 2012 12:54:07 +0000 (13:54 +0100)]
corner images for library menu

9 years agoNormal view to look like ISBD
Marijana Glavica [Thu, 5 Jan 2012 01:35:32 +0000 (02:35 +0100)]
Normal view to look like ISBD

9 years agoplugins for thesis framework
Marijana Glavica [Tue, 3 Jan 2012 13:30:25 +0000 (14:30 +0100)]
plugins for thesis framework

9 years agoPlugins for leader and 008
Marijana Glavica [Tue, 3 Jan 2012 03:50:28 +0000 (04:50 +0100)]
Plugins for leader and 008

9 years agoSome images for OPAC
Marijana Glavica [Tue, 3 Jan 2012 01:04:00 +0000 (02:04 +0100)]
Some images for OPAC

9 years agoOPAC FFZG style
Marijana Glavica [Mon, 2 Jan 2012 18:18:27 +0000 (19:18 +0100)]
OPAC FFZG style

9 years agogreybox for ISBD view
Marijana Glavica [Mon, 2 Jan 2012 18:00:59 +0000 (19:00 +0100)]
greybox for ISBD view

9 years agoAdding RFID tags to items using catalogue/moredetail template
Marijana Glavica [Wed, 28 Dec 2011 21:15:13 +0000 (22:15 +0100)]
Adding RFID tags to items using catalogue/moredetail template

9 years agoffzg site required local staff css
Marijana Glavica [Thu, 14 Jul 2011 21:34:59 +0000 (23:34 +0200)]
ffzg site required local staff css

9 years agobounce browser to printer URL and return with station
Dobrica Pavlinusic [Wed, 8 Feb 2012 13:47:53 +0000 (14:47 +0100)]
bounce browser to printer URL and return with station

This allows us to recurect to printer REST API, send ZPL file to printer
and return to Koha with station/printer IP address to record in log.

9 years agoFFZG #390 - Signatura zatvorenog spremišta
Dobrica Pavlinusic [Sun, 1 Jan 2012 12:18:50 +0000 (13:18 +0100)]
FFZG #390 - Signatura zatvorenog spremiÅ¡ta

Implementirati viÅ¡estruke nizove signatura prema formatu

Ovo je port na Template Toolkit za Kohu 3.4 i novije

9 years agoBug 11400 - Follow-up for nicer design
Marc Véron [Wed, 18 Feb 2015 19:09:57 +0000 (20:09 +0100)]
Bug 11400 - Follow-up for nicer design

This patch tries to get the Bug out of "In discussion" by changing the design a little bit.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11400: Show "Log in as a different user" in the error message instead of the...
Tomas Cohen Arazi [Mon, 16 Dec 2013 13:47:16 +0000 (10:47 -0300)]
Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button

Bug 11146 introduced a way to go back, and have a logout link for the
"Not enough permissions" message page. I belive the logout button is redundant. And
also "Log in as a different user" tells the user more about its options on the scenario.

Simple and disputable usability/string change.
Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13351 - Untranslatable javascript in members.tt
Marc Véron [Tue, 3 Mar 2015 10:49:29 +0000 (11:49 +0100)]
Bug 13351 - Untranslatable javascript in members.tt

This patch streamlines the page title text for search results in Home > Patrons to make it translateable (and more readable).

To test:
- Apply patch
- Select Englsh language
- Apply filter wit several values or click on a letter for "Browse by last name"
- Verify that the title makes sense
- Translate to your language and select this language
- Verify that the text appears properly in your language

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, no problems found.

http://bugs.koha-community.org/show_bug.cgi?id=13352
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 7143: Add "developer" for all devs
Jonathan Druart [Fri, 6 Mar 2015 10:05:13 +0000 (11:05 +0100)]
Bug 7143: Add "developer" for all devs

Some were missing.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBUG 7143: Add Kyle Hall as the 42nd developer to history
Nicole [Thu, 5 Mar 2015 09:32:25 +0000 (01:32 -0800)]
BUG 7143: Add Kyle Hall as the 42nd developer to history

I found Kyle's first commit and added him to the history

http://lists.gnu.org/archive/cgi-bin/namazu.cgi?query=kyle&submit=Search!&idxname=koha-cvs&max=20&result=normal&sort=date%3Aearly

While in there I added tags to releases and developers that were missing.

To test:

* Log in to staff client
* visit about koha
* check to make sure timeline is right

Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 12631: Inventory: fix "wrong place" and "item not scanned"
Matthias Meusburger [Mon, 23 Jun 2014 14:51:00 +0000 (16:51 +0200)]
Bug 12631: Inventory: fix "wrong place" and "item not scanned"

 "item not scanned": when calling GetItemsForInventory, datelastseen should
 be used when "compare barcodes list to result" is checked.

 Otherwise, when loading multiple barcodes files for the same inventory, many
 items will be marked as "item not scanned" when loading the last barcode file
 ("compare barcodes list to result" checked) even though they were scanned.

 "wrong place": when searching for wrongly placed items, we should only check
 for the location (callnumbers, location and branch). To fix this, A new call
 to  GetItemsForInventory has been made with location filters only.

 Otherwise, any item with a different itemtype for instance will be marked as
 wrong place even if the location is correct.

 Test plan:

"item not scanned" status:

1) Split a barcode file in two.
2) Load the first barcode file without checking "compare barcodes list to result".
3) Load the second barcode file with "compare barcodes list to result" checked.
4) Check in the csv report that you have a lot of scanned items with the "item
not scanned" status.

Then apply the patch, do the same, and check that the false "item not scanned"
statuses are gone.

"wrong place" status:

1) Load a barcode file with barcode matching an item that has a correct
location, but a different itemtype than what you're looking for.
2) Check in the results that this item will be marked as "change item status"
and "wrong place".

Then apply the patch, do the same, and check that the only status for this item is "change item status", which is correct.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13750: Fix capitalization All vs ALL
Jonathan Druart [Wed, 25 Feb 2015 11:24:20 +0000 (12:24 +0100)]
Bug 13750: Fix capitalization All vs ALL

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13750: Holds queue - Show branch name instead of branch code
Katrin Fischer [Sun, 22 Feb 2015 10:50:21 +0000 (11:50 +0100)]
Bug 13750: Holds queue - Show branch name instead of branch code

When the holds queue report is limited to one library, it shows
<cound> items found for <branchcode>

With the patch applied, the branch name is shown instead of the code.

To test:
- Go to circulation > Holds queue
- Limit to one branch with holds waiting to be processed
- Confirm the string has changed to show the branch name

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13784: (QA followup) allow running Zebra for disabled instances on packages
Tomas Cohen Arazi [Sat, 7 Mar 2015 20:35:36 +0000 (21:35 +0100)]
Bug 13784: (QA followup) allow running Zebra for disabled instances on packages

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13784: koha-stop-zebra should also work for disabled instances
Larry Baerveldt [Tue, 3 Mar 2015 13:49:57 +0000 (05:49 -0800)]
Bug 13784: koha-stop-zebra should also work for disabled instances

Currently koha-stop-zebra will not stop zebra for disabled instances. It should
work more like koha-stop-sip, which does work for disabled instances. Also,
koha-stop-zebra is called by '/etc/init.d/koha-common stop' which clearly
should also apply to disabled instances.

To Test:
1) Disable a koha instance.
2) Run koha-stop-zebra INSTANCE. You should get message
   "Instance INSTANCE disabled. No action taken."
3) Apply patch, and copy patched file debian/scripts/koha-stop-zebra
   to package site over /usr/sbin/koha-stop-zebra.
4) Disable koha instance.
5) Run koha-stop-zebra INSTANCE. It should now stop zebra.

http://bugs.koha-community.org/show_bug.cgi?id=13784
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13787 - Clean up noisy opac-advsearch warnings
Mark Tompsett [Wed, 4 Mar 2015 00:28:44 +0000 (19:28 -0500)]
Bug 13787 - Clean up noisy opac-advsearch warnings

While testing bug 10937, there were noisy warnings, which
distracted from testing the functionality of it.

Here is a snippet of the after the patch warnings:
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 384.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 161.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 161.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 177.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 177.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 202.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 202.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 240.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 240.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 256.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 256.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 356.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 356.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 369.
Argument "" isn't numeric in numeric gt (>) at /home/mtompset/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt line 369.

Tweaking the [% IF %] statements eliminated the warnings.

TEST PLAN
---------
1) Apply patch
2) Run koha qa test tools.
   -- there will be noisy warnings in the before processing, but
      there will be no such messages in the after processing.
3) git diff origin/master
   -- there should be no visible typos.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
- Applied the patch from bug 10937
- Ran "koha-qa.pl -c 1" and observed the warnings described in the
  commit message
- Applied the patch from this bug
- Ran "koha-qa.pl -c 1" again and saw no warnings
- Ran "koha-qa.pl -c 2" and saw no warnings

I have not tested the functionality of 10937 with this patch, just verified
that the changes look sensible.

This patch feels more like a followup for 10937, than a separate patch,
especially since 10937 is just "signed off" at this time. But as long as it
works...

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13744: Fix datatables paging on 'Holds to pull' report
Katrin Fischer [Sat, 21 Feb 2015 19:40:31 +0000 (20:40 +0100)]
Bug 13744: Fix datatables paging on 'Holds to pull' report

The paging of the datatables on the 'holds to pull' report
page is broken without this patch.

To test:
- Make sure that some holds are placed on available items
  in your installation
- Go to the circulation start page
- Open the 'holds to pull' report
- Verify that the patch fixes the paging on the result table

Also: Fixes "None" in the filter pull downs to be translatable.
Signed-off-by: Nicole <nicole@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13744: Fix datatables paging on 'checkout history' page
Katrin Fischer [Sun, 22 Feb 2015 10:10:59 +0000 (11:10 +0100)]
Bug 13744: Fix datatables paging on 'checkout history' page

The paging in the datatable on the 'circulation history' page
is broken without this patch.

/cgi-bin/koha/catalogue/issuehistory.pl?biblionumber=...

To test:
- Search for a record with items that have been checked out
  in the past
- From the detail page, open the 'checkout history' tab
- Check paging displays correctly with this patch and is
  broken without

Signed-off-by: Nicole <nicole@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13744: Fix datatables paging on 'order from subscription' page
Katrin Fischer [Sat, 21 Feb 2015 19:30:07 +0000 (20:30 +0100)]
Bug 13744: Fix datatables paging on 'order from subscription' page

The paging of the datatable on the 'order from subscription' page
is broken without this patch.

To test:
- Make sure you have a subscription, note the vendor
- Create a new basket for this vendor
- Add a new order line 'from a subscription'
- Check paging on the result table displays correctly

Signed-off-by: Nicole <nicole@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13771: Update manage staged marc help for 3.18
Nicole [Thu, 5 Mar 2015 10:03:43 +0000 (02:03 -0800)]
Bug 13771: Update manage staged marc help for 3.18

This updates the manage staged marc files help.

To test:

* Visit Tools > Staged MARC record management
* Click help
* Confirm it's there and correct

Signed-off-by: Larry Baerveldt <larry@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13771: Add missing item search help file
Nicole [Wed, 4 Mar 2015 15:47:54 +0000 (07:47 -0800)]
Bug 13771: Add missing item search help file

This patch adds a help file for the staff item search.

To test:

* Click search
* click item search
* click help
* review the help file

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13771: Add admin help files for 3.18
Nicole [Tue, 3 Mar 2015 10:01:56 +0000 (02:01 -0800)]
Bug 13771: Add admin help files for 3.18

This patch adds a new help file for column settings and updates the
files for budgets, funds, libraries, patron categories, and circ rules.

To test:

* Visit the above listed admin pages
* Review help files

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13771: Update Circ Help File
Nicole [Mon, 2 Mar 2015 15:48:12 +0000 (07:48 -0800)]
Bug 13771: Update Circ Help File

This updates the main circulation help file with new features in 3.18.

To test:

* visit circulation page
* click help
* review text

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13771: Main Page Help fro 3.18
Nicole C. Engard [Mon, 2 Mar 2015 09:49:30 +0000 (04:49 -0500)]
Bug 13771: Main Page Help fro 3.18

This updates the main page help file for 3.18.

To test:
* Log in to staff cleint
* Click help on the mian page
* Review help file

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBUG 13771: Update Tools Help Files for 3.18
Nicole C. Engard [Mon, 2 Mar 2015 10:28:42 +0000 (05:28 -0500)]
BUG 13771: Update Tools Help Files for 3.18

This patch creates a helpf ile for the batch record delete tool
and updates the help files for notices and marc export.

To test:

* Visit tools > batch record deletion
* confirm help is right
* Visit tools > Notices & Slips
* confirm help is right
* Visit tools > export marc
* cofirm the help is right

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13789 - facets with accented utf-8 characters generate double encoded links
Dobrica Pavlinusic [Wed, 4 Mar 2015 10:38:42 +0000 (11:38 +0100)]
Bug 13789 - facets with accented utf-8 characters generate double encoded links

Bug 13425 tried to fix XSS in OPAC, by using url filter in template toolkit
on whole generated url. This doesn't work and create double encoded strings
in facets because we are creating url variable by concatenating query_cgi
(which did pass through uri_escape_utf8 on perl side) and other
parameters which have to be escaped in template.

Also, code like

[% SET limit_cgi_f = limit_cgi | url %]

doesn't do anything (at least doesn't apply url filter) so it's not needed.

This patch also fixes encoding of hidden fields used in sort by form.

And lastly, it tries to make facet changes for opac and intranet as same as
possible to simplify future maintencence of this code.

Test scenario:
1. find results in your opac which contain accented characters
2. click on them and verify that results are missing
3. apply this patch
4. re-run search and click on facets link verifying that there are
   now results
5. test sort by form and verify that results are ok
6. verify that facets are still safe from injection by constructing url like
   /cgi-bin/koha/opac-search.pl?q=123&sort_by='"><script>prompt('Happy_Holidays')</script>&limit=123
   and verifying that you DON'T see prompt window in your browser

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 13635: Unimarc - On editing a notice, the title should be displayed
Jonathan Druart [Wed, 28 Jan 2015 12:03:31 +0000 (13:03 +0100)]
Bug 13635: Unimarc - On editing a notice, the title should be displayed

The title method of MARC::Record does not deal with UNIMARC, it should
not be called if the marc flavour is UNIMARC.

Test plan:
On an unimarc installation, edit a notice, with this patch you should
see
 "Editing TITLE (Record number BIBLIONUMBER)"

Without, the title was not displayed.
Same in the breadcrumbs.

Bug 13635: Remove another useless call

There is another call to the title method in additem.pl without any
check on the marc flavour.
But here the title variable sent to the template is redefined 3 lines
later.
So it can be simply removed.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tested on UNIMARC install, editing a 'record' (not notice) does not show
title on breadcrumbs, status bar or page title.
With patch it does!
No koha-qa errors.

Signed-off-by: joel aloi <aloi54@live.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: DBRev 3.19.00.013
Tomas Cohen Arazi [Thu, 5 Mar 2015 14:49:25 +0000 (15:49 +0100)]
Bug 11395: DBRev 3.19.00.013

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: A control field is a field with tag < 10
Jonathan Druart [Mon, 15 Dec 2014 09:29:36 +0000 (10:29 +0100)]
Bug 11395: A control field is a field with tag < 10

This patch fixes the existing test about control fields.
A control field is < 10, not <=10!

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: Raise an alert if control field is used
Jonathan Druart [Wed, 3 Sep 2014 13:08:39 +0000 (15:08 +0200)]
Bug 11395: Raise an alert if control field is used

If a control field is used with a copy or move action, the interface
should block the user in some cases:
- If a control field is used with a regular field
- The subfield should be empty

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: exit should be done after displaying the output
Jonathan Druart [Fri, 10 Oct 2014 18:20:54 +0000 (20:20 +0200)]
Bug 11395: exit should be done after displaying the output

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: prevent processing no record
Jonathan Druart [Tue, 8 Jul 2014 08:01:31 +0000 (10:01 +0200)]
Bug 11395: prevent processing no record

If no record is selected, the modification should not be launched.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: Fix path for the checkboxes jQuery plugin
Jonathan Druart [Fri, 4 Jul 2014 08:40:21 +0000 (10:40 +0200)]
Bug 11395: Fix path for the checkboxes jQuery plugin

This patch fixes a bad resolution conflict (bug 12107).

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: DB: Add permission tools_records_batchmod
Jonathan Druart [Thu, 12 Dec 2013 20:14:47 +0000 (21:14 +0100)]
Bug 11395: DB: Add permission tools_records_batchmod

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: The modification template should be changed on the list view
Jonathan Druart [Mon, 16 Dec 2013 16:02:25 +0000 (17:02 +0100)]
Bug 11395: The modification template should be changed on the list view

This patch fixes the following issue:
If the user comes from a basket, the list view is displayed but there is
no way to select the modification template.

Now the template can be chosen on the list view. This way, the user is
able to change the modifications to apply and see the previewed records.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: New service to preview a record.
Jonathan Druart [Thu, 12 Dec 2013 20:15:06 +0000 (21:15 +0100)]
Bug 11395: New service to preview a record.

The main patch adds the ability to preview a record. This is done using
an AJAX way. The preview record is processed on the server side.

Note: I don't think an authentification check is necessary here.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: Add links to the new tool page
Jonathan Druart [Thu, 12 Dec 2013 20:13:15 +0000 (21:13 +0100)]
Bug 11395: Add links to the new tool page

This patch adds links in the tool module to the new batch tool and in
the basket.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
9 years agoBug 11395: Add a batch record modification
Jonathan Druart [Thu, 12 Dec 2013 20:13:53 +0000 (21:13 +0100)]
Bug 11395: Add a batch record modification

This patch offers a new tool to modify records in a batch.

This feature adds:
- a new pl/tt files tools/batch_record_modification
- a new permission: tools > records_batchmod

Test plan for biblios:
0/ Create a new marc modification template with some actions.
1/ Generate a list of biblionumbers you want to modify.
There are two ways to generate a list of biblionumbers:
- using the basket: do a search, add some biblio to your basket, open
  the basket and click on the "Action" button > "Modify"
- generating a list from a report
2/ On the "Batch record modification" tool verify:
- information is correct.
- the preview link show you the needed record.
3/ After clicking on the "Modify selected recors" button, verify
the records have been modified as you wanted.

Test plan for authority:
0/ Create a new marc modification template with some actions.
1/ Generate a list of authid using a report:
2/ On the "Batch record modification" tool verify:
- authorities are display with the summary.
- the preview link show you the needed record.
3/ After clicking on the "Modify selected recors" button, verify
the records have been modified as you wanted.

Catch of errors:
if an error occurs during the modification process, the tool
displays an error message.

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>