Allen Reinmeyer [Thu, 6 Nov 2008 20:43:26 +0000 (14:43 -0600)]
UPDATE:Bug #2756 opacbookbag preference turns off add items to list
There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list. Javascript wasn't including basket.js on virtualshelves option. Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.
UPDATED: Removed EXPR in TMPL_IF conditions
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 6 Nov 2008 08:41:48 +0000 (09:41 +0100)]
Some tab cleaning
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 6 Nov 2008 08:34:06 +0000 (09:34 +0100)]
fix the private shelf deletion in opac
this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 6 Nov 2008 19:04:11 +0000 (13:04 -0600)]
Adding javascript to let user click table cell to check containing checkbox.
This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 6 Nov 2008 10:58:38 +0000 (11:58 +0100)]
make some line REAL comments, else the installer is buggous
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 30 Oct 2008 05:10:57 +0000 (00:10 -0500)]
Squash warnings by checking if $type is defined before comparing it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 27 Oct 2008 19:41:01 +0000 (14:41 -0500)]
This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 27 Oct 2008 16:55:13 +0000 (11:55 -0500)]
Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Fri, 24 Oct 2008 14:45:24 +0000 (09:45 -0500)]
bug 2707 - overdue rules not being deleted
* I added some code to detect the rows which were blank,
and I deleted them upon saving the form.
* Updated to get the categories from the database
instead of hardcoding them.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 30 Oct 2008 05:14:25 +0000 (00:14 -0500)]
Circ cleanup.
Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort. The rest is whitespace cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Tue, 4 Nov 2008 20:34:53 +0000 (14:34 -0600)]
Allow SIP checkout to pre-empt unfilled holds.
This affects transactions on items that may be covered by
a title or item-level hold, but have not yet been retrieved
from the stacks (i.e. "confirmed") by the librarian. This does
not affect waiting holds (found="W"), so they will still block
transaction unless they belong to the operating patron.
Also I cleanup any hold the patron has on a biblio/item when
they are allowed to checkout the item.
Here we are filling the hold because the checkout is allowed, regardless
of of the queue position. This is different from AddIssue's CancelReserve, that
only fills the hold if it is next in line, but in the future AddIssue should
adopt a similar logic.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Tue, 4 Nov 2008 20:34:52 +0000 (14:34 -0600)]
followup - make barcode_to_borrowernumber an internal function
Set this function apart with _ since it is not OO like the rest.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Clay Fouts [Tue, 28 Oct 2008 00:04:25 +0000 (17:04 -0700)]
bug 2729: redundant call to C4::Biblio::get_biblio_authorised_values
Removes redundant and expensive call to C4:Biblio:get_biblio_authorised_values
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 28 Oct 2008 00:31:34 +0000 (19:31 -0500)]
Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 28 Oct 2008 00:40:03 +0000 (19:40 -0500)]
Terminology and spelling corrections. Fixes Bug 2724.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 29 Oct 2008 14:16:41 +0000 (09:16 -0500)]
Spelling correction: catalogue -> catalog. Fixes Bug 2730.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 14 Oct 2008 20:36:42 +0000 (14:36 -0600)]
Add fine amount to display on circ pages.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Oct 2008 21:07:19 +0000 (16:07 -0500)]
bug 2682: followup - only do lc() on $op once
Per suggestion by Joe Atzberger.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 15:36:32 +0000 (10:36 -0500)]
Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 21:24:22 +0000 (16:24 -0500)]
Unravelling links in masthead. Regularize logic and improve readability.
Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself. This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc. I would argue even this is undesirable. At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery. IMHO, masthead itself should not be engage in such trifling
interface polishes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Thu, 23 Oct 2008 19:16:18 +0000 (14:16 -0500)]
Bug #2709 Cannot add from Search to New list
While a new list was created, no subsequent call to add the biblio number was made,
thus a new empty list would be created every time.
Under the existing list add, the same code to add items would also apply to a new list,
so I refactored out the logic to add items and made a new subroutine.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Oct 2008 17:34:05 +0000 (12:34 -0500)]
followup to Calendar overhaul
correct an errant "SELECT FROM" that slipped in
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:47 +0000 (19:02 -0500)]
Begin Calendar overhaul, turn on warnings.
Reuse SQL with placeholders where possible.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 23 Oct 2008 17:05:56 +0000 (12:05 -0500)]
bug 2543: follow-up patch
Add 'use C4::Reports' lines that original patch
omitted.
Note that original patch prevented these two reports
from even compiling. Not good.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Jesse Weaver [Wed, 10 Sep 2008 00:31:31 +0000 (19:31 -0500)]
fix for bug 2543: report output by tabulation a bit too literal
This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Thu, 23 Oct 2008 16:01:03 +0000 (11:01 -0500)]
Patch security hole in vestigial report.
IMHO, this report should be removed in entirity because of its faulty
construction and total inability to distinguish between register "tills".
That is, it appears to be a valid accounting measure but isn't.
In any case, it let's not let just anybody run it!
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:31 +0000 (18:11 -0500)]
followup 5 to renewal limit override
With removal of content_hidden CSS class from
the circ templates, undoing change to staff-global.css
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:30 +0000 (18:11 -0500)]
followup 4 to renewal limit override
* use style="display: none" instead of content_hidden
* fix JavaScript so that actions that check/uncheck
items for a renew or return do not affect
the override renewal limit checkbox
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:29 +0000 (18:11 -0500)]
followup 3 to to renewal limit override
style="display: none" suffices to have a span
be hidden initially; content_hidden is not necessary.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:28 +0000 (18:11 -0500)]
followup 2 to to renewal limit override
Remove duplicate entry for SMSSendDriver syspref
added by original patch.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 23:11:27 +0000 (18:11 -0500)]
followup 1 to to renewal limit override
Update POD for CanBookBeRenewed().
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 22 Oct 2008 23:11:26 +0000 (18:11 -0500)]
Allow renewal limits to be overridden
Originally by Jesse Weaver <jesse.weaver@liblime.com>
This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 16 Oct 2008 15:45:29 +0000 (10:45 -0500)]
Steamlining javascript for cloning additem block and tweaking style.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 17 Oct 2008 14:19:12 +0000 (09:19 -0500)]
Adding some body IDs to OPAC pages to enable finer per-page control via CSS.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 20 Oct 2008 15:42:59 +0000 (10:42 -0500)]
Changing checkboxes to radio buttons (as it is in the OPAC), since you can't place a hold on more than one specific item. Also includes some markup cleanup.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 17 Oct 2008 14:19:24 +0000 (09:19 -0500)]
Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
John Beppu [Wed, 22 Oct 2008 20:34:06 +0000 (15:34 -0500)]
1571
made the description show up by running the query w/ the required number of params
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Allen Reinmeyer [Wed, 22 Oct 2008 17:20:49 +0000 (12:20 -0500)]
Bug #2030 z3950 search function does not filter
Entering a term in the z3950 search box does not filter the results.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 22 Oct 2008 20:22:46 +0000 (15:22 -0500)]
bug 2692: remove escape="url" from opac-facets.inc
Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.
For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 14:04:54 +0000 (09:04 -0500)]
OPAC-side ISBN display fix (Bug 2592)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 14 Oct 2008 18:50:47 +0000 (13:50 -0500)]
Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 15:18:14 +0000 (10:18 -0500)]
Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Fri, 17 Oct 2008 03:25:27 +0000 (22:25 -0500)]
Bug 2660: Add command-line options to overdue notice script.
This commit adds two options to the overdue_notices.pl script.
The notices are now generated in one of two modes: default or triggered.
In default mode, every time the script runs, a notice is generated if an item
is overdue within a notice date range. This mode is suitable for a weekly cron
(or manual run), but the notice triggers should be syncronized with the cron script such that
the script is run once per notice date range. Otherwise, duplicate messages will
be generated ( or no notice generated if a notice date range passes without the script being run).
Triggered mode is suitable for a nightly cron job: a notice is generated only on those
days that an overdue item enters a notice date range. This mode is susceptible to message
loss when the cron script fails to run, or when notice triggers are edited.
A second flag is added: --list-all, which causes items.content to list all currently overdue items.
Without this flag, only items that are overdue within the given notice's date range are listed on
that notice.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Fri, 17 Oct 2008 07:38:13 +0000 (09:38 +0200)]
Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 20:45:41 +0000 (15:45 -0500)]
followup - use & in place of &
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:45 +0000 (19:02 -0500)]
Bug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.
Date fields are now checked against syspref and iso regexps before attempting
to convert or insert them. The problem characters were non-ASCII diacriticals.
Note: this may rely on improvements in the current 0.54 version of Text::CSV and
Text::CSV_XS, rather than the Koha minimum of 0.01 and 0.32, respectively.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Thu, 16 Oct 2008 19:59:44 +0000 (13:59 -0600)]
fix calls to get_template_and_user in label-item-search.pl
remove extra flagsrequired line.
move call in first branch to the top.
This will be important is IndepenantBranches code is later added to,
for example, C4::Items::get_itemnumbers_of()
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 7 Oct 2008 18:51:07 +0000 (13:51 -0500)]
Some minor markup corrections to opac authorities pages. Some fixes to address Bug 2620.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 7 Oct 2008 17:30:27 +0000 (11:30 -0600)]
bug in 'Add/Change link to item details...' I missed Previous checkouts area
This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Thu, 9 Oct 2008 21:15:56 +0000 (16:15 -0500)]
Bug 2622 & 2623 : tools permissions for edit notice triggers and picture upload overly restrictive
removing requirements for parameters & management respectively for these two tools.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 7 Oct 2008 21:58:07 +0000 (15:58 -0600)]
Adding a few columns to members/readingrec.pl
Add barcode and issues.renewals to members/readingrec.pl
Had to change the query in C4/Members, items.renewals was squashing
issues.renewals.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 7 Oct 2008 22:04:14 +0000 (16:04 -0600)]
In members/readingrec.pl use itemcallnumber is classification isn't set
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Mon, 6 Oct 2008 01:40:24 +0000 (20:40 -0500)]
bug 2659: fix crash in OAI-PMH interface
When retrieving a record via the OAI-PMH interface, if one of the fields used
to prepare the DC metadata is not defined in the MARC framework (e.g.,
biblioitems.publicationyear in the default MARC21 framework), an OAI GetRecord
can fail with the following error:
> Can't call method "as_string" on an undefined value at
> /usr/share/koha/opac/cgi-bin/opac/oai.pl line 59.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 1 Oct 2008 20:14:56 +0000 (14:14 -0600)]
bugfix: Sort previous borrowers descending in Items.pm for moredetail.pl
The list of previous borrowers on moredetail.pl shows the three oldest
rather than the three most recent as I expected. This changes the sql
to order descending so we get the three most recent.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 19:27:16 +0000 (14:27 -0500)]
bugfix: reenable listing suggestions by anyone
Change in parameter name in template not reflected
in script.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Henri-Damien LAURENT [Tue, 2 Sep 2008 22:03:15 +0000 (00:03 +0200)]
Displaying branchnames rather than branchcodes
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 9 Sep 2008 20:33:32 +0000 (14:33 -0600)]
Don't pull all of biblioitems in GetItemsInfo
Pulling marc and marcxml for some 1200 copies takes a lot of RAM. Lets
not do that.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Thu, 16 Oct 2008 12:48:14 +0000 (14:48 +0200)]
Fix the CSV export, provide it in UTF-8
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 15:44:56 +0000 (10:44 -0500)]
debugify a warn
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 15:24:32 +0000 (10:24 -0500)]
bugfix: fixed reference to sort2 column in query
Fixes following error when using the patron statistics report:
DBD::mysql::st execute failed: Unknown column 'sort' in 'where clause' at /home/gmc/koha/dev/reports/borrowers_stats.pl line 127
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 14:05:11 +0000 (09:05 -0500)]
Some changes to improve display on Internet Explorer.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 14:05:23 +0000 (09:05 -0500)]
Changes to prevent javascript errors in Internet Explorer
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Thu, 16 Oct 2008 15:10:09 +0000 (10:10 -0500)]
followup on Owen's patron attributes patch
Hide the display of the patron attributes only if
no types are defined; the patron attributes section
(and more importantly, the edit link), should still
be displayed if an attribute type is defined, even
if the patron has no attributes currently set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Nahuel Angelinetti [Wed, 15 Oct 2008 07:38:47 +0000 (09:38 +0200)]
Add the feature to create reports with borrower's sex information(Men/Women) (bug #2671)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 14:24:58 +0000 (09:24 -0500)]
Spelling correction (catalogue -> catalog)
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 15 Oct 2008 14:04:10 +0000 (09:04 -0500)]
Hiding patron attributes entry if not configured.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 15 Oct 2008 13:52:34 +0000 (08:52 -0500)]
bug 2677: restore RandomizeHoldsQueueWeight and StaticHoldsQueueWeight
Restoring the functionality of these sysprefs as part of the
rework of build_holds_queue.pl:
* StaticHoldsQueueWeight is an ordered list of library codes.
The order of the libraries in this list determines the order
of libraries in which available items will be chosen to be
targeted to holds. Note that if this list does not include
a library, items from that library will never be targeted to
holds and staff will never be asked to retrieve items for
title-level holds from those libraries.
* RandomizeHoldsQueueWeight is a Boolean parameter, indicating
whether to randomize the libraries in the StaticHoldsQueueWeight
list.
If neither RandomizeHoldsQueueWeight nor StaticHoldsQueueWeight is
set, then the libraries will be used to target items to holds in
alphabetical order by library code.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 7 Oct 2008 14:21:01 +0000 (09:21 -0500)]
More corrections to fix Bug 2649, "minPasswordLength Sys Pref does nothing." Previous patch included typo copied from member-password.pl. Both are corrected now.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Wed, 8 Oct 2008 05:31:24 +0000 (00:31 -0500)]
Remove ambiguity from SQL statement for holds queue.
holdingbranch table not referenced in view_holdsqueue.pl, causing irresolvable ambiguity in
sql query when limited by library (holdingbranch). This was causing DBI errors to be thrown
in test database, and library-limited holdsqueue display was thus empty.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Marc Chantreux [Wed, 8 Oct 2008 11:05:01 +0000 (13:05 +0200)]
2663 fix
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Tue, 14 Oct 2008 18:10:28 +0000 (13:10 -0500)]
followup - make barcode_to_borrowernumber() work as named
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Thu, 9 Oct 2008 22:53:37 +0000 (17:53 -0500)]
SIP Holds processing on checkout
Allow valid comparison of hold_queue to current user barcode and
permit checkout if the current user is at the front of the queue.
Effectively, this allows a user to checkout a book he has held.
Here are the example checkout (11) and checkout response (12)
statements in a SIP telnet session, showing failure (120) previously
and success (121) after patch application.
Before:
11YN20060329 203000 AOCPL|AA1|
AB502326000820|ACterm1
120NUN20081009 140222AOCPL|AA1|
AB502326000820|AJKidnapped :|AH|AF2008-10-09 : Koha Admin (1)|BLY|
After:
11YN20060329 203000 AOCPL|AA1|
AB502326000820|ACterm1
121NNY20081009 150204AOCPL|AA1|
AB502326000820|AJKidnapped :|AH2008-10-10|AFItem was reserved for you.|
This patch also resolves security/privacy issues related to the display
of "needsconfirmation" values that identify, for example, the user
currently issued an item, or with a hold on the item. These messages
should not be passed to an end-user interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger (siptest [Thu, 9 Oct 2008 22:53:36 +0000 (17:53 -0500)]
Fully qualify function call.
This is a pre-requisite to continued SIP processing, dealing with some
arcana related to recursive dependencies and UNIVERSAL. The reason this
is separate from other SIP patches is that it is expected patched in other
submissions already.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Fri, 3 Oct 2008 16:16:10 +0000 (11:16 -0500)]
Another correction to eliminate left column from print view.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Ryan Higgins [Sat, 27 Sep 2008 17:57:08 +0000 (12:57 -0500)]
Bug 2555 : label batch_id not properly incremented after batch num 10.
This is a stop-gap fix intended for 3.0 maintenance release.
3.2 should include a label_batches table which will allow named
batches to be associated with a template & layout, and fix the
column definition of batch_id here to be an auto_incr int.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 1 Oct 2008 19:29:50 +0000 (13:29 -0600)]
More Consistant terminoligy in stage-marc-import.tmpl
Changes 'Notes about this file' to 'Comments about this file'. It's
'Comments' in the manage-marc-import.tmpl file.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 2 Oct 2008 16:24:04 +0000 (11:24 -0500)]
Hiding minimum password hint if there is no minimum password length set.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 1 Oct 2008 17:39:17 +0000 (12:39 -0500)]
Fix for Bug 2649, "minPasswordLength Sys Pref does nothing." Adds note specifying minimum password length to patron entry form, and generates warning if submitted password is not long enough.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Thu, 2 Oct 2008 16:23:49 +0000 (11:23 -0500)]
Corrections to manage marc import interface, including fix for inaccurate progress bar.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Mon, 15 Sep 2008 16:33:32 +0000 (11:33 -0500)]
Adding javascript to prevent premature submission of forms when using a barcode scanner (or by hitting the enter key). Addresses Bug 2591
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 10 Sep 2008 19:12:56 +0000 (13:12 -0600)]
bug: query squashes issues.timestamp which circulation.pl needs to sort todaysissues
Little change to the query so we get the right timestamp to sort on.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 2 Sep 2008 19:57:09 +0000 (13:57 -0600)]
bug: chargelostitem() didn't unset onloan on the item record.
I don't think this is left set intentionally.
If an item is set lost and it's on loan it's marked returned, but it
wasn't set as not on loan.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Tue, 2 Sep 2008 22:13:16 +0000 (16:13 -0600)]
bug: sticky due date isn't stick if there is a question about an issue
the stickyduedate input isn't sent on from the question dialogs. This
causes it to un-stick if there is a question.
Also removed month, day, and year as there seems to be no use for them.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 1 Oct 2008 18:04:16 +0000 (12:04 -0600)]
Reduce logging from rebuild_zebra.pl with a command line option
This reduces the output of the script and zebraidx, and creates a -v
command line switch which will increase the logging to their former
states.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 24 Sep 2008 16:26:33 +0000 (11:26 -0500)]
Eliminate left-column margin on print view
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
paul [Mon, 22 Sep 2008 16:31:54 +0000 (18:31 +0200)]
BUGFIX missing div
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Pianohacker [Fri, 26 Sep 2008 19:57:25 +0000 (14:57 -0500)]
fix date formatting in overdue_notices.pl
This makes overdue_notices.pl format dates in fields that both start and end with 'date'.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Michael Hafen [Wed, 1 Oct 2008 15:48:18 +0000 (09:48 -0600)]
bugfix: Add a message to circulation.pl if item is restricted
Don't know how this was missed. If an item is restricted it isn't
allowed to be issued, but there is no message about why it can't be
issued, just the yellow box.
This adds a message saying "item is restricted".
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Fri, 26 Sep 2008 17:25:58 +0000 (19:25 +0200)]
Bugfix #2630 2nd attempt
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 30 Sep 2008 22:00:40 +0000 (17:00 -0500)]
Remove hardcoded "Freelist" line from Auth.
Apparently a leftover debugging snippet.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 30 Sep 2008 00:00:29 +0000 (19:00 -0500)]
Markup and formatting improvements to Manage Staged Records interface.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Tue, 30 Sep 2008 00:00:20 +0000 (19:00 -0500)]
Adding progress bar and some other visual enhancements to file upload interactions.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Frederic Demians [Tue, 23 Sep 2008 15:47:11 +0000 (17:47 +0200)]
Bugfix #2633
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 23 Sep 2008 17:15:11 +0000 (12:15 -0500)]
Bug 2587 followup, updated test.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Tue, 23 Sep 2008 17:01:48 +0000 (12:01 -0500)]
Convert to C4::Debug, comment out unused Data::Dumper.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Andrew Moore [Fri, 19 Sep 2008 15:42:54 +0000 (10:42 -0500)]
bug 2628: fixing test script to deal with DESTDIR in Makefile.PL
Recently, there were changes to the Makefile.PL to make it install in a
DESTDIR that the OS (debian) may choose. This broke the test suite.
Since we're not installing the stuff in the t/ directory, we need to
ignore the DESTDIR specifiation before we write the test-config.txt.
So, this patch adds a call to the _strip_destdir function for all
directories written to the t/test-config.txt file.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 19 Sep 2008 00:02:49 +0000 (19:02 -0500)]
Revising the stub for ILS/Transaction/FeePayment.pm
Obviously more implementation is needed.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Owen Leonard [Wed, 17 Sep 2008 15:03:34 +0000 (10:03 -0500)]
More fixes for Bug 2600, enabling the appearance of HTML tags in item titles. Resubmission.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 17 Sep 2008 12:07:51 +0000 (07:07 -0500)]
bug 2615: remove unneeded 'require Exporter'
Most Perl scripts (as opposed to modules) do
not need to require Exporter.
No user-visible or documentation changes.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Fri, 19 Sep 2008 00:09:02 +0000 (19:09 -0500)]
bug 2625: finish fix by converting another array to hash
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>