Chris Nighswonger [Thu, 7 Aug 2008 21:05:41 +0000 (16:05 -0500)]
kohabug 2427 Correcting C4::Items:: _koha_new_item to populate items.copynumber
The INSERT was missing the copynumber parameter. moredetail.pl was also not setting
the copyvol template variable. This patch corrects these issues so that the copynumber
is both inserted when a new item is created (including during a bulkmarcimport.pl run)
and displayed properly on moredetail.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Wed, 6 Aug 2008 20:43:51 +0000 (15:43 -0500)]
kohabug 2448 Correcting Alignment of Column Headers
This patch corrects the alignment of the column headers in the overdues list
on the 'Overdue' tab on opac-user.pl It also corrects the template to display
the item type rather than the Koha collection type.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 6 Aug 2008 20:17:51 +0000 (15:17 -0500)]
Add missing </td> to opac-user.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 6 Aug 2008 19:49:30 +0000 (14:49 -0500)]
Minor change to correct offset problem for Cart popup. Libraries with opacheader markup specified were finding their Cart popup appearing out of place.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 6 Aug 2008 16:14:26 +0000 (11:14 -0500)]
Bug 2084 [2/2]: Database version 3.00.00.107: adding warnings to three system preferences
This patch adds warnings to the OPACShelfBrowser, CataloguingLog, and NoZebra system preferences. Using
them on busy koha installations has proven to be rather resource intensive.
This is considered a stopgap solution. Making these features less resource using to run
would be preferred.
Note to documentation writers: screenshots of these system preferences could be updated, but
no functionality has changed.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 6 Aug 2008 16:14:25 +0000 (11:14 -0500)]
Bug 2084 [1/2]: adding warning to overdues report
This patch adds a warning to the staff interface on the circulation page
to indicate that the overdues report is resource intensive on large installations.
This is considered a stopgap solution. Ideally, this report should be changed in order
to make it usable even for large installations.
Documentation note: Although no functionality has changed, any screenshots of the
circulation page on the staff interface should be updated.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 6 Aug 2008 16:32:15 +0000 (11:32 -0500)]
bug 2479: allow MARC21 bib 440 to link to authorities
Fixed overly-strict interpretation of OCLC practice
that prevented 440 series statement/added entries
from linking to the appropriate series authority
record.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 16:53:29 +0000 (18:53 +0200)]
partial fix for #2471, (overdue notice sent twice)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 6 Aug 2008 15:35:05 +0000 (10:35 -0500)]
Reformatting serials item edit screen to eliminate label truncation and give it additem-like layout. Also correcting some markup errors, both in the template and in markup generated by Biblio.pm. HDL: I assume this will be superceded at some point by an include, but wasn't sure if that would be in time for 3.0.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 6 Aug 2008 14:54:42 +0000 (09:54 -0500)]
bug 1433: use same bib when adding new subscription from details page
When viewing the subscription details page of a bib that already
has at least one subscription, clicking on the 'New Subscription'
button in the toolbar will fill in the biblionumber and title
in the new subscription form.
Clicking on the 'New Subscription' button in other context (e.g.,
when viewing the results of a search) will leave the biblionumber
and title fields unpopulated, as there is no specific bib to
use.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 6 Aug 2008 08:44:46 +0000 (03:44 -0500)]
Patron import reform - bug 2287 - expanded error catching and feedback
This incorporates and extends the patch from MJ Ray attached to bug 2287.
Added feedback of up to 25 lines, including for errors at the Text::CSV
parsing level. This allows feedback for problems than involve encoding.
Added link to download "starter" CSV file (with all the columns).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Tue, 5 Aug 2008 14:27:14 +0000 (16:27 +0200)]
Bug fixing : 2470 Serials forgetting library
Using default values for PrepareItemrecordDisplay
It changes Biblio.pm
Adding a hash with default values to PrepareItemrecordDisplay
Usunf that API in Serials.pm and serials-edit.pl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Wed, 6 Aug 2008 12:59:58 +0000 (14:59 +0200)]
Bug fix : 2361 Location was lost on subscription update
Location is now defaulted to the location of the librarian
When updating subscription, subscription branchcode is taken into account.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 16:53:30 +0000 (18:53 +0200)]
bugfix for #2472
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 16:53:28 +0000 (18:53 +0200)]
Adding Email::Date dependancy, requested by MIME::Lite
(no bugzilla entry)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Marc Chantreux [Wed, 6 Aug 2008 09:23:36 +0000 (11:23 +0200)]
use alphabetical order to popup the cities
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 6 Aug 2008 02:16:09 +0000 (21:16 -0500)]
bug 2317: avoid crash when auto-creating authority
If BiblioAddsAuthorities is ON, saving a MARC bib record
in the cataloging editor can create new authority records.
When using MARC21, if one of those authority records
has diacritics in its heading, the save crashes with the
following error:
Wide character in null operation at
/usr/local/share/perl/5.8.8/MARC/Charset/Table.pm line 96
To prevent this, new MARC21 authorities created by
BiblioAddsAuthorities have the Leader/09 set to 'a'. Note
that this is not currently required for UNIMARC authorities,
as MARC::File::XML->as_xml_record() does not attempt
to transcode UNIMARC records from MARC-8 to UTF-8.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Tue, 5 Aug 2008 20:01:42 +0000 (15:01 -0500)]
bug 2473: correct display of items.content
Correct bug in output of overdue notices that has
items.content displaying only the number of columns
in each items.content structure (currently, 4).
Patch inspired by patch submitted by Paul Poulain.
[LL bug 31]
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Tue, 5 Aug 2008 13:10:01 +0000 (15:10 +0200)]
bugfix for 2451 : serial recieve & barcode does exist complaint
If barcode already exists, then return an error.
making some checks on values passed through the code.
Duplicated serialid and subscriptionid are displayed only once.
This manage multiple errors on barcode and displays them.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Tue, 5 Aug 2008 13:12:49 +0000 (08:12 -0500)]
Revert "bugfix for 2451 : serial recieve & barcode does exist complaint"
This reverts commit
23b8da277b0a1aa67f0686aa65a9e0d527a3b26b.
Galen Charlton [Mon, 4 Aug 2008 23:50:37 +0000 (18:50 -0500)]
bug 2411: fix adding new tag to authority framework
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Tue, 5 Aug 2008 03:50:01 +0000 (22:50 -0500)]
Final patch for serials planning bugs
This patch resolves bug 1580 and addresses the modification of firstacquidate as per hdl's comments.
I have also removed some useless javascript from subscription-detail, and just reported the number of
irregular issues there (previously was reporting nothing since the js was broken).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Mon, 4 Aug 2008 14:09:41 +0000 (09:09 -0500)]
Rename crontab.example
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 4 Aug 2008 18:21:06 +0000 (13:21 -0500)]
Correcting markup for validity.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 4 Aug 2008 15:15:23 +0000 (10:15 -0500)]
bug 2459: fix module depedency error blocking SIP2
Ror a poorly understood (by me) reason, use of 'use
UNIVERSAL' and 'use C4::Auth' in the SIP2 code is resulting
in a compilation error, thus blocking SIP2 from working.
The error (prior to this patch) could be reproduced as follows:
cd C4/SIP
perl -I. -wc Sip/MsgType.pm
"get_session" is not exported by the C4::Auth module
Can't continue after import errors at /home/gmc/koha/dev/C4/VirtualShelves.pm
line 51
BEGIN failed--compilation aborted at /home/gmc/koha/dev/C4/VirtualShelves.pm
line 51.
Compilation failed in require at /home/gmc/koha/dev/C4/Auth.pm line 34.
BEGIN failed--compilation aborted at /home/gmc/koha/dev/C4/Auth.pm line 34.
Compilation failed in require at Sip/MsgType.pm line 21.
BEGIN failed--compilation aborted at Sip/MsgType.pm line 21.
or more minimally
perl -ce 'use UNIVERSAL; use C4::Auth;'
This patch works around the problem by making C4::Auth
and C4::VirtualShelves not import any symbols
from each other.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:22 +0000 (10:15 -0500)]
kohabug 2457 Minor patch to correct GD
version number
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:21 +0000 (10:15 -0500)]
kohabug 2456 Moving certain C4::VirtualShelves.pm subs from EXPORT
to EXPORT_OK and correcting associated syntax
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:20 +0000 (10:15 -0500)]
kohabug 2437 Corrects LIMIT offset algorithm
Because of a miscalculation in the offset algorithm, the LIMIT offset creeps
backwards by a magnitude for every page beyond page two. This patch corrects
the algorithm to behave as expected.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:19 +0000 (10:15 -0500)]
kohabug 2417 Removing hardcoded query limit from reports
This patch removes a hardcoded 'LIMIT 20' which was added to all report queries
thus limiting all reports to only the first twenty rows of applicable data. In
its place this patch introduces code to paginate through all applicable data,
regardless of how many rows are available. The code will also honor any user
defined 'LIMIT' in reports based on SQL entered directly by the user.
This patch also adds column labels to 'tab' and 'csv' files generated by reports.
NOTE: Only user defined 'LIMIT's apply to 'tab,' 'csv,' and 'text' files.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 4 Aug 2008 15:15:18 +0000 (10:15 -0500)]
kohabug 1679 & 1680 Fixes date formatting in guided reports wizard
This patch corrects date formatting when defining dictionary definitions in the
guided reports wizard so that dates display according to syspref.
Date formating is also corrected in the report creation section of the guided
reports wizard.
It also corrects a javascript bug which caused some of the calander widgets not
to function properly.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Mon, 4 Aug 2008 13:31:07 +0000 (15:31 +0200)]
bugfix for 2451 : serial recieve & barcode does exist complaint
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Nicole Engard [Mon, 4 Aug 2008 13:34:45 +0000 (09:34 -0400)]
Help file updates
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Mon, 4 Aug 2008 13:32:55 +0000 (08:32 -0500)]
Putting the db revision from 105 into 106 as it wasn't
applied in 105
Paul POULAIN [Sat, 2 Aug 2008 17:22:03 +0000 (19:22 +0200)]
very small french translation fix
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Sat, 2 Aug 2008 17:22:02 +0000 (19:22 +0200)]
bump to 106, bug 2452, subscriptionhistory.enddate can be 0000-00-00
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Sat, 2 Aug 2008 17:22:01 +0000 (19:22 +0200)]
dealing with L' and D' in french
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Sat, 2 Aug 2008 14:53:14 +0000 (16:53 +0200)]
unimarc plugin fix, suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Mon, 4 Aug 2008 01:37:51 +0000 (20:37 -0500)]
Serials planning: Update subscription edit to properly deal with date changes. ( patch 3 / 3 )
Previously subscription-add.pl allowed modification of 'firstacquidate', which changed
the subscription definition, but did not affect prediction. This patch adds two fuctions
to Serials.pm to get/set the current expected issue date (note that all date calculations
in prediction patterns are based on the current expected date, and there's only one serial
issue per subscription in the 'expected' status at any time). Subscription editing
now allows you to edit the next expected date, but not the first acqui date (unless you
haven't received any issues yet), thus allowing for adjustments in the prediction pattern.
This patch also updates fixes some discrepancies in irregularities / prediction display.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Mon, 4 Aug 2008 01:10:15 +0000 (20:10 -0500)]
Update serials planning javascript to properly deal with 3-level periodicity. ( Serials patch 2/3 )
Minor changes to dom object names and id's to allow for proper calculation of the
base planning table from the simplified table.
Prior to this patch, the base table was populated with the incorrect value, so patterns like
Vol{X} No{Y} Issue{Z} incremented the Vol value incorrectly.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Mon, 4 Aug 2008 01:05:55 +0000 (20:05 -0500)]
Serials planning updates patch 1/3
This patch addresses usability and interface bugs in the javascript irregularity checks by
adding extra controls: 'test pattern' button (always visible) replaces the 'irregularity' link
that was previously only sometimes visible. A 'show advanced pattern' button will display/hide the
base prediction table at any time. A 'reset pattern' button is added. The form may now also be submitted
even if it fails the irregularity test, as there are cases when this will result in the desired behavior.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 1 Aug 2008 20:24:35 +0000 (15:24 -0500)]
Fixing markup error in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Danny Bouman [Fri, 1 Aug 2008 20:08:51 +0000 (16:08 -0400)]
bug 2450: expanded size of cardnumber input field
Expanded the size of the cardnumber input field to 20 instead of 10. This allows the full 14-digit barcode to be viewed at a glance without having to
scroll.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Frederic Demians [Tue, 29 Jul 2008 09:05:37 +0000 (11:05 +0200)]
Bugfix #2414
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 30 Jul 2008 15:03:05 +0000 (17:03 +0200)]
BUGFIX fix on 2380 fix, dump to 102
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 1 Aug 2008 16:33:11 +0000 (11:33 -0500)]
Correcting structure and markup.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Fri, 1 Aug 2008 14:00:00 +0000 (09:00 -0500)]
Complete sweep of help files in order to correct invalid markup and fix Bug 2444(break up long lines in templates).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Thu, 31 Jul 2008 11:21:31 +0000 (13:21 +0200)]
small typo/html fixes as suggested by Zeno Tajoli
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Wed, 30 Jul 2008 16:18:02 +0000 (11:18 -0500)]
bug 2335: adding SMSSendDriver system preference - DB update to version 3.00.00.105
Previously, the SMSSendDriver system preference was set as a local use system
preference. This patch makes it an official system preference under the "Patron" tab.
This system preference determines which SMS::Send driver is used to send SMS messages.
I have attempted to take care to not overwrite this system preference if it has already
been set.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 17:03:52 +0000 (12:03 -0500)]
Cleaning up tags display a little bit, adding tablesorter to user tags table.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 17:03:43 +0000 (12:03 -0500)]
Minor markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Thu, 31 Jul 2008 13:58:43 +0000 (08:58 -0500)]
Bug 1953: updating bad unit test for C4::Items::GetItemsForInventory
The tests I wrote for C4::Items::GetItemsForInventory confused the differences
between biblionumber and itemnumber. That wasn't uncovered on my limited test
database, but I uncovered it later.
This fixes that problem by populating a $self->{'items'} list with details of any items
added by KohaTest::add_biblios. Then, tests can probe there for the details of items
they should expect to find when searching.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 13:52:53 +0000 (08:52 -0500)]
Need to pass dateformat pref to the template so tablesorter js knows how to handle sorting date column.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 13:52:44 +0000 (08:52 -0500)]
Display publicationdate if available, else copyrightdate.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 31 Jul 2008 13:43:11 +0000 (08:43 -0500)]
Reorganizing this display for better usability and to fix bug 2290 ("Claims Should not Have Send Button if nothing to claim"). Adding jquery tablesorter. This also adds a message to ask the user to select a supplier if none is selected (see Bug 2338).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Wed, 30 Jul 2008 23:08:02 +0000 (18:08 -0500)]
bug 2423: actually ignore already-imported records
When recommiting a partially completed MARC
record batch, records that were already imported
(or had an error status) were being processed
again, leading to duplicate bibs. Corrected
so that these records are actually ignored.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 30 Jul 2008 17:45:45 +0000 (12:45 -0500)]
Partial fix for Bug 2420 ("OPAC shows broken image for some Google Jackets"). This fix only corrects for undefined img src, not for well-formed but broken img src.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 30 Jul 2008 15:03:06 +0000 (17:03 +0200)]
french updated
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Paul POULAIN [Wed, 30 Jul 2008 15:03:04 +0000 (17:03 +0200)]
french updated
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 30 Jul 2008 14:27:12 +0000 (09:27 -0500)]
Tweak to results display to correct punctuation and add ISBN.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Marc Chantreux [Wed, 30 Jul 2008 11:27:57 +0000 (13:27 +0200)]
C4::Context::import reloaded
the problem was a context was stored every time C4::Context was called.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Darrell Ulm [Mon, 28 Jul 2008 17:05:22 +0000 (13:05 -0400)]
Removing Billing.pl link, will not even slightly work with InnoDB tables as there is no fast count, will work on later
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Wed, 30 Jul 2008 01:23:33 +0000 (20:23 -0500)]
Tag cloud implementation in jquery.
Initial implementation of "cloud" display on opac-tags.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Jul 2008 16:42:50 +0000 (11:42 -0500)]
Bug 1953 [6/6]: adding pod documentation for C4::Koha::displayServers
This method was not documented. I added some POD to it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Jul 2008 16:42:49 +0000 (11:42 -0500)]
Bug 1953 [5/6]: whitespace changes: perltidy.
ran perltidy on the whole method since I've rewritten most of it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Jul 2008 16:42:48 +0000 (11:42 -0500)]
Bug 1953 [4/6]: removing dead code from C4::Koha::displayServers
displayServers appears to have had old code in it that was no longer used. I'm removing it.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Jul 2008 16:42:47 +0000 (11:42 -0500)]
Bug 1953 [3/6]: refactoring to remove superfluous where clause.
refactored the SQL query to remove a confusing and superfluous 'WHERE 1' clause.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Jul 2008 16:42:46 +0000 (11:42 -0500)]
Bug 1953 [2/6]: refactoring SQL in C4::Koha::displayServers to use placeholders.
The SQL call in displayServers was not using placeholders, leaving itself open
to potential SQL injection attacks. I've rewritten it to use placeholders.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Tue, 29 Jul 2008 16:42:45 +0000 (11:42 -0500)]
Bug 1953 [1/6]: adding test module for C4::Koha::displayServers
This test suite tests the several different ways that we can call C4::Koha::displayServers.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Galen Charlton [Mon, 28 Jul 2008 21:05:42 +0000 (16:05 -0500)]
bug 2413: remove noOPACHolds syspref (DB rev 104)
Preference was removed in patch for bug 2234; completing
removal in existing 3.0 installations via DB rev 104.
No documentation changes (deprecation of noOPACHolds
done in an earlier patch)
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Mon, 28 Jul 2008 16:35:46 +0000 (11:35 -0500)]
kohabug 2404 This patch removes Image::Magick and adds GD
This patch removes Image::Magick as a dependency and replaces it with
the (much) lighter GD. Functionality of patronimage code has not changed with
this conversion.
Adding errorhandling for corrupted image file and link to return to moremember.pl when called from there
Added notes about supported image mime types.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 28 Jul 2008 13:15:45 +0000 (08:15 -0500)]
A couple more corrections that should have been in previous commit.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Mon, 28 Jul 2008 12:50:14 +0000 (07:50 -0500)]
Fix for Bug 2408 ("Note: separated from content in cgi-bin/koha/serials/subscription-add.pl") and other markup corrections.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Nicole Engard [Thu, 24 Jul 2008 15:53:22 +0000 (11:53 -0400)]
Update to help file
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
root [Fri, 25 Jul 2008 14:39:36 +0000 (10:39 -0400)]
Small patch again to fix repeated col in reserveratios.tmpl
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Henri-Damien LAURENT [Fri, 4 Jul 2008 06:20:50 +0000 (08:20 +0200)]
Bug fixing : the link between serial and item wasnot used when editing an issue
table serialitems was not used when getting serialinformation.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 25 Jul 2008 20:31:11 +0000 (15:31 -0500)]
Bug 1953: refactoring C4::Koha::get_itemtypeinfos_of to eliminate potential SQL injection
C4::Koha::get_itemtypeinfos_of was not using plceholders, opening itself up to
potential SQL injection attacks. This patch refactors it to use placeholders to
bind parameters.
I also had to extend C4::koha::get_infos_of to allow us to pass bind parameters into it.
I'm including a test module for C4::Koha::get_itemtypeinfos_of.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Jesse Weaver [Fri, 25 Jul 2008 17:32:05 +0000 (12:32 -0500)]
kohabug 2345: bad comparisons pervade reports
This patch changes all $foo eq undef's to !defined($foo). It also makes misc/spellcheck_suggest/build_spellcheck_suggest.pl have proper syntax.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 25 Jul 2008 16:55:13 +0000 (11:55 -0500)]
Bug 1953 [3/3]: documentation changes for C4::items::GetItemsForInventory
This patch corrects what appears to me to be a few defficiencies in the documentation
for C4::items::GetItemsForInventory. I noticed them while writing test methods for this sub.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 25 Jul 2008 16:55:12 +0000 (11:55 -0500)]
Bug 1953 [2/3]: refactoring SQL in C4::Items::GetItemsForInventory to use placeholders
The SQL in C4::Items::GetItemsForInventory wasn't using placeholders and
bind parameters, possibly leaving itself open ot SQL injection attacks. This
patch changes that.
I've also incliuded a test module for C4::items::GetItemsForInventory.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Andrew Moore [Fri, 25 Jul 2008 16:55:11 +0000 (11:55 -0500)]
Bug 1953 [1/3]: test suite improvements
Here are a few improvments to the test suite to make it easier to write some tests
for C4::Items
I extracted "tomorrow" and "yesterday" methods from a test module into the base class
so that they could be used by multiple test modules
Adding callnumber to items added in the test suite.
I recatored KohaTest::add_biblios a bit to remove the manual count of the number of
MARC::Fields that were added.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Jesse Weaver [Fri, 25 Jul 2008 16:51:34 +0000 (11:51 -0500)]
kohabug 2379 When a borrower is added manually in Koha...
This checks that the enrolmentfee for a category both exists, and is greater than 0, avoiding a spurious charge.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Fri, 25 Jul 2008 15:37:51 +0000 (10:37 -0500)]
kohabug 2224 Third installment: Further corrections for NULL fields
This patch adds code to clean out any NULL fields in rows returned
since NULL fields do not truly meet the filter criteria
It also corrects a bad db field reference.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Fri, 25 Jul 2008 15:37:49 +0000 (10:37 -0500)]
kohabug 2390 Setting default fund for new orders
If a new order was created and no fund selected, a db error was thrown due to the
'bookfundid' field being set to NULL. This patch sets the first fund retrieved from
available funds as the default selection in the scrolling list.
A further enhancement might be to allow the library to choose which fund is the
default fund.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Fri, 25 Jul 2008 15:37:50 +0000 (10:37 -0500)]
kohabug 2219 Corrects inconsistent use of subscription.serialsadditems column
From the bug report:
The serialsadditems syspref was ostensibly removed in DB rev 071
(http://git.koha.org/cgi-bin/gitweb.cgi?p=Koha;a=commit;h=
5c41ae54e68866f9661e853376537059f4d83f70)
in favor of a new serialsadditems column in the subscription table.
However, this removal was incomplete. It is still created for new installations by:
installer/data/mysql/en/mandatory/sysprefs.sql
installer/data/mysql/fr-FR/1-Obligatoire/unimarc_standard_systemprefs.sql
and is used in
serials/serials-recieve.pl
serials/serials-edit.pl
admin/systempreferences.pl
Since the system preference was not removed from the sample data scripts, it
is necessary to add another DB rev to remove it - a user may have made a
fresh install of Koha after DB rev 071.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Fri, 25 Jul 2008 15:44:30 +0000 (10:44 -0500)]
kohabug 2380 Correcting serialitems table structure and fixing duplicate barcode check
The current serialitems table structure does not provide for a *:1 relationship with
the serial table. This causes a problem when attempting to add multiple items to a given
serial. The db throws an error when attempting to INSERT in serialitems due to serialid.serialitems
being a unique key. A further side effect is that the marc record is updated with the
item inspite of the error. The mods to the serialitems table structure in this patch
drop serialid.serialitems as a key and make itemnumber.serialitems the primary key
creating a *:1 relationship with the serial table. This patch also makes serialid.serialitems
a foreign key referencing serialid.serial to maintain referential integrity.
Fix for duplicate barcode check
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Fri, 25 Jul 2008 14:35:44 +0000 (09:35 -0500)]
Populate items.cn_source in acq receive. However, items.cn_sort is not calculated. See bug 2403.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Ryan Higgins [Fri, 25 Jul 2008 14:04:07 +0000 (09:04 -0500)]
BUG 2351 : Add duplicate barcode check prior to receiving multiple items. This patch adds a javascript form check for duplicates in-form, and returns an error if there are duplicates in the catalog.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 24 Jul 2008 21:11:18 +0000 (16:11 -0500)]
Example cronjob file.
We have 5 or 6 different cron'd tasks for a single installation now,
so an example is in order.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joe Atzberger [Thu, 24 Jul 2008 21:11:17 +0000 (16:11 -0500)]
TZ - multiple timezone support
Support multiple timezones via Apache SetEnv. See the perldoc for
admin/env_tz_test.pl on how to configure and test. Minimal changes
to Context itself.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Wed, 23 Jul 2008 13:28:49 +0000 (08:28 -0500)]
Spelling corrections (Fixes Bug 2381).
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 25 Jul 2008 16:32:06 +0000 (11:32 -0500)]
This patch fixes the OPAC view and holdability of items:
1. restores a check to itemtype.notforloan to set the norequests flag
2. changes improper boolean OR with AND for checking conditions of setting norequests
3. displays 'Not for loan' for item-level itypes when the itemtype is set to notforloan
4. restores items.notforloan values < 0 allowing holds (ordered items for instance)
We still need a notforhold flag set at the itemtype, and items level
Joshua Ferraro [Fri, 25 Jul 2008 15:08:31 +0000 (10:08 -0500)]
If the authorized value description doesn't exist, display the value
Ryan Higgins [Fri, 25 Jul 2008 07:58:01 +0000 (02:58 -0500)]
Update CalcFine to obey maxFine systempreference.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Thu, 24 Jul 2008 23:24:41 +0000 (18:24 -0500)]
kohabug 2154 Modifying form input controls to accomodate translations
Due to the logic of the underlying picture-upload.pl depending upon the "value" of the
form input controls and this value being translated, the script then failed to function.
This patch changes the input controls so that this should not be an issue.
This issue should be kept in mind, though, so that it can be avoided in the future.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Joshua Ferraro [Fri, 25 Jul 2008 13:49:45 +0000 (08:49 -0500)]
Fix 'Catalog by Itemtype' report to work with item-level itypes
Joshua Ferraro [Thu, 24 Jul 2008 21:23:33 +0000 (16:23 -0500)]
Fix for bug 2398: Source of Classification - Add item or Edit item in
staff client is defaulting to the ASNCR code instead of the blank above
For some reason the loop used to build the list of values was
setting the first value to the $value variable if $value wasn't
set already, and the default_value was inside rather than outside
the loop. I've removed the setting inside the loop and placed
the default value outide the loop. It's possible I just don't
understand what the original intention was.
Chris Nighswonger [Thu, 24 Jul 2008 19:14:41 +0000 (14:14 -0500)]
kohabug 2224 Second installment: Correcting NULL field display
Query references to the unused aqorderdelivery table caused a NULL field to be
displayed in the report results. This patch removes those references.
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Jul 2008 18:52:30 +0000 (13:52 -0500)]
Adding a couple of IDs to the markup to enable more flexibility in custom styling.
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Owen Leonard [Thu, 24 Jul 2008 18:48:23 +0000 (13:48 -0500)]
Styling tabs on virtual shelves page. Did I forget this, or did it get removed at some point?
Signed-off-by: Joshua Ferraro <jmf@liblime.com>
Chris Nighswonger [Thu, 24 Jul 2008 18:44:19 +0000 (13:44 -0500)]
kohabug 2139 Fixes C4::Aquisition::NewOrder so that it saves the branchcode
&NewOrder did not save the branchcode posted with a new order. This patch adds that param.
Added code to select the branch the order is for in the branch dropdown list on
acqui/orderreceive.pl
Updating POD and tests
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>