From: Chris Cormack <chrisc@catalyst.net.nz>
Date: Tue, 2 Dec 2014 01:16:40 +0000 (+1300)
Subject: Bug 13368 Holds priority messed up on checkout
X-Git-Tag: v3.20.00-beta~917
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=ef6bc21b2c4ebe04f6d22d081e447f6bb2955029;p=srvgit

Bug 13368 Holds priority messed up on checkout

To Test

1/ Create 3 (or more holds) on one biblionumber, make sure at least
one item is not on loan
2/ Check out the not on loan item to a borrower (maybe number 2 in the
queue)
3/ Look in the database (or on the holds tab on the moredetail.pl)
notice the priorities have not been reordered
4/ Apply patch and try again, notice now they have

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Confirmed the problem without the patch, and confirmed that the patch
corrects it.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
---

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index 5058c51ebb..22a9ecb438 100644
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -1309,7 +1309,7 @@ sub ModReserveFill {
     # now fix the priority on the others (if the priority wasn't
     # already sorted!)....
     unless ( $priority == 0 ) {
-        _FixPriority({ reserve_id => $reserve_id });
+        _FixPriority({ reserve_id => $reserve_id, biblionumber => $biblionumber });
     }
 }