From: Kyle M Hall Date: Wed, 19 Feb 2014 20:26:24 +0000 (-0500) Subject: Bug 11796: fix display of search result facets if facet happens to have exactly six... X-Git-Tag: v3.16.00-beta~728 X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=e7286e05137276f0a916f06d60a13c22c93294b2;p=koha_fer Bug 11796: fix display of search result facets if facet happens to have exactly six entries If a search gives results with 6 facets, one of those facets won't be displayed. This is due to a bug in the code that only considers great than 6 facets in one area, and less than 6 in another. Test Plan: 1) Perform a search that should give results for 6 different libraries 2) Note you only see 5 libraries in the facets with no option to expand 3) Apply this patch 4) Repeat step 1 5) Note you now have the option to expand the facets list Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart This patch should provide a regression test but I really don't know how to write it. Signed-off-by: Galen Charlton --- diff --git a/C4/Search.pm b/C4/Search.pm index 4e876786a4..6a705d92b1 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -567,7 +567,7 @@ sub getRecords { ) { $number_of_facets++; - if ( ( $number_of_facets < 6 ) + if ( ( $number_of_facets <= 5 ) || ( $expanded_facet eq $link_value ) || ( $facets_info->{$link_value}->{'expanded'} ) ) @@ -644,7 +644,7 @@ sub getRecords { # handle expanded option unless ( $facets_info->{$link_value}->{'expanded'} ) { $expandable = 1 - if ( ( $number_of_facets > 6 ) + if ( ( $number_of_facets > 5 ) && ( $expanded_facet ne $link_value ) ); } push @facets_loop,