From: Colin Campbell <colin.campbell@ptfs-europe.com>
Date: Thu, 24 Oct 2013 16:00:23 +0000 (+0100)
Subject: Bug 11135: avoid logging warnings if OVERRIDE_SYSPREF_NAME is not set
X-Git-Tag: v3.14.00-beta~86
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=ded0db9d63c256ac544873e70eb437afd237a32f;p=srvgit

Bug 11135: avoid logging warnings if OVERRIDE_SYSPREF_NAME is not set

Calling split on an undefined var generates warning to
the log. Let's check it exists before processing it

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---

diff --git a/admin/preferences.pl b/admin/preferences.pl
index 8636afe93e..9a2c8ca327 100755
--- a/admin/preferences.pl
+++ b/admin/preferences.pl
@@ -121,7 +121,10 @@ sub TransformPrefsToHTML {
     my $tab = $data->{ $title };
     $tab = { '' => $tab } if ( ref( $tab ) eq 'ARRAY' );
 
-    my @override_syspref_names = split( /,/, $ENV{"OVERRIDE_SYSPREF_NAMES"} );
+    my @override_syspref_names;
+    if ( $ENV{OVERRIDE_SYSPREF_NAMES} ) {
+        @override_syspref_names = split /,/, $ENV{OVERRIDE_SYSPREF_NAMES};
+    }
 
     foreach my $group ( sort keys %$tab ) {
         if ( $group ) {