From: Colin Campbell <colin.campbell@ptfs-europe.com>
Date: Thu, 4 Jul 2013 11:21:45 +0000 (+0100)
Subject: Bug 10529: Remove hardcoded dollar from patron message
X-Git-Tag: v3.14.00-alpha1~535
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=ced4ca4e2d39856b4f00411eaee406b569199c1f;p=koha_fer

Bug 10529: Remove hardcoded dollar from patron message

The message fields which are returned in the SIP
Screen message field in a Patron Information response
had the dollar symbol hardcoded.

It would be possible to get the symbol from currency
but omitting any symbol would be consistent with the UI
and avoid problems with devices using weird encodings
for local currency symbols (e.g. the many variations
of UK Pound sign)

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---

diff --git a/C4/Members.pm b/C4/Members.pm
index 3221f5333a..6d8d23ae7d 100644
--- a/C4/Members.pm
+++ b/C4/Members.pm
@@ -435,7 +435,7 @@ sub patronflags {
     if ( $owing > 0 ) {
         my %flaginfo;
         my $noissuescharge = C4::Context->preference("noissuescharge") || 5;
-        $flaginfo{'message'} = sprintf "Patron owes \$%.02f", $owing;
+        $flaginfo{'message'} = sprintf 'Patron owes %.02f', $owing;
         $flaginfo{'amount'}  = sprintf "%.02f", $owing;
         if ( $owing > $noissuescharge && !C4::Context->preference("AllowFineOverride") ) {
             $flaginfo{'noissues'} = 1;
@@ -444,7 +444,7 @@ sub patronflags {
     }
     elsif ( $balance < 0 ) {
         my %flaginfo;
-        $flaginfo{'message'} = sprintf "Patron has credit of \$%.02f", -$balance;
+        $flaginfo{'message'} = sprintf 'Patron has credit of %.02f', -$balance;
         $flaginfo{'amount'}  = sprintf "%.02f", $balance;
         $flags{'CREDITS'} = \%flaginfo;
     }