From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 10 Apr 2014 19:50:40 +0000 (-0400)
Subject: Bug 12069: redirect to staff login if you access members/mod_debarment.pl when logged out
X-Git-Tag: v3.16.00-beta~477
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=cbcfb847e0022f79b82f0601c955ae085917d377;p=koha_fer

Bug 12069: redirect to staff login if you access members/mod_debarment.pl when logged out

members/mod_debarment.pl's call to checkauth should pass 'intranet' so
that if the user happens to be logged out they will be redirected to the
staff client login form, rather than the OPAC.

To test, apply the patch and log in to the staff client:

- Add a restriction to a patron's account.
- View the restrictions tab on the patron's account. You should see the
  restriction and a "Remove" link for that restriction.
- In another tab, log out of the staff client.
- In the first tab, click the "Remove" link. You should be redirected to
  the staff client login page.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Good catch! Works as described, passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
---

diff --git a/members/mod_debarment.pl b/members/mod_debarment.pl
index 3797825769..592e1347ef 100755
--- a/members/mod_debarment.pl
+++ b/members/mod_debarment.pl
@@ -27,7 +27,7 @@ use Koha::Borrower::Debarments;
 
 my $cgi = new CGI;
 
-my ( $loggedinuser, $cookie, $sessionID ) = checkauth( $cgi, 0, { borrowers => 1 } );
+my ( $loggedinuser, $cookie, $sessionID ) = checkauth( $cgi, 0, { borrowers => 1 }, 'intranet' );
 
 my $borrowernumber = $cgi->param('borrowernumber');
 my $action         = $cgi->param('action');