From: Galen Charlton <galen.charlton@liblime.com>
Date: Fri, 8 May 2009 13:44:03 +0000 (-0500)
Subject: bug 2287: handle case where autoMemberNum is off
X-Git-Tag: new_acq_a_porter~137
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=80eecc3f198315c0f1b63eccb799d753add2e95d;p=koha_ffzg

bug 2287: handle case where autoMemberNum is off

When importing a patron file where new records
do not have a card number *and* autoMemberNum is
off, make sure that bororwers.cardnumber is set to NULL
for those new patrons rather than '' - otherwise, only
one patron with an empty barcode can be created, as there is
a uniqueness constraint on borrowers.cardnumber

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
---

diff --git a/tools/import_borrowers.pl b/tools/import_borrowers.pl
index 9ac994bc75..9738f19dc3 100755
--- a/tools/import_borrowers.pl
+++ b/tools/import_borrowers.pl
@@ -252,7 +252,7 @@ if ( $uploadborrowers && length($uploadborrowers) > 0 ) {
             # FIXME: fixup_cardnumber says to lock table, but the web interface doesn't so this doesn't either.
             # At least this is closer to AddMember than in members/memberentry.pl
             if (!$borrower{'cardnumber'}) {
-                $borrower{'cardnumber'} = fixup_cardnumber('');
+                $borrower{'cardnumber'} = fixup_cardnumber(undef);
             }
             if ($borrowernumber = AddMember(%borrower)) {
                 if ($extended) {