From: Colin Campbell <colin.campbell@ptfs-europe.com>
Date: Tue, 7 Jun 2011 13:34:18 +0000 (+0100)
Subject: Bug 2505 : use warnings in smart_rules.pl
X-Git-Tag: v3.08.00~83
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=6078c1acf699f51c127e853203e35cadae99005d;p=koha_fer

Bug 2505 : use warnings in smart_rules.pl

Fix some careless code redeclaring a variable
declaring a variable in a condition
so that these don't generate errors

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
---

diff --git a/admin/smart-rules.pl b/admin/smart-rules.pl
index 0b8012fabc..8e5a2d5802 100755
--- a/admin/smart-rules.pl
+++ b/admin/smart-rules.pl
@@ -18,7 +18,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 use strict;
-#use warnings; FIXME - Bug 2505
+use warnings;
 use CGI;
 use C4::Context;
 use C4::Output;
@@ -28,7 +28,7 @@ use C4::Debug;
 use C4::Branch; # GetBranches
 use C4::Dates qw/format_date format_date_in_iso/;
 
-my $input = new CGI;
+my $input = CGI->new;
 my $dbh = C4::Context->dbh;
 
 # my $flagsrequired;