From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Mon, 9 Jun 2014 15:35:15 +0000 (+0200)
Subject: Bug 9811: Remove useless orderby management
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=2b8b5ae225af6119e41e2112f9a8573b4170b927;p=koha_fer

Bug 9811: Remove useless orderby management

I don't know what is this stuff. I didn't find a call to member.pl with
an orderby parameter.
I am not sure this is in used.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
---

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
index ae7f06f9f5..0d814485a3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
@@ -205,10 +205,10 @@ $(document).ready(function() {
         },
         'bFilter': false,
         'bAutoWidth': false,
-        [% IF orderby_cardnumber_0 %]
-            'aaSorting': [[0, 'asc']],
-        [% ELSE %]
+        [% IF CAN_user_tools_manage_patron_lists %]
             'aaSorting': [[1, 'asc']],
+        [% ELSE %]
+            'aaSorting': [[0, 'asc']],
         [% END %]
         "aLengthMenu": [aLengthMenu, aLengthMenuLabel],
         'sPaginationType': 'full_numbers',
diff --git a/members/member.pl b/members/member.pl
index 9cefc79f58..cd80577b86 100755
--- a/members/member.pl
+++ b/members/member.pl
@@ -108,11 +108,6 @@ if ( $patron->{categorycode} ) {
 
 $template->param( 'alphabet' => C4::Context->preference('alphabet') || join ' ', 'A' .. 'Z' );
 
-my $orderby = $input->param('orderby') // '';
-if(defined $orderby and $orderby ne '') {
-    $orderby =~ s/[, ]/_/g;
-}
-
 my $view = $input->request_method() eq "GET" ? "show_form" : "show_results";
 
 $template->param(
@@ -124,7 +119,6 @@ $template->param(
     categorycode        => $patron->{categorycode},
     searchtype          => $input->param('searchtype') || 'start_with',
     searchfieldstype    => $searchfieldstype,
-    "orderby_$orderby"  => 1,
     PatronsPerPage      => C4::Context->preference("PatronsPerPage") || 20,
     view                => $view,
 );