From: Chris Cormack <chrisc@catalyst.net.nz>
Date: Mon, 17 Jan 2011 09:53:28 +0000 (+1300)
Subject: Bug 5399: Follow up style patch, moving exits out of subroutine
X-Git-Tag: html_template_pro~481
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=12741cfafa7513ee7b4627863c18346cb8507873;hp=4532ca70bc5842667c6ff53d9fec5d7e7b4f4317;p=koha_gimpoz

Bug 5399: Follow up style patch, moving exits out of subroutine
---

diff --git a/acqui/basketgroup.pl b/acqui/basketgroup.pl
index 0d5bcd585a..2a35f3a264 100755
--- a/acqui/basketgroup.pl
+++ b/acqui/basketgroup.pl
@@ -4,6 +4,7 @@
 #written by john.soros@biblibre.com 01/10/2008
 
 # Copyright 2008 - 2009 BibLibre SARL
+# Parts Copyright Catalyst 2010
 #
 # This file is part of Koha.
 #
@@ -245,7 +246,6 @@ sub printbasketgrouppdf{
     );
     my $pdf = printpdf($basketgroup, $bookseller, $baskets, \%orders, $bookseller->{gstrate} // C4::Context->preference("gist")) || die "pdf generation failed";
     print $pdf;
-    exit; # FIXME bad form to exit out of a subroutine like this
 }
 
 my $op = $input->param('op');
@@ -383,10 +383,12 @@ if ( $op eq "add" ) {
     CloseBasketgroup($basketgroupid);
     
     printbasketgrouppdf($basketgroupid);
+    exit;
 }elsif ($op eq 'print'){
     my $basketgroupid = $input->param('basketgroupid');
     
     printbasketgrouppdf($basketgroupid);
+    exit;
 }elsif( $op eq "delete"){
     my $basketgroupid = $input->param('basketgroupid');
     DelBasketgroup($basketgroupid);