From: Indranil Das Gupta <indradg@gmail.com>
Date: Fri, 3 Jul 2015 08:03:06 +0000 (+0530)
Subject: Bug 14487: silence warns during checkin
X-Git-Tag: v3.22.00-beta~847
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;h=0d632a606f499c31afb8a08f81625c4dfbddb445;p=koha-ffzg.git

Bug 14487: silence warns during checkin

Test plan
=========

1/ check out an item and then check it back in.
1/ check the logs after the check-in to see the warns from
   returns.pl line 623 of :
    (a) Use of uninitialized value $holdingBranch
    (b) Use of uninitialized value $collectionBranch
2/ apply patch
3/ check out and check-in again. no warns are recorded this time.

NOTE: Under Debian Jessie, there are other messages.
      Additionally, this only corrects the line 623 ones.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Nick Clemens <nick@quecheelibrary.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
---

diff --git a/circ/returns.pl b/circ/returns.pl
index c36318fba4..91a6857822 100755
--- a/circ/returns.pl
+++ b/circ/returns.pl
@@ -620,6 +620,8 @@ $template->param(
 $itemnumber = GetItemnumberFromBarcode( $query->param('barcode') );
 if ( $itemnumber ) {
    my ( $holdingBranch, $collectionBranch ) = GetCollectionItemBranches( $itemnumber );
+    $holdingBranch //= '';
+    $collectionBranch //= '';
     if ( ! ( $holdingBranch eq $collectionBranch ) ) {
         $template->param(
           collectionItemNeedsTransferred => 1,