From: Tomas Cohen Arazi <tomascohen@gmail.com>
Date: Tue, 26 May 2015 17:16:41 +0000 (-0300)
Subject: Revert "Bug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm"
X-Git-Tag: v3.22.00-beta~1164
X-Git-Url: http://koha-dev.rot13.org:8081/gitweb/?a=commitdiff_plain;ds=sidebyside;h=e52e9fb7a205bd96750e0b48544c516fdb0deebf;p=srvgit

Revert "Bug 6679: Fix 2 perlcritic violations in C4/Installer/PerlModules.pm"

This reverts commit 7fbc7467b53784b41e1ef2db7a95ed69235c9c5e.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
---

diff --git a/C4/Installer/PerlModules.pm b/C4/Installer/PerlModules.pm
index 655db74b34..2f40cf559f 100644
--- a/C4/Installer/PerlModules.pm
+++ b/C4/Installer/PerlModules.pm
@@ -68,7 +68,7 @@ sub version_info {
     my %params = @_;
     if ($params{'module'}) {
         return -1 unless grep {m/$params{'module'}/} keys(%$PERL_DEPS);
-        eval {require $params{'module'}};
+        eval "require $params{'module'}";
         if ($@) {
             return {$params{'module'} => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, upgrade => 0, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}};
         }
@@ -82,7 +82,7 @@ sub version_info {
     else {
         for (sort keys(%{$PERL_DEPS})) {
             my $pkg = $_;  #  $_ holds the string
-            eval {require $pkg};
+            eval "require $pkg";
             if ($@) {
                 push (@{$self->{'missing_pm'}}, {$_ => {cur_ver => 0, min_ver => $PERL_DEPS->{$_}->{'min_ver'}, required => $PERL_DEPS->{$_}->{'required'}, usage => $PERL_DEPS->{$_}->{'usage'}}});
             }