Bug 16004: [QA Follow-up] Tiny change for unit test and help file

Unit test: Added a few lines to add the CPL branch the test depends on.
Help file: Changed a few occurrences for new to new_status

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt
index ef4f6d7..fc5ab9d 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/help/tools/automatic_item_modification_by_age.tt
@@ -3,11 +3,11 @@
 
 <p>This configuration page allows to configure the rules for the automatic item modifications by age cronjob script.</p>
 
-<p>Libraries can manage the 'new' status for items. With this script, it will be possible to:<p>
+<p>Libraries can manage the 'new_status' field for items. With this script, it will be possible to:<p>
 <ul>
   <li>know easily what are the new items in the catalogue.</li>
   <li>display an icon in the search results for new items.</li>
-  <li>configure circulation and fine rules depending the 'new' status.</li>
+  <li>configure circulation and fine rules depending the 'new_status' field.</li>
   <li>get a RSS/Atom feeds on these new items.</li>
 </ul>
 
@@ -23,11 +23,11 @@
 <p>At least one substitution must be defined, else there is no sense to launch the script.</p>
 <p>If the value is an empty string, the field will be deleted.</p>
 <h3>Examples</h3>
-<p>You want to remove the items.new value for items created 10 days ago:</p>
+<p>You want to remove the items.new_status value for items created 10 days ago:</p>
 <ul>
   <li>Duration: 10 days</li>
   <li>No condition</li>
-  <li>Substitution: items.new = '' (no value in the input)</li>
+  <li>Substitution: items.new_status = '' (no value in the input)</li>
 </ul>
 
 <p>You want to change the items.ccode=1 to items.ccode=2 for items created 7 days ago.

diff --git a/t/db_dependent/Items/AutomaticItemModificationByAge.t b/t/db_dependent/Items/AutomaticItemModificationByAge.t
index 0bad51a..6d7abe2 100644 (file)
--- a/t/db_dependent/Items/AutomaticItemModificationByAge.t
+++ b/t/db_dependent/Items/AutomaticItemModificationByAge.t
@@ -11,11 +11,18 @@ use C4::Biblio;
 use C4::Context;
 use C4::Items;
 use Koha::DateUtils;
+use t::lib::TestBuilder;
 
 my $dbh = C4::Context->dbh;
 $dbh->{AutoCommit} = 0;
 $dbh->{RaiseError} = 1;
 
+# this test assumes a CPL branch
+my $builder = t::lib::TestBuilder->new;
+if( !$builder->schema->resultset('Branch')->find('CPL') ) {
+    $builder->build( { source => 'Branch', value => { branchcode => 'CPL' }});
+}
+
 $dbh->do(q|
     DELETE FROM marc_subfield_structure
     WHERE kohafield = 'items.new_status' OR kohafield = 'items.stocknumber'