bug 2171: removed "Transfers to do" report
authorGalen Charlton <galen.charlton@liblime.com>
Thu, 3 Jul 2008 21:27:12 +0000 (16:27 -0500)
committerJoshua Ferraro <jmf@liblime.com>
Fri, 4 Jul 2008 14:22:16 +0000 (09:22 -0500)
This hold request and transfer report no longer
works now that hold requests are processed via
checking items in.

This patch removes the report; please consult
the koha-devel message re "RFC - remove circ/transferstodo.pl prior to general release"
for more details.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>
circ/transferstodo.pl [deleted file]
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation-home.tmpl
koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl [deleted file]
koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl [deleted file]

diff --git a/circ/transferstodo.pl b/circ/transferstodo.pl
deleted file mode 100755 (executable)
index 1837e33..0000000
+++ /dev/null
@@ -1,135 +0,0 @@
-#!/usr/bin/perl
-
-
-# Copyright 2000-2002 Katipo Communications
-#
-# This file is part of Koha.
-#
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
-#
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
-
-use strict;
-use C4::Context;
-use C4::Output;
-use CGI;
-use C4::Branch; # GetBranches
-use C4::Auth;
-use C4::Dates qw/format_date/;
-use C4::Circulation;
-use C4::Reserves;
-use C4::Members;
-use Date::Calc qw(
-  Today
-  Add_Delta_Days
-  Date_to_Days
-);
-use C4::Koha;
-use C4::Biblio;
-use C4::Items;
-
-my $input = new CGI;
-
-my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
-    {
-        template_name   => "circ/transferstodo.tmpl",
-        query           => $input,
-        type            => "intranet",
-        authnotrequired => 0,
-        flagsrequired   => { circulate => 1 },
-        debug           => 1,
-    }
-);
-
-# set the userenv branch
-my $default = C4::Context->userenv->{'branch'};
-
-my $item = $input->param('itemnumber');
-my $fbr  = $input->param('fbr');
-my $tbr  = $input->param('tbr');
-
-# If we have a return of the form dotransfer, we launch the subroutine dotransfer
-if ($item) {
-    C4::Circulation::Circ2::ModItemTransfer( $item, $fbr, $tbr );
-}
-
-# get the all the branches for reference
-my $branches = GetBranches();
-
-my @branchesloop;
-foreach my $br ( keys %$branches ) {
-    my @reservloop;
-    my %branchloop;
-    my @getreserves =
-      GetReservesToBranch( $branches->{$br}->{'branchcode'} );
-    if (@getreserves) {
-        $branchloop{'branchname'} = $branches->{$br}->{'branchname'};
-        $branchloop{'branchcode'} = $branches->{$br}->{'branchcode'};
-        foreach my $num (@getreserves) {
-            my %getreserv;
-            my $gettitle     = GetBiblioFromItemNumber( $num->{'itemnumber'} );
-#             use Data::Dumper;
-#             warn Dumper($gettitle);
-            my $itemtypeinfo = getitemtypeinfo( $gettitle->{'itemtype'} );
-            if ( $gettitle->{'holdingbranch'} eq $default ) {
-                my $getborrower =
-                  GetMemberDetails( $num->{'borrowernumber'} );
-                $getreserv{'reservedate'} =
-                  format_date( $num->{'reservedate'} );
-                my ( $reserve_year, $reserve_month, $reserve_day ) = split /-/,
-                  $num->{'reservedate'};
-                ( $reserve_year, $reserve_month, $reserve_day ) =
-                  Add_Delta_Days( $reserve_year, $reserve_month, $reserve_day,
-                    C4::Context->preference('ReservesMaxPickUpDelay'));
-                my $calcDate =
-                  Date_to_Days( $reserve_year, $reserve_month, $reserve_day );
-                my $today   = Date_to_Days(&Today);
-                my $warning = ( $today > $calcDate );
-
-                if ( $warning > 0 ) {
-                    $getreserv{'messcompa'} = 1;
-                }
-                $getreserv{'title'}          = $gettitle->{'title'};
-                $getreserv{'biblionumber'}   = $gettitle->{'biblionumber'};
-                $getreserv{'itemnumber'}     = $gettitle->{'itemnumber'};
-                $getreserv{'barcode'}        = $gettitle->{'barcode'};
-                $getreserv{'itemtype'}       = $itemtypeinfo->{'description'};
-                $getreserv{'holdingbranch'}  = $gettitle->{'holdingbranch'};
-                $getreserv{'itemcallnumber'} = $gettitle->{'itemcallnumber'};
-                $getreserv{'borrowernum'}    = $getborrower->{'borrowernumber'};
-                $getreserv{'borrowername'}   = $getborrower->{'surname'};
-                $getreserv{'borrowerfirstname'} = $getborrower->{'firstname'};
-                $getreserv{'borrowermail'} = $getborrower->{'emailaddress'};
-                $getreserv{'borrowerphone'} = $getborrower->{'phone'};
-                push( @reservloop, \%getreserv );
-            }
-        }
-
-      #                If we have a return of reservloop we put it in the branchloop sequence
-        if (@reservloop) {
-            $branchloop{'reserv'} = \@reservloop;
-        }
-        #              else, we unset the value of the branchcode .
-        else {
-            $branchloop{'branchcode'} = 0;
-        }
-    }
-    push( @branchesloop, \%branchloop ) if %branchloop;
-}
-
-$template->param(
-    branchesloop => \@branchesloop,
-    show_date    => format_date(C4::Dates->today('iso')),
-       dateformat    => C4::Context->preference("dateformat"),
-);
-
-output_html_with_http_headers $input, $cookie, $template->output;
index a2e33aa..7f62cb8 100644 (file)
@@ -32,7 +32,6 @@
        <li>    <a href="/cgi-bin/koha/circ/pendingreserves.pl" title="holds to retrieve off the shelf">Holds to pull</a></li>
        <li>    <a href="/cgi-bin/koha/circ/waitingreserves.pl" title="holds waiting for patron pickup">Holds awaiting pickup</a></li>
        <li>    <a href="/cgi-bin/koha/circ/reserveratios.pl">Hold ratios</a></li>
-       <li>    <a href="/cgi-bin/koha/circ/transferstodo.pl" title="transfers to do from your library">Transfers to do</a></li>
        <li>    <a href="/cgi-bin/koha/circ/transferstoreceive.pl" title="transfers to receive at your library">Transfers to receive</a></li>
        <li>    <a href="/cgi-bin/koha/circ/overdue.pl">Overdues</a></li>
        <li>    <a href="/cgi-bin/koha/circ/branchoverdues.pl">Overdue fines</a></li>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/transferstodo.tmpl
deleted file mode 100644 (file)
index be6db2b..0000000
+++ /dev/null
@@ -1,92 +0,0 @@
-<!-- TMPL_INCLUDE NAME="doc-head-open.inc" -->
-<title>Koha &rsaquo; Circulation &rsaquo; Transfers to do</title>
-<!-- TMPL_INCLUDE NAME="doc-head-close.inc" -->
-<script type="text/javascript" src="<!-- TMPL_VAR name="themelang" -->/lib/jquery/plugins/jquery.tablesorter.min.js"></script>
-<script type="text/JavaScript" language="JavaScript">
-//<![CDATA[
-$.tablesorter.addParser({
-    id: 'articles', 
-    is: function(s) {return false;  }, 
-    format: function(s) { return s.toLowerCase().replace(/^(the|an|a) /,''); }, 
-    type: 'text' 
-});
-        $(document).ready(function() {
-        <!-- TMPL_LOOP NAME="branchesloop" -->
-               $.tablesorter.defaults.widgets = ['zebra']; 
-               $("#transferst<!-- TMPL_VAR NAME="branchcode" -->").tablesorter({<!-- TMPL_IF EXPR="dateformat eq 'metric'" -->
-               dateFormat: 'uk',<!-- /TMPL_IF -->
-                       sortList: [[1,0]],
-                       headers: { 1: { sorter: 'articles' },4:{sorter:false}}
-               }); 
-       <!-- /TMPL_LOOP -->
-        });
-//]]>
-</script>
-</head>
-<body>
-<!-- TMPL_INCLUDE NAME="header.inc" -->
-<!-- TMPL_INCLUDE NAME="circ-search.inc" -->
-
-<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> &rsaquo; <a href="/cgi-bin/koha/circ/circulation-home.pl">Circulation</a> &rsaquo; Transfers to do</div>
-
-<div id="doc" class="yui-t7">
-   
-   <div id="bd">
-       <div id="yui-main">
-       <div class="yui-g">
-
-
-    <h1>Transfers to do, <!-- TMPL_VAR NAME="show_date" --></h1>
-    <!-- TMPL_IF name="branchesloop" -->
-    <div id="resultlist">
-        <!-- TMPL_LOOP NAME="branchesloop" -->
-            <!-- TMPL_IF NAME="branchcode" -->
-                       <h4>Holds waiting for: <!-- TMPL_VAR NAME="branchname" --></h4>
-            <table id="transferst<!-- TMPL_VAR NAME="branchcode" -->" style="width:100%;">
-            <thead><tr>
-                <th>Date of hold</th>
-                <th>Title</th>
-                <th>Patron</th>
-                <th>Localisation</th>
-                <th>Action</th>
-            </tr></thead>
-            <tbody><!-- TMPL_LOOP NAME="reserv" -->
-                <!-- TMPL_IF NAME="messcompa" --><tr class="problem"><!-- TMPL_ELSE --><tr><!-- /TMPL_IF -->
-                    <td><p><!-- TMPL_VAR NAME="reservedate" --></p> <!-- TMPL_IF NAME="messcompa" --> Hold over <!-- /TMPL_IF --></td>
-                    <td><!-- TMPL_IF name="BiblioDefaultViewmarc" -->
-<a href="/cgi-bin/koha/catalogue/MARCdetail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title" --></a>
-<!-- TMPL_ELSIF NAME="BiblioDefaultViewisbd" -->
-<a href="/cgi-bin/koha/catalogue/ISBDdetail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title" --></a>
-<!-- TMPL_ELSE -->
-<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=<!-- TMPL_VAR NAME="biblionumber" ESCAPE="URL" -->"><!-- TMPL_VAR NAME="title" -->  <!-- TMPL_VAR NAME="subtitle" --></a><!-- /TMPL_IF -->&nbsp; (<b><!-- TMPL_VAR NAME="itemtype" --> </b>) <br />Barcode : <!-- TMPL_VAR NAME="barcode" --></td>
-                    <td><a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=<!--TMPL_VAR Name="borrowernum"-->"><!-- TMPL_VAR NAME="borrowername" -->, <!-- TMPL_VAR NAME="borrowerfirstname" --></a><br />
-                            <!-- TMPL_VAR NAME="borrowerphone" --><br />
-                            <!-- TMPL_IF NAME="borrowermail" -->
-                                <a href="mailto:<!-- TMPL_VAR NAME="email" -->?subject=Reservation: <!-- TMPL_VAR NAME="title" -->">
-                                    <!-- TMPL_VAR NAME="borrowermail" -->
-                                </a>
-                            <!--/TMPL_IF-->
-                    </td>
-                    <td><!-- TMPL_VAR NAME="holdingbranch" --> <!-- TMPL_VAR NAME="itemcallnumber" --></td>
-                    <td>
-                    <form name="dotransfer" action="/cgi-bin/koha/circ/waitingreserves.pl" method="post">
-                        <input type="hidden" name="itemnumber" value="<!-- TMPL_VAR NAME="itemnumber" -->" />
-                        <input type="hidden" name="fbr" value="<!-- TMPL_VAR NAME="holdingbranch" -->" />
-                        <input type="hidden" name="tbr" value="<!-- TMPL_VAR NAME="branchcode" -->" />
-                    <input type="submit" value="Transfer this item" />
-                    </form>
-                    </td>
-                </tr>
-            <!-- /TMPL_LOOP --></tbody>
-            </table>
-            <!-- /TMPL_IF -->
-        <!-- /TMPL_LOOP -->
-    </div>
-    <!-- TMPL_ELSE -->
-        <p>No transfers to do</p>
-    <!-- /TMPL_IF -->
-
-</div>
-</div>
-</div>
-<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/transferstodo.tmpl
deleted file mode 100644 (file)
index 259aedf..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-<!-- TMPL_INCLUDE NAME="help-top.inc" -->
-
-<h1>Transfers To Do Help</h1><h2>What is a Transfer To Do?</h2>
-
-<p>A Transfer To Do is where a patron in another library/branch has requested an item that is on your shelf. This tells you the items that need to be sent to other libraries/branches.</p>
-
-<h2>How do you Transfer an Item? <br /></h2>
-
-<p>To Transfer an item, locate the item on the shelf, ready it for shipping and click the &quot;Transfer This Item&quot; button next to the item. This will change the status of the item to &quot;In Transit&quot; from your branch to the destination branch.</p>
-
-<!-- TMPL_INCLUDE name="help-bottom.inc" -->
\ No newline at end of file