Bug 17559: Fixed HTML element ID of B_streetnumber
authorRadek Šiman <rbit@rbit.cz>
Thu, 3 Nov 2016 13:45:43 +0000 (14:45 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 18 Nov 2016 14:16:43 +0000 (14:16 +0000)
There is a duplicate ID in HTML code, because of this:
<input type="text" id="B_address" name="B_streetnumber" size="5"
value="" />
<input type="text" id="B_address" name="B_address" size="40" value="" />

Test plan:
1) Edit a patron and look into its HTML code
2) Find input: name="B_streetnumber"
3) Its ID is B_address - a duplicate within the code in fact
4) Apply the patch
5) Repeat steps 1 and 2
6) The ID is unique now: B_streetnumber

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-de.inc
koha-tmpl/intranet-tmpl/prog/en/includes/member-alt-address-style-us.inc

index 43385f2..dba4222 100644 (file)
@@ -43,7 +43,7 @@
                     <label for="B_streetnumber">
                 [% END %]
                 Street Number: </label>
-                    <input type="text" id="B_address" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
+                    <input type="text" id="B_streetnumber" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
                 [% IF ( mandatoryB_streetnumber ) %]<span class="required">Required</span>[% END %]
             </li>
         [% END %]
index 7c4adbd..9ae71c1 100644 (file)
@@ -8,7 +8,7 @@
                     <label for="B_streetnumber">
                 [% END %]
                 Street Number: </label>
-                <input type="text" id="B_address" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
+                <input type="text" id="B_streetnumber" name="B_streetnumber" size="5" value="[% B_streetnumber %]" />
                [% IF ( mandatoryB_streetnumber ) %]<span class="required">Required</span>[% END %]
             </li>
         [% END %]