Bug 31902: Next header row inside a thead
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 8 Nov 2022 15:51:15 +0000 (15:51 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 9 Nov 2022 17:01:53 +0000 (14:01 -0300)
This sets the proper markup for table headers in the holds page and thus
grabs the proper header row underline.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/includes/holds_table.inc

index 940e304..d5b9a67 100644 (file)
@@ -2,27 +2,29 @@
 [% SET hold_cancellation = AuthorisedValues.GetAuthValueDropbox('HOLD_CANCELLATION') %]
 [% USE AuthorisedValues %]
 <table class="holds_table">
-    <tr>
-        <th><input type="checkbox" class="select_hold_all"/></th>
-        <th>Priority</th>
-        [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
+    <thead>
+        <tr>
+            <th><input type="checkbox" class="select_hold_all"/></th>
+            <th>Priority</th>
+            [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
+                <th>&nbsp;</th>
+            [% END %]
+            <th>Patron</th>
+            <th>Notes</th>
+            <th>Date</th>
+            <th>Expiration</th>
+            <th>Pickup library</th>
+            <th>Details</th>
+            [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
+                <th>
+                    <i class="fa fa-lg fa-rotate-90 fa-fast-forward" title="Toggle set to lowest priority"></i>
+                </th>
+            [% END %]
             <th>&nbsp;</th>
-        [% END %]
-        <th>Patron</th>
-        <th>Notes</th>
-        <th>Date</th>
-        <th>Expiration</th>
-        <th>Pickup library</th>
-        <th>Details</th>
-        [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %]
-            <th>
-                <i class="fa fa-lg fa-rotate-90 fa-fast-forward" title="Toggle set to lowest priority"></i>
-            </th>
-        [% END %]
-        <th>&nbsp;</th>
-        <th>&nbsp;</th>
-        <th>Print hold/transfer slip</th>
-    </tr>
+            <th>&nbsp;</th>
+            <th>Print hold/transfer slip</th>
+        </tr>
+    </thead>
     [%- SET first_priority = 0 -%]
     [%- SET found_holds = 0 -%]
     [%- SET last_priority  = holds.last.priority -%]