Bug 15408: Fix tests to fail without patch
authorNick Clemens <nick@bywatersolutions.com>
Tue, 7 Aug 2018 13:37:30 +0000 (13:37 +0000)
committerNick Clemens <nick@bywatersolutions.com>
Wed, 22 Aug 2018 12:51:53 +0000 (12:51 +0000)
We set all the timestamps to a specified date and ensure the new budgets
don't have this date

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
t/db_dependent/Budgets.t

index 32e077d..ec14e11 100755 (executable)
@@ -11,6 +11,7 @@ use C4::Acquisition;
 
 use Koha::Acquisition::Booksellers;
 use Koha::Acquisition::Orders;
+use Koha::Acquisition::Funds;
 use Koha::Patrons;
 
 use t::lib::TestBuilder;
@@ -477,6 +478,12 @@ is ( GetBudgetOrdered( $fund ), '20', "total ordered price is 20");
 
 
 # CloneBudgetPeriod
+# Let's make sure our timestamp is old
+my @orig_funds = Koha::Acquisition::Funds->search({ budget_period_id => $budget_period_id });
+foreach my $fund (@orig_funds){
+    $fund->timestamp('1999-12-31 23:59:59')->store;
+}
+
 my $budget_period_id_cloned = C4::Budgets::CloneBudgetPeriod(
     {
         budget_period_id        => $budget_period_id,
@@ -490,12 +497,9 @@ my $budget_period_cloned = C4::Budgets::GetBudgetPeriod($budget_period_id_cloned
 is($budget_period_cloned->{budget_period_description}, 'Budget Period Cloned', 'Cloned budget\'s description is updated.');
 
 my $budget_cloned = C4::Budgets::GetBudgets({ budget_period_id => $budget_period_id_cloned });
-my $test =  $budget_cloned->[0]->{timestamp};
-my $budget_time = Koha::DateUtils::dt_from_string($test);
-my $local_time = Koha::DateUtils::dt_from_string();
-
+my $budget_time =  $budget_cloned->[0]->{timestamp};
 
-is(DateTime::compare($budget_time, $local_time), 0, "New budget got the right timestamp");
+isnt($budget_time, '1999-12-31 23:59:59', "New budget has an updated timestamp");