Bug 11855: Tiny code cleanup in members
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 27 Feb 2014 08:12:25 +0000 (09:12 +0100)
committerGalen Charlton <gmc@esilibrary.com>
Tue, 8 Apr 2014 23:42:46 +0000 (23:42 +0000)
[1] Template variable actionname is not used in the associated
template. This could be a copy-paste from serials/member-search.pl.
Consequently, the module is no longer needed in member.pl. Template
members/search.tt still contains actionname; it seems that this
emplate is not used too.

[2] $template_name not used in members-home.pl.

Test plan:
[1] Go to Patrons. If you reach that page, you tested members-home.pl
[2] Add a new patron.
[3] Search for a patron. Edit one.

Followed test plan. No problems found.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
members/member.pl
members/members-home.pl

index ff6e41a..dfc7363 100755 (executable)
@@ -31,7 +31,6 @@ use C4::Members;
 use C4::Branch;
 use C4::Category;
 use Koha::DateUtils;
-use File::Basename;
 use Koha::List::Patron;
 
 my $input = new CGI;
@@ -225,7 +224,6 @@ $template->param(
     branchloop   => \@branchloop,
     categories   => \@categories,
     searching    => "1",
-    actionname   => basename($0),
     numresults   => $count,
     resultsloop  => \@resultsdata,
     results_per_page => $resultsperpage,
index 1d8f1e5..9d1e3e5 100755 (executable)
@@ -30,7 +30,6 @@ use Koha::Borrower::Modifications;
 
 my $query = new CGI;
 my $branch = $query->param('branchcode');
-my $template_name;
 
 $branch = q{} unless defined $branch;