Bug 19532: (follow-up) aria-hidden attr on OPAC, and more

- removing authnotrequired flag from scripts
- fixing opac buttons
- chmod +x for recalls test files

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
index 63b9a91..a76406b 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc
@@ -12,7 +12,7 @@
     [% END %]
 
     [% IF Koha.Preference('UseRecalls') %]
-        <li><a class="recall btn btn-link btn-lg" href="/cgi-bin/koha/opac-recall.pl?biblionumber=[% biblio.biblionumber | html %]"><i class="fa fa-fw fa-bookmark-o"></i>
+        <li><a class="recall btn btn-link btn-lg" href="/cgi-bin/koha/opac-recall.pl?biblionumber=[% biblio.biblionumber | html %]"><i class="fa fa-fw fa-bookmark-o" aria-hidden="true"></i>
         Place recall</a></li>
     [% END %]
 

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
index 9cec6a0..83d4793 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-recall.tt
@@ -151,7 +151,7 @@
                                         <fieldset class="action">
                                             <input type="hidden" name="op" value="request">
                                             <input type="hidden" name="biblionumber" value="[% biblio.biblionumber | html %]">
-                                            <input type="submit" class="btn" value="Confirm">
+                                            <input type="submit" class="btn btn-primary" value="Confirm">
                                             <a href="/cgi-bin/koha/opac-detail.pl?biblionumber=[% biblio.biblionumber | uri %]" class="cancel">Cancel</a>
                                         </fieldset>
                                     </form>

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
index b06fb5b..d0bcbb4 100644 (file)
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt
@@ -816,7 +816,7 @@
                                                         <input type="hidden" name="op" value="cancel">
                                                         <input type="hidden" name="recall_id" value="[% RECALL.recall_id | html %]">
                                                         <input type="hidden" name="biblionumber" value="[% RECALL.biblionumber | html %]">
-                                                        <button type="submit" name="submit" class="btn btn-sm btn-danger" id="cancel_recall"><i class="icon-remove icon-white"></i> Cancel</button>
+                                                        <button type="submit" name="submit" class="btn btn-sm btn-danger cancel_recall"><i class="fa fa-remove" aria-hidden="true"></i> Cancel</button>
                                                     </form>
                                                 [% END %]
                                             </td>
@@ -1205,7 +1205,7 @@
                 });
             }
 
-            $("#cancel_recall").click(function(e){
+            $(".cancel_recall").click(function(e){
                 return confirmDelete(_("Are you sure you want to remove this recall?"));
             });
 

diff --git a/members/recallshistory.pl b/members/recallshistory.pl
index c679019..851d000 100755 (executable)
--- a/members/recallshistory.pl
+++ b/members/recallshistory.pl
@@ -27,7 +27,6 @@ my ($template, $loggedinuser, $cookie)= get_template_and_user(
        template_name => "members/recallshistory.tt",
        query => $input,
        type => "intranet",
-       authnotrequired => 0,
        flagsrequired => { recalls => 1 },
        debug => 1,
     }

diff --git a/opac/opac-recall.pl b/opac/opac-recall.pl
index fbc2cd0..779a126 100755 (executable)
--- a/opac/opac-recall.pl
+++ b/opac/opac-recall.pl
@@ -29,7 +29,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
         template_name   => "opac-recall.tt",
         query           => $query,
         type            => "opac",
-        authnotrequired => 0,
     }
 );
 

diff --git a/opac/opac-recalls.pl b/opac/opac-recalls.pl
index 96b0c78..59c657b 100755 (executable)
--- a/opac/opac-recalls.pl
+++ b/opac/opac-recalls.pl
@@ -29,7 +29,6 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
       template_name   => "opac-recalls.tt",
       query           => $input,
       type            => "opac",
-      authnotrequired => 0,
    }
 );
 

diff --git a/recalls/recall_pickup_slip.pl b/recalls/recall_pickup_slip.pl
index cc6a02e..7137e59 100755 (executable)
--- a/recalls/recall_pickup_slip.pl
+++ b/recalls/recall_pickup_slip.pl
@@ -30,7 +30,6 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
         template_name   => "circ/printslip.tt",
         query           => $input,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { circulate => "circulate_remaining_permissions" },
     }
 );

diff --git a/recalls/recalls_old_queue.pl b/recalls/recalls_old_queue.pl
index ed82677..bdabc46 100755 (executable)
--- a/recalls/recalls_old_queue.pl
+++ b/recalls/recalls_old_queue.pl
@@ -28,7 +28,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
       template_name   => "recalls/recalls_old_queue.tt",
       query           => $query,
       type            => "intranet",
-      authnotrequired => 0,
       flagsrequired   => { recalls => "manage_recalls" },
       debug           => 1,
     }

diff --git a/recalls/recalls_overdue.pl b/recalls/recalls_overdue.pl
index 82b755c..3c73dd3 100755 (executable)
--- a/recalls/recalls_overdue.pl
+++ b/recalls/recalls_overdue.pl
@@ -29,7 +29,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
        template_name   => "recalls/recalls_overdue.tt",
        query           => $query,
        type            => "intranet",
-       authnotrequired => 0,
        flagsrequired   => { recalls => "manage_recalls" },
        debug           => 1,
     }

diff --git a/recalls/recalls_queue.pl b/recalls/recalls_queue.pl
index 59ceb00..5676ca8 100755 (executable)
--- a/recalls/recalls_queue.pl
+++ b/recalls/recalls_queue.pl
@@ -28,7 +28,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
       template_name   => "recalls/recalls_queue.tt",
       query           => $query,
       type            => "intranet",
-      authnotrequired => 0,
       flagsrequired   => { recalls => 'manage_recalls' },
       debug           => 1,
     }

diff --git a/recalls/recalls_to_pull.pl b/recalls/recalls_to_pull.pl
index 1665221..5b2bfbd 100755 (executable)
--- a/recalls/recalls_to_pull.pl
+++ b/recalls/recalls_to_pull.pl
@@ -28,7 +28,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
       template_name   => "recalls/recalls_to_pull.tt",
       query           => $query,
       type            => "intranet",
-      authnotrequired => 0,
       flagsrequired   => { recalls => 'manage_recalls' },
       debug           => 1,
     }

diff --git a/recalls/recalls_waiting.pl b/recalls/recalls_waiting.pl
index 0814ffa..f18d5c0 100755 (executable)
--- a/recalls/recalls_waiting.pl
+++ b/recalls/recalls_waiting.pl
@@ -31,7 +31,6 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
         template_name   => "recalls/recalls_waiting.tt",
         query           => $query,
         type            => "intranet",
-        authnotrequired => 0,
         flagsrequired   => { recalls => "manage_recalls" },
         debug           => 1,
     }

diff --git a/recalls/request.pl b/recalls/request.pl
index 59a4b45..04e6cd0 100755 (executable)
--- a/recalls/request.pl
+++ b/recalls/request.pl
@@ -30,7 +30,6 @@ my ($template, $loggedinuser, $cookie)= get_template_and_user(
        template_name => "recalls/request.tt",
        query => $input,
        type => "intranet",
-       authnotrequired => 0,
        flagsrequired => { recalls => "manage_recalls" },
        debug => 1,
     }

diff --git a/t/db_dependent/Koha/Recall.t b/t/db_dependent/Koha/Recall.t
old mode 100644 (file)
new mode 100755 (executable)

diff --git a/t/db_dependent/Koha/Recalls.t b/t/db_dependent/Koha/Recalls.t
old mode 100644 (file)
new mode 100755 (executable)