Bug 4461: Use KohaAdminEmailAddress pref as 'from'

We usually do not specify the from_address on enqueuing the notice, but
when sending it (from _send_message_by_email). That way a) the code is
centralized (as we must use $patron->notice_email_address) and b) the
email used is the one that is in the DB when the letter is effectively
sent.
Here I guess you need to give it when the notice is enqueued as you want
to default to the koha admin address.

I do not think it's a good idea, we should not send an email with "from"
if not really sent by the user.
We have the borrowernumber anyway to know who filled the form.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

diff --git a/opac/opac-reportproblem.pl b/opac/opac-reportproblem.pl
index 77cacfe..a6795c1 100644 (file)
--- a/opac/opac-reportproblem.pl
+++ b/opac/opac-reportproblem.pl
@@ -109,7 +109,7 @@ if ( $op eq 'addreport' ) {
         }
     );
 
-    my $from_address = $member->email || $member->emailpro || $member->B_email || $koha_admin;
+    my $from_address = C4::Context->preference('KohaAdminEmailAddress');
     my $transport = 'email';
 
     if ( $recipient eq 'admin' ) {