Bug 16649: Make OpenLibrarySearch test pass even if launches offline
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sat, 4 Jun 2016 11:26:27 +0000 (12:26 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 10 Jun 2016 17:05:03 +0000 (17:05 +0000)
Test plan:
  prove t/OpenLibrarySearch.t
should return green even if you are offline

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/OpenLibrarySearch.t

index 8084453..b0865e6 100644 (file)
@@ -22,7 +22,11 @@ use Test::More tests => 1;
 use LWP::Simple;
 use JSON;
 my $content  = get("https://openlibrary.org/search.json?q=9780201038095");
-my $data     = from_json($content);
-my $numFound = $data->{numFound};
 
-ok( $numFound > 0, "The openlibrary ws should return at least 1 result" );
+SKIP: {
+    skip "json has not been retrieved from openlibrary.org", 1 unless defined $content;
+    my $data     = from_json($content);
+    my $numFound = $data->{numFound};
+
+    ok( $numFound > 0, "The openlibrary ws should return at least 1 result" );
+}