Bug 9016: (follow-up) fix unit tests

The unit tests should insert overdue rules.
+ Fix the doc for GetOverdueMessageTransportTypes

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

diff --git a/C4/Overdues.pm b/C4/Overdues.pm
index f9212f4..66cb108 100644 (file)
--- a/C4/Overdues.pm
+++ b/C4/Overdues.pm
@@ -911,7 +911,7 @@ sub RemoveNotifyLine {
 
     my $message_transport_types = GetOverdueMessageTransportTypes( $branchcode, $categorycode, $letternumber);
 
-    return a arrayref with message_transport_type for given branchcode, categorycode and letternumber(1,2 or 3)
+    return a arrayref with all message_transport_type for given branchcode, categorycode and letternumber(1,2 or 3)
 
 =cut
 sub GetOverdueMessageTransportTypes {

diff --git a/t/db_dependent/Overdues.t b/t/db_dependent/Overdues.t
index 2725565..b023cfd 100644 (file)
--- a/t/db_dependent/Overdues.t
+++ b/t/db_dependent/Overdues.t
@@ -14,6 +14,7 @@ $dbh->{RaiseError} = 1;
 $dbh->do(q|DELETE FROM letter|);
 $dbh->do(q|DELETE FROM message_queue|);
 $dbh->do(q|DELETE FROM message_transport_types|);
+$dbh->do(q|DELETE FROM overduerules|);
 $dbh->do(q|DELETE FROM overduerules_transport_types|);
 
 $dbh->do(q|
@@ -21,6 +22,14 @@ $dbh->do(q|
 |);
 
 $dbh->do(q|
+    INSERT INTO overduerules ( branchcode, categorycode ) VALUES
+    ('CPL', 'PT'),
+    ('CPL', 'YA'),
+    ('', 'PT'),
+    ('', 'YA')
+|);
+
+$dbh->do(q|
     INSERT INTO overduerules_transport_types( branchcode, categorycode, letternumber, message_transport_type ) VALUES
     ('CPL', 'PT', 1, 'email'),
     ('CPL', 'PT', 2, 'sms'),
@@ -53,7 +62,7 @@ is_deeply( $mtts, ['sms'], 'GetOverdueMessageTransportTypes: second overdue is b
 $mtts = C4::Overdues::GetOverdueMessageTransportTypes('CPL', 'PT', 3);
 is_deeply( $mtts, ['email'], 'GetOverdueMessageTransportTypes: third overdue is by email for PT (CPL)' );
 
-my $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
+$mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
 is_deeply( $mtts, ['email'], 'GetOverdueMessageTransportTypes: first overdue is by email for PT (default)' );
 
 $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 2);