Bug 7688 changed the prototype for GetNextDate, but the serialsUpdate.pl
cronjob script had not been updated. This patch fixes the problem.
Test plan:
Before applying the patch:
1/ Check that the following SQL query returns something:
SELECT serial.*
FROM serial
LEFT JOIN subscription ON (subscription.subscriptionid = serial.subscriptionid)
WHERE serial.status = 1
AND DATE_ADD(planneddate, INTERVAL CAST(graceperiod AS SIGNED) DAY) < NOW()
AND subscription.closed = 0;
2/ Run misc/cronjobs/serialsUpdate.pl -v
It should die with an error message like this:
Can't use string ("2011-03-05") as a HASH ref while "strict refs" in use
3/ Apply the patch
4/ Run misc/cronjobs/serialsUpdate.pl -v
It should exit normally and print messages like this:
Serial issue with id=XX updated
5/ Run the Koha QA test tools.
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
while ( my $issue = $sth->fetchrow_hashref ) {
my $subscription = &GetSubscription( $issue->{subscriptionid} );
- my $planneddate = $issue->{planneddate};
+ my $publisheddate = $issue->{publisheddate};
- if ( $subscription && $planneddate && $planneddate ne "0000-00-00" ) {
- my $nextpublisheddate = GetNextDate( $planneddate, $subscription );
+ if ( $subscription && $publisheddate && $publisheddate ne "0000-00-00" ) {
+ my $nextpublisheddate = GetNextDate( $subscription, $publisheddate );
my $today = format_date_in_iso( C4::Dates->new()->output() );
if ( $nextpublisheddate && $today ) {