Bug 31381: Handle null attributes in list
authorNick Clemens <nick@bywatersolutions.com>
Tue, 22 Nov 2022 19:21:22 +0000 (19:21 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 30 Nov 2022 18:58:13 +0000 (15:58 -0300)
This patch allows null values to be returned in patron attributes
to prevent a crash when searching patrons

To test:
1 - Add a NULL attribute to a borrower, in sample data, Edna Acosta
    sudo koha-mysql kohadev
    INSERT INTO borrower_attributes (borrowernumber,code,attribute) VALUES (5,'SHOW_BCODE',NULL);
2 - Browse to 'Home->Patrons'
    http://localhost:8081/cgi-bin/koha/members/members-home.pl
3 - Click 'Browse by last name: A'
4 - Datatables error:
    Expected string - got null
5 - Apply patch
6 - Restart all
7 - Browse by last name: A
8 - Success!

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
api/v1/swagger/definitions/patron_extended_attribute.yaml

index 84343d2..4bfd856 100644 (file)
@@ -11,6 +11,7 @@ properties:
     description: Extended attribute value
     type:
       - string
+      - "null"
 additionalProperties: false
 required:
   - type