Bug 16013: Make classification sources deletable
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 9 Mar 2016 11:28:04 +0000 (11:28 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Mon, 21 Mar 2016 22:40:37 +0000 (22:40 +0000)
Because of a wrong variable scope, the classification sources are not
deletable.

Test plan:
Create a classification sources (admin/classsources.pl)
Try to delete it
Without this patch, the classification source won't be deleted
With this patch, it will work!

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
admin/classsources.pl

index 0b7ee31..cc2fe87 100755 (executable)
@@ -58,7 +58,7 @@ if ($op eq "add_source") {
                      $rule_code);
     $display_lists = 1;
 } elsif ($op eq "delete_source") {
-    delete_class_source_form($template);
+    delete_class_source_form($template, $source_code);
 } elsif ($op eq "delete_source_confirmed") {
     delete_class_source($template, $source_code);
     $display_lists = 1;
@@ -146,7 +146,7 @@ sub edit_class_source {
 
 
 sub delete_class_source_form {
-    my ($template) = @_;
+    my ($template, $source_code) = @_;
     $template->param(
         delete_class_source_form => 1,
         confirm_op   => "delete_source_confirmed",