Bug 32964: OPACResultsMaxItemsUnavailable description is misleading

This patch rephrases the last part of the description of the
OPACResultsMaxItemsUnavailable system preference to clarify the link
to the OPACResultsUnavailableGroupingBy option.

It also changes some terminology to follow the guidelines
(capitalization, library instead of branch).

To test:
1. Apply patch
2. Go to Administration > Global system preferences
3. Search for OPACResultsMaxItems
4. Read the sentence for OPACResultsMaxItemsUnavailable, make sure it
makes sense, the grammar and spelling are ok, respects terminology
and capitalization guidelines
5. Try the link in the description, make sure it goes to the correct
syspref
6. Read the sentence and options for OPACResultsUnavailableGroupingBy,
make sure it makes sense, the grammar and spelling are ok, respects
terminology and capitalization guidelines
7. Optionally, try the various options, they should still work as
intended

Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
index a187823..25796a1 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
@@ -325,13 +325,13 @@ OPAC:
             - pref: OPACResultsMaxItems
             - (available) individual items on the OPAC XSLT search results, and show no more than
             - pref: OPACResultsMaxItemsUnavailable
-            - "(unavailable) individual items for categories like Checked out, Damaged, On Hold, but only when you group them by branch.<br>"
+            - '(unavailable) individual items for categories like Checked out, Damaged, On hold, but only if <a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=OPACResultsUnavailableGroupingBy">OPACResultsUnavailableGroupingBy</a> is set to "library and substatus".<br>'
             - Group unavailable items by
             - pref: OPACResultsUnavailableGroupingBy
               choices:
-                  branch: "branch and substatus"
+                  branch: "library and substatus"
                   substatus: "substatus only"
-                  branchonly: "branch only"
+                  branchonly: "library only"
             - ". (NOTE: For large consortia we recommend to group unavailable items by substatus, listing item counts only.)"
 
     Features: