Bug 8707 - tags always say approved
authorOwen Leonard <oleonard@myacpl.org>
Tue, 30 Oct 2012 15:07:04 +0000 (11:07 -0400)
committerJared Camins-Esakov <jcamins@cpbibliography.com>
Wed, 31 Oct 2012 20:48:24 +0000 (16:48 -0400)
Template scope error caused an incorrect state on the
approval/rejection buttons when viewing rejected tags.

To test, go to Tags and view the list of rejected tags.
In the "Actions" column, the "rejected" button should be
greyed out, and the "approve" button active.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Passed-QA-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tags/review.tt

index 4b68e13..4569525 100644 (file)
@@ -209,7 +209,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
        <tr>
            <td class="count">[% offset + loop.count %]
            </td>
-        [% IF ( approved == 0 ) %]<td><span><input type="checkbox" value="[% tagloo.term %]" name="tags" class="pending" /></span>
+        [% IF ( tagloo.approved == 0 ) %]<td><span><input type="checkbox" value="[% tagloo.term %]" name="tags" class="pending" /></span>
         [% ELSE %]<td><span><input type="checkbox" value="[% tagloo.term %]" name="tags" /></span>[% END %]
            </td>
            [% IF ( tagloo.approved == -1 ) %]<td class="red">rejected
@@ -223,7 +223,7 @@ td input,td input[type="submit"] { font-size: 85%; padding: 1px; }
            </td>
                [% IF ( tagloo.approved ) %]
            <td><span class="ajax_buttons" style="visibility:hidden">
-                       [% IF ( approved == -1 ) %]
+            [% IF ( tagloo.approved == -1 ) %]
                        <input class="ok"  type="submit" title="[% tagloo.term %]" value="Approve" name="approve" />
                        <input class="rej" disabled="disabled" type="submit" title="[% tagloo.term %]" value="Rejected" name="reject" />
                        [% ELSE %]