Bug 12151: Remove uses of smartmatch operator from Koha/Solr/QueryBuilder.pm

Just that.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and tests.
Could only verify by reading the code.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/Koha/SearchEngine/Solr/QueryBuilder.pm b/Koha/SearchEngine/Solr/QueryBuilder.pm
index b3e75c9..ba5547f 100644 (file)
--- a/Koha/SearchEngine/Solr/QueryBuilder.pm
+++ b/Koha/SearchEngine/Solr/QueryBuilder.pm
@@ -60,16 +60,12 @@ sub build_advanced_query {
         # And others
         $index_name = @$indexes[$i] if @$indexes[$i];
         my $operator = defined @$operators[$i-1] ? @$operators[$i-1] : 'AND';
-        for ( uc ( $operator ) ) {
-            when ('OR'){
-                $q .= BuildTokenString($index_name, $kw, 'OR');
-            }
-            when ('NOT'){
-                $q .= BuildTokenString($index_name, $kw, 'NOT');
-            }
-            default {
-                $q .= BuildTokenString($index_name, $kw, 'AND');
-            }
+        if ( uc ( $operator ) eq 'OR' ) {
+            $q .= BuildTokenString($index_name, $kw, 'OR');
+        } elsif ( uc ( $operator ) eq 'NOT' ) {
+            $q .= BuildTokenString($index_name, $kw, 'NOT');
+        } else {
+            $q .= BuildTokenString($index_name, $kw, 'AND');
         }
         $i = $i + 1;
     }