Bug 16162: Making dictionary 'Delete' a button
authorAleisha <aleishaamohia@hotmail.com>
Tue, 29 Mar 2016 23:44:56 +0000 (23:44 +0000)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Thu, 7 Apr 2016 00:09:53 +0000 (00:09 +0000)
EDIT: This patch should have gotten rid of those tabs
EDIT2: Will now apply with patch on Bug 16161

To test:
1) Apply Bug 16161 first
2) Go to Reports -> View dictionary
3) Confirm that the 'Delete definition' button now just says 'Delete' and is styled as a font awesome button.
4) Confirm that the button does not wrap on narrower browsers.
5) Confirm that column heading is now 'Action'.
6) Confirm that button deletes as expected. (If you're wondering about the missing confirm message upon delete, see Bug 16161.)

Sponsored-by: Catalyst IT
Tested on top of Bug 16161
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tt

index 1b366e9..fbae1d3 100644 (file)
@@ -71,7 +71,7 @@ var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this dictionary defi
                <th>Description</th>
                <th>Area</th>
                <th>Definition</th>
-               <th>&nbsp;</th>
+                <th>Action</th>
                </tr>
                [% FOREACH definition IN definitions %]
         <tr>
@@ -79,10 +79,10 @@ var MSG_CONFIRM_DELETE = _("Are you sure you want to delete this dictionary defi
                        <td>[% definition.description %]</td>
                        <td>[% definition.areaname %]</td>
                        <td>[% definition.saved_sql %]</td>
-                       <td><form method="post" action="/cgi-bin/koha/reports/dictionary.pl">
+                        <td class="actions"><form method="post" action="/cgi-bin/koha/reports/dictionary.pl">
                        <input type="hidden" name="id" value="[% definition.id %]" />
                        <input type="hidden" name="phase" value="Delete Definition" />
-                       <input type="submit" name="submit" value="Delete Definition" onclick="return confirm(MSG_CONFIRM_DELETE);" />
+                        <button type="submit" name="submit" class="btn btn-mini" onclick="return confirm(MSG_CONFIRM_DELETE);"><i class="fa fa-trash"></i> Delete</button>
                        </form></td>
                        </tr>
                [% END %]