Bug 12740 - It should not be possible to store empty news
authorMarc Véron <veron@veron.ch>
Sat, 13 Sep 2014 16:10:06 +0000 (18:10 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Sat, 11 Oct 2014 14:51:53 +0000 (11:51 -0300)
This patch marks the title field as 'required' and it is not
longer possible to store a news without having at least a title.

To test:
Got to Tools->News
Create news or edit existing news
Field "Title" should have a red label and should be marked as "required"
It should not be possible to save with empty field "Title"

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
NOTE: Only keeps the user from doing it.
      Fails to handle the fake the url call case.
https://demo.library-admin.kohasystem.ca/cgi-bin/koha/tools/koha-news.pl?op=add&lang=&branch=&title=&from=&to=&number=&new=

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt

index 552fb6e..e1159f8 100644 (file)
@@ -119,8 +119,8 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div>
                 </select>
             </li>
             <li>
-                <label for="title">Title: </label>
-                <input id="title" size="30" type="text" name="title" value="[% new_detail.title %]" />
+                <label for="title" class="required">Title: </label>
+                <input id="title" size="30" type="text" name="title" value="[% new_detail.title %]" required="required" class="required" /> <span class="required">Required</span>
             </li>
             <li>
                 <label for="from">Publication date: </label>
@@ -141,7 +141,8 @@ Edit news item[% ELSE %]Add news item[% END %][% ELSE %]News[% END %]</div>
                 [% END %]
             </li>
             <li><label for="new">News: </label>
-            <textarea name="new" id="new"  cols="75" rows="10">[% new_detail.new %]</textarea></li>
+            <textarea name="new" id="new"  cols="75" rows="10">[% new_detail.new %]</textarea>
+            </li>
             </ol>
                        </fieldset>