Bug 32377: Set param skiptotals on call of GetBudgetHierarchy in acqui/histsearch.pl
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Wed, 30 Nov 2022 10:33:19 +0000 (12:33 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 3 Feb 2023 22:23:06 +0000 (22:23 +0000)
Calling GetBudgetHierarchy from acqui/histsearch.pl
is slow if param skiptotals is not used.

To test:
1. Open browsers Console -> Network (F12).
2. Navigate to Order search page and perform search.
=> Take a note how long it takes to load the Search results page.
3. Apply this patch.
4. Repeat step 2.
=> Page should now load faster.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 0f5daaa553bc63bd2c08212ee8db3d56c52781e9)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit 6b5cf15102235daa38a1f5a70e6ee7bea306abe5)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
acqui/histsearch.pl

index e1bdb38..6427062 100755 (executable)
@@ -123,7 +123,7 @@ if ($do_search) {
 my $budgetperiods = C4::Budgets::GetBudgetPeriods;
 my $bp_loop = $budgetperiods;
 for my $bp ( @{$budgetperiods} ) {
-    my $hierarchy = C4::Budgets::GetBudgetHierarchy( $$bp{budget_period_id} );
+    my $hierarchy = C4::Budgets::GetBudgetHierarchy( $$bp{budget_period_id}, undef, undef, 1 );
     for my $budget ( @{$hierarchy} ) {
         $$budget{budget_display_name} = sprintf("%s", ">" x $$budget{depth} . $$budget{budget_name});
     }