Bug 18089 - All XSLT testing singleBranchMode = 0 fails to show even if install has...
authorKyle M Hall <kyle@bywatersolutions.com>
Thu, 9 Feb 2017 11:48:40 +0000 (11:48 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Tue, 14 Feb 2017 14:07:02 +0000 (14:07 +0000)
Due to the way it has been implemented, singleBranchMode is set to an
empty string rather than 0 if there is only one branch. This causes any
block that tests for singleBranchMOde to be 0 to never appear.

Test Plan:
1) Apply this patch set
2) prove t/XSLT.t

Signed-off-by: Jenny Schmidt <jschmidt@switchinc.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/XSLT.pm

index a829402..b757f8f 100644 (file)
@@ -179,7 +179,7 @@ sub get_xslt_sysprefs {
 
     # singleBranchMode was a system preference, but no longer is
     # we can retain it here for compatibility
-    my $singleBranchMode = Koha::Libraries->search->count == 1;
+    my $singleBranchMode = Koha::Libraries->search->count == 1 ? 1 : 0;
     $sysxml .= "<syspref name=\"singleBranchMode\">$singleBranchMode</syspref>\n";
 
     $sysxml .= "</sysprefs>\n";