Bug 26627: (QA follow-up) Remove barcode input by id

Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
index 51d2b30..4ebc4cd 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ -503,7 +503,7 @@
 
                                                 <div class="modal-footer">
                                                     <input type="hidden" name="cancel_reserve" value="0" />
-                                                    <input type="hidden" name="barcode" value="[% barcode | html %]" />
+                                                    <input id="confirm-hold-barcode" type="hidden" name="barcode" value="[% barcode | html %]" />
 
                                                     <button type="submit" class="btn btn-default approve" data-dismiss="modal">
                                                         <i class="fa fa-check"></i> Confirm hold
@@ -1088,7 +1088,8 @@
 
             $('.print').on("click",function(e){
                 this.form.print_slip.value = 1;
-                this.form.barcode.remove();
+                let barcode = document.getElementById('confirm-hold-barcode');
+                if ( barcode ) barcode.remove();
                 this.form.submit();
             });