Bug 16501: Remove some unneeded warns in Upload.t
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Wed, 11 May 2016 14:17:47 +0000 (16:17 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 16 May 2016 17:46:25 +0000 (17:46 +0000)
At some point I saw some gain in warning about a missing config line.
But these warns are actually not needed here.
Removing them here.

Test plan:
Run t/db_dependent/Upload.t while having upload_path in your koha-conf and
also without it.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Upload.t

index f6b46fc..1449c98 100644 (file)
@@ -37,15 +37,6 @@ our $uploads = [
     ],
 ];
 
-# Before we mock upload_path, we are checking the real folder
-# This may help identifying upload problems
-my $realdir = C4::Context->config('upload_path');
-if( !$realdir ) {
-    warn "WARNING: You do not have upload_path in koha-conf.xml";
-} elsif( !-w $realdir ) {
-    warn "WARNING: You do not have write permissions in $realdir";
-}
-
 # Redirect upload dir structure and mock File::Spec and CGI
 my $tempdir = tempdir( CLEANUP => 1 );
 t::lib::Mocks::mock_config('upload_path', $tempdir);