Bug 24583: Rewrite mandatory/class_sources to YAML
authorBernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Tue, 4 Feb 2020 22:58:09 +0000 (19:58 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 9 Mar 2020 13:54:31 +0000 (13:54 +0000)
YAML version of mandatory class_sources

To test:
1) Same test plan of first patch, only check tables
   class_sort_rules, class_split_rules and class_sources

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
installer/data/mysql/en/mandatory/class_sources.sql [deleted file]
installer/data/mysql/en/mandatory/class_sources.txt [deleted file]
installer/data/mysql/en/mandatory/class_sources.yml [new file with mode: 0644]

diff --git a/installer/data/mysql/en/mandatory/class_sources.sql b/installer/data/mysql/en/mandatory/class_sources.sql
deleted file mode 100644 (file)
index a4115d3..0000000
+++ /dev/null
@@ -1,41 +0,0 @@
--- 
--- Default classification sources and filing rules
--- for Koha.
---
--- Copyright (C) 2007 LiblimeA
--- Copyright 2018 Koha Development Team
---
--- This file is part of Koha.
---
--- Koha is free software; you can redistribute it and/or modify it
--- under the terms of the GNU General Public License as published by
--- the Free Software Foundation; either version 3 of the License, or
--- (at your option) any later version.
---
--- Koha is distributed in the hope that it will be useful, but
--- WITHOUT ANY WARRANTY; without even the implied warranty of
--- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
--- GNU General Public License for more details.
---
--- You should have received a copy of the GNU General Public License
--- along with Koha; if not, see <http://www.gnu.org/licenses>.
-
--- class sorting (filing) rules
-INSERT INTO `class_sort_rules` (`class_sort_rule`, `description`, `sort_routine`) VALUES
-                               ('dewey', 'Default filing rules for DDC', 'Dewey'),
-                               ('lcc', 'Default filing rules for LCC', 'LCC'),
-                               ('generic', 'Generic call number filing rules', 'Generic');
--- splitting rules
-INSERT INTO `class_split_rules` (`class_split_rule`, `description`, `split_routine`) VALUES
-                               ('dewey', 'Default splitting rules for DDC', 'Dewey'),
-                               ('lcc', 'Default splitting rules for LCC', 'LCC'),
-                               ('generic', 'Generic call number splitting rules', 'Generic');
-
--- classification schemes or sources
-INSERT INTO `class_sources` (`cn_source`, `description`, `used`, `class_sort_rule`, `class_split_rule`) VALUES
-                            ('ddc', 'Dewey Decimal Classification', 1, 'dewey', 'dewey'),
-                            ('lcc', 'Library of Congress Classification', 1, 'lcc', 'lcc'),
-                            ('udc', 'Universal Decimal Classification', 0, 'generic', 'generic'),
-                            ('sudocs', 'SuDoc Classification (U.S. GPO)', 0, 'generic', 'generic'),
-                            ('anscr', 'ANSCR (Sound Recordings)', 0, 'generic', 'generic'),
-                            ('z', 'Other/Generic Classification Scheme', 0, 'generic', 'generic');
diff --git a/installer/data/mysql/en/mandatory/class_sources.txt b/installer/data/mysql/en/mandatory/class_sources.txt
deleted file mode 100644 (file)
index 6748777..0000000
+++ /dev/null
@@ -1 +0,0 @@
-Default classification sources and filing rules
diff --git a/installer/data/mysql/en/mandatory/class_sources.yml b/installer/data/mysql/en/mandatory/class_sources.yml
new file mode 100644 (file)
index 0000000..6bd9a81
--- /dev/null
@@ -0,0 +1,98 @@
+---
+#
+#  Copyright 2020 Koha Development Team
+#
+#  This file is part of Koha.
+#
+#  Koha is free software; you can redistribute it and/or modify it under the
+#  terms of the GNU General Public License as published by the Free Software
+#  Foundation; either version 2 of the License, or (at your option) any later
+#  version.
+#
+#  Koha is distributed in the hope that it will be useful, but WITHOUT ANY
+#  WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
+#  A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+#
+#  You should have received a copy of the GNU General Public License along
+#  with Koha; if not, write to the Free Software Foundation, Inc.,
+#  51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+#
+
+description:
+  - "Default classification sources and filing rules for Koha."
+
+tables:
+  # class sorting (filing) rules
+  - class_sort_rules:
+      translatable: [ description ]
+      multiline: []
+      rows:
+        - class_sort_rule: "dewey"
+          description: "Default filing rules for DDC"
+          sort_routine: "Dewey"
+
+        - class_sort_rule: "lcc"
+          description: "Default filing rules for LCC"
+          sort_routine: "LCC"
+
+        - class_sort_rule: "generic"
+          description: "Generic call number filing rules"
+          sort_routine: "Generic"
+
+  # splitting rules
+  - class_split_rules:
+      translatable: [ description ]
+      multiline: []
+      rows:
+        - class_split_rule: "dewey"
+          description: "Default splitting rules for DDC"
+          split_routine: "Dewey"
+
+        - class_split_rule: "lcc"
+          description: "Default splitting rules for LCC"
+          split_routine: "LCC"
+
+        - class_split_rule: "generic"
+          description: "Generic call number splitting rules"
+          split_routine: "Generic"
+
+  # classification schemes or sources
+  - class_sources:
+      translatable: [ description ]
+      multiline: []
+      rows:
+        - cn_source: "ddc"
+          description: "Dewey Decimal Classification"
+          used: 1
+          class_sort_rule: "dewey"
+          class_split_rule: "dewey"
+
+        - cn_source: "lcc"
+          description: "Library of Congress Classification"
+          used: 1
+          class_sort_rule: "lcc"
+          class_split_rule: "lcc"
+
+        - cn_source: "udc"
+          description: "Universal Decimal Classification"
+          used: 0
+          class_sort_rule: "generic"
+          class_split_rule: "generic"
+
+        - cn_source: "sudocs"
+          description: "SuDoc Classification (U.S. GPO)"
+          used: 0
+          class_sort_rule: "generic"
+          class_split_rule: "generic"
+
+        - cn_source: "anscr"
+          description: "ANSCR (Sound Recordings)"
+          used: 0
+          class_sort_rule: "generic"
+          class_split_rule: "generic"
+
+        - cn_source: "z"
+          description: "Other/Generic Classification Scheme"
+          used: 0
+          class_sort_rule: "generic"
+          class_split_rule: "generic"