bug 7016 further followup: clarify return of GetItemnumbersForBiblio

New function was actually returning an arrayref, so made
perldoc and function usage consistent.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>

diff --git a/C4/Items.pm b/C4/Items.pm
index 59eaa69..64ed097 100644 (file)
--- a/C4/Items.pm
+++ b/C4/Items.pm
@@ -1498,11 +1498,11 @@ sub  GetLastAcquisitions {
        return @results;
 }
 
-=head2 GetItemnumberForBiblio
+=head2 GetItemnumbersForBiblio
 
-  my @itemnumbers = GetItemnumbersForBiblio($biblionumber);
+  my $itemnumbers = GetItemnumbersForBiblio($biblionumber);
 
-Given a single biblionumber, return an array of all the corresponding itemnumbers
+Given a single biblionumber, return an arrayref of all the corresponding itemnumbers
 
 =cut
 

diff --git a/C4/Reserves.pm b/C4/Reserves.pm
index 2b91567..d1cb88e 100644 (file)
--- a/C4/Reserves.pm
+++ b/C4/Reserves.pm
@@ -383,14 +383,14 @@ sub GetReservesFromBorrowernumber {
 sub CanBookBeReserved{
     my ($borrowernumber, $biblionumber) = @_;
 
-    my @items = GetItemnumbersForBiblio($biblionumber);
+    my $items = GetItemnumbersForBiblio($biblionumber);
     #get items linked via host records
     my @hostitems = get_hostitemnumbers_of($biblionumber);
     if (@hostitems){
-       push (@items,@hostitems);
+    push (@$items,@hostitems);
     }
 
-    foreach my $item (@items){
+    foreach my $item (@$items){
         return 1 if CanItemBeReserved($borrowernumber, $item);
     }
     return 0;