Bug 28316: add tests

Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t b/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
index b2ce6f4..e9a1aa3 100755 (executable)
--- a/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
+++ b/t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
@@ -187,7 +187,7 @@ subtest '_split_query() tests' => sub {
 };
 
 subtest '_clean_search_term() tests' => sub {
-    plan tests => 12;
+    plan tests => 24;
 
     my $qb;
     ok(
@@ -195,6 +195,8 @@ subtest '_clean_search_term() tests' => sub {
         'Creating a new QueryBuilder object'
     );
 
+    t::lib::Mocks::mock_preference('QueryAutoTruncate', 0);
+
     my $res = $qb->_clean_search_term('an=123');
     is($res, 'koha-auth-number:123', 'equals sign replaced with colon');
 
@@ -207,26 +209,66 @@ subtest '_clean_search_term() tests' => sub {
     $res = $qb->_clean_search_term('"unbalanced "quotes"');
     is($res, ' unbalanced  quotes ', 'unbalanced quotes removed');
 
+    $res = $qb->_clean_search_term(':test query');
+    is($res, 'test query', 'remove colon at the start');
+
+    $res = $qb->_clean_search_term('test query\:');
+    is($res, 'test query', 'remove colon at the end');
+
     $res = $qb->_clean_search_term('test : query');
-    is($res, 'test  query', 'dangling colon removed');
+    is($res, 'test query', 'dangling colon removed');
 
     $res = $qb->_clean_search_term('test :: query');
-    is($res, 'test  query', 'dangling double colon removed');
+    is($res, 'test query', 'dangling double colon removed');
 
     $res = $qb->_clean_search_term('test "another : query"');
     is($res, 'test "another : query"', 'quoted dangling colon not removed');
 
-    $res = $qb->_clean_search_term('test {another part}');
-    is($res, 'test "another part"', 'curly brackets replaced correctly');
+    $res = $qb->_clean_search_term('host-item:test:n');
+    is($res, 'host-item:test\:n', 'screen colons properly');
+
+    $res = $qb->_clean_search_term('host-item:test:n:test:and more');
+    is($res, 'host-item:test\:n\:test\:and more', 'screen multiple colons properly');
+
+    $res = $qb->_clean_search_term('host-item:te st:n');
+    is($res, 'host-item:te st:n', 'leave colons as they are');
+
+    $res = $qb->_clean_search_term('test!');
+    is($res, 'test', 'remove exclamation sign at the end of the line');
+
+    $res = $qb->_clean_search_term('test! and more');
+    is($res, 'test and more', 'remove exclamation sign at with space after it');
+
+    $res = $qb->_clean_search_term('!test');
+    is($res, '!test', 'exclamation sign left untouched');
+
+    $res = $qb->_clean_search_term('test [123 TO 345]');
+    is($res, 'test [123 TO 345]', 'keep inculsive range untouched');
+
+    $res = $qb->_clean_search_term('test [test TO TEST} [and] {123 TO 456]');
+    is($res, 'test [test TO TEST} \[and\] {123 TO 456]', 'keep exclusive range untouched');
+
+    $res = $qb->_clean_search_term('test [test TO TEST} ["[and] {123 TO 456]" "[balanced]"]');
+    is($res, 'test [test TO TEST} \["[and] {123 TO 456]" "[balanced]"\]', 'keep exclusive range untouched');
+
+    $res = $qb->_clean_search_term('test[]test TO TEST] [ {123 to 345}}');
+    is($res, 'test\[\]test TO TEST\] \[ \{123 to 345\}\}', 'screen all square and curly brackets');
+
+    t::lib::Mocks::mock_preference('QueryRegexEscapeOptions', 'escape');
+
+    $res = $qb->_clean_search_term('test inside regexps /this [a-z]/ and \/not [a-z]\/ and that [a-z] [a TO z]');
+    is($res, 'test inside regexps \/this \[a-z\]\/ and \/not \[a-z\]\/ and that \[a-z\] [a TO z]', 'behaviour with QueryRegexEscapeOptions set to "escape"');
+
+    t::lib::Mocks::mock_preference('QueryRegexEscapeOptions', 'dont_escape');
 
-    $res = $qb->_clean_search_term('test {another part');
-    is($res, 'test  another part', 'unbalanced curly brackets replaced correctly');
+    $res = $qb->_clean_search_term('test inside regexps /this [a-z]/ /this2 [a-z]/ [but] /this3 [a-z]/ and \/not [a-z]\/ and that [a-z] [a TO z]');
+    is($res, 'test inside regexps /this [a-z]/ /this2 [a-z]/ \[but\] /this3 [a-z]/ and \/not \[a-z\]\/ and that \[a-z\] [a TO z]', 'behaviour with QueryRegexEscapeOptions set to "dont_escape"');
 
     $res = $qb->_clean_search_term('ti:test AND kw:test');
     is($res, 'title:test AND test', 'ti converted to title, kw converted to empty string, dangling colon removed with space preserved');
 
     $res = $qb->_clean_search_term('kw:test');
-    is($res, 'test', 'kw converted to empty string, dangling colon removed with space preserved');
+    is($res, 'test', 'kw converted to empty string, dangling colon is removed');
 };
 
 subtest '_join_queries' => sub {