Bug 31770: Add page-section class to rotating collections page
authorLucas Gass <lucas@bywatersolutions.com>
Tue, 18 Oct 2022 22:11:30 +0000 (22:11 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 21 Oct 2022 14:12:08 +0000 (11:12 -0300)
To test:
1. Apply patch
2. Go to the rotating collections page. Tools / Rotating collections
3. Add some new collections
4. Note that the page looks good with the new page section div.

Note:
I made some indentation changes and fixed a small typo where the 'dropdown-toggle' class was not being properly applied.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/rotating_collections/rotatingCollections.tt

index b3a664c..58d8063 100644 (file)
                 <h1>Rotating collections</h1>
                 <div>
                     [% IF ( collectionsLoop ) %]
-                        <table id="rotating-collections-table">
-                            <thead>
-                                <tr>
-                                    <th>Title</th>
-                                    <th>Description</th>
-                                    <th>Current library</th>
-                                    <th>&nbsp;</th>
-                                </tr>
-                            </thead>
-                            <tbody>
-                            [% FOREACH collectionsLoo IN collectionsLoop %]
-                                <tr>
-                                    <td><a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% collectionsLoo.colId | uri %]">[% collectionsLoo.colTitle | html %]</a></td>
-                                    <td>[% collectionsLoo.colDesc | html %]</td>
-                                    <td>[% Branches.GetName( collectionsLoo.colBranchcode ) | html %]</td>
-                                    <td>
-                                    <div class="btn-group dropup">
-                                        <a class="btn btn-default btn-xs" dropdown-toggle" id="collectionsactions[% collectionsLoo.colId | html %]" role="button" data-toggle="dropdown" href="#">
-                                        Actions <b class="caret"></b></a>
-                                        <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="collectionsactions[% collectionsLoo.colId | html %]">
-                                            <li><a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% collectionsLoo.colId | uri %]"><i class="fa fa-plus"></i> Add or remove items</a></li>
-                                            <li><a href="/cgi-bin/koha/rotating_collections/transferCollection.pl?colId=[% collectionsLoo.colId | uri %]"><i class="fa fa-exchange"></i> Transfer</a></li>
-                                            <li><a href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=edit&amp;colId=[% collectionsLoo.colId | uri %]"><i class="fa fa-pencil"></i> Edit</a></li>
-                                            <li><a class="confirmdelete" href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=delete&amp;colId=[% collectionsLoo.colId | html %]"><i class="fa fa-trash"></i> Delete</a></li>
-                                        </ul>
-                                    </div>
-                                    </td>
-                                </tr>
-                            [% END %]
-                            </tbody>
-                        </table>
+                        <div class="page-section">
+                            <table id="rotating-collections-table">
+                                <thead>
+                                    <tr>
+                                        <th>Title</th>
+                                        <th>Description</th>
+                                        <th>Current library</th>
+                                        <th>&nbsp;</th>
+                                    </tr>
+                                </thead>
+                                <tbody>
+                                [% FOREACH collectionsLoo IN collectionsLoop %]
+                                    <tr>
+                                        <td><a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% collectionsLoo.colId | uri %]">[% collectionsLoo.colTitle | html %]</a></td>
+                                        <td>[% collectionsLoo.colDesc | html %]</td>
+                                        <td>[% Branches.GetName( collectionsLoo.colBranchcode ) | html %]</td>
+                                        <td>
+                                        <div class="btn-group dropup">
+                                            <a class="btn btn-default btn-xs dropdown-toggle" id="collectionsactions[% collectionsLoo.colId | html %]" role="button" data-toggle="dropdown" href="#">
+                                            Actions <b class="caret"></b></a>
+                                            <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="collectionsactions[% collectionsLoo.colId | html %]">
+                                                <li><a href="/cgi-bin/koha/rotating_collections/addItems.pl?colId=[% collectionsLoo.colId | uri %]"><i class="fa fa-plus"></i> Add or remove items</a></li>
+                                                <li><a href="/cgi-bin/koha/rotating_collections/transferCollection.pl?colId=[% collectionsLoo.colId | uri %]"><i class="fa fa-exchange"></i> Transfer</a></li>
+                                                <li><a href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=edit&amp;colId=[% collectionsLoo.colId | uri %]"><i class="fa fa-pencil"></i> Edit</a></li>
+                                                <li><a class="confirmdelete" href="/cgi-bin/koha/rotating_collections/editCollections.pl?action=delete&amp;colId=[% collectionsLoo.colId | html %]"><i class="fa fa-trash"></i> Delete</a></li>
+                                            </ul>
+                                        </div>
+                                        </td>
+                                    </tr>
+                                [% END %]
+                                </tbody>
+                            </table>
+                        </div> <!-- /.page-section -->
                     [% ELSE %]
                         <div class="dialog message">There are no collections currently defined.</div>
                     [% END %]