Bug 18625: (QA follow-up) Simplify update_lastseen

No need to check the pref.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

diff --git a/C4/SIP/ILS/Patron.pm b/C4/SIP/ILS/Patron.pm
index 81036c9..23c5764 100644 (file)
--- a/C4/SIP/ILS/Patron.pm
+++ b/C4/SIP/ILS/Patron.pm
@@ -452,12 +452,8 @@ sub charge_denied {
 
 sub update_lastseen {
     my $self = shift;
-    my $p;
-    if (C4::Context->preference('TrackLastPatronActivity')
-        && $p = Koha::Patrons->find({ borrowernumber => $self->{borrowernumber} })) {
-        $p->track_login;
-    }
-    return;
+    my $kohaobj = Koha::Patrons->find( $self->{borrowernumber} );
+    $kohaobj->track_login if $kohaobj; # track_login checks the pref
 }
 
 sub _get_address {