Bug 32816: Fix cataloguing/value_builder/cn_browser.pl
authorJulian Maurice <julian.maurice@biblibre.com>
Fri, 3 Feb 2023 10:58:51 +0000 (11:58 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 20 Feb 2023 12:54:15 +0000 (09:54 -0300)
Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
cataloguing/value_builder/cn_browser.pl

index 832ca51..41e7c2d 100755 (executable)
@@ -33,8 +33,9 @@ my $builder = sub {
     my $res = "
 <script>
 
-function Click$function_name(i) {
-    q = document.getElementById('$params->{id}');
+function Click$function_name(ev) {
+    ev.preventDefault();
+    q = document.getElementById(ev.data.id);
     window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=cn_browser.pl&popup&q=\"+encodeURIComponent(q.value),\"cnbrowser\",\"width=500,height=400,toolbar=false,scrollbars=yes\");
 }