Bug 12398: (followup) tidy unit tests

This followup removes unnecesary warnings generated by the test,
and also prints a proper message for the tests.

Added a can_ok test for all the exported functions btw.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>

diff --git a/t/db_dependent/Auth_with_cas.t b/t/db_dependent/Auth_with_cas.t
index 1c8c2ef..8e0f783 100755 (executable)
--- a/t/db_dependent/Auth_with_cas.t
+++ b/t/db_dependent/Auth_with_cas.t
@@ -1,16 +1,45 @@
 #!/usr/bin/perl
 
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
 use Modern::Perl;
 
-use Test::More tests => 2;
+use Test::More tests => 3;
 use CGI;
 
 use C4::Context;
 
 BEGIN {
-        use_ok('C4::Auth_with_cas');
+    use_ok('C4::Auth_with_cas');
+    can_ok('C4::Auth_with_cas', qw/
+            check_api_auth_cas
+            checkpw_cas
+            login_cas
+            logout_cas
+            login_cas_url
+            /);
 }
 
+my $dbh = C4::Context->dbh;
+# Start transaction
+$dbh->{ AutoCommit } = 0;
+$dbh->{ RaiseError } = 1;
+
+C4::Context->set_preference('OPACBaseURL','localhost');
+
 my $opac_base_url = C4::Context->preference('OpacBaseURL');
 my $query_string = 'ticket=foo&bar=baz';
 
@@ -20,7 +49,11 @@ $ENV{SCRIPT_NAME} = '/cgi-bin/koha/opac-user.pl';
 my $cgi = new CGI($query_string);
 $cgi->delete('ticket');
 
-# _url_with_get_params should return the URL without 'ticket' parameter since it
-# has been deleted.
+# _url_with_get_params tests
 is(C4::Auth_with_cas::_url_with_get_params($cgi),
-    "$opac_base_url/cgi-bin/koha/opac-user.pl?bar=baz");
+    "$opac_base_url/cgi-bin/koha/opac-user.pl?bar=baz",
+   "_url_with_get_params should return URL without deleted parameters (Bug 12398)");
+
+$dbh->rollback;
+
+1;