Bug 15742: Remove unnecessary loop in j2a cronjob

If no branchcode is given, all the libraries are retrieved and the same
query (so without using the libraries loop) is executed for each
library.

Test plan:
Use the j2a.pl cronjob to change the category of a child patron
If a branchcode is passed to the script, only the children from this
branchcode should be updated.
But if it is not passed, all children of the DB should be updated.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com

diff --git a/misc/cronjobs/j2a.pl b/misc/cronjobs/j2a.pl
index 4000b6a..744a65f 100755 (executable)
--- a/misc/cronjobs/j2a.pl
+++ b/misc/cronjobs/j2a.pl
@@ -130,7 +130,6 @@ if(not $fromcat && $tocat) { #make sure we've specified the info we need.
 cronlogaction();
 
 my $dbh=C4::Context->dbh;
-my @branches = C4::Branch::GetBranches();
 #get today's date, format it and subtract upperagelimit
 my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(time);
 $year +=1900;
@@ -178,7 +177,6 @@ if ( not $noaction) {
                } else { print "Updated $res patrons\n"; }
        } else { # branch was not supplied, processing all branches
                $verbose and print "Looking in all branches for patrons to update from $fromcat to $tocat that were born before $itsyourbirthday\n";
-               foreach my $branchcode (@branches) {
                        my $query=qq|UPDATE borrowers
                           SET guarantorid ='0',
                            categorycode =?
@@ -190,7 +188,6 @@ if ( not $noaction) {
                        if ($res eq '0E0') { print "No patrons updated\n";
                        } else { print "Updated $res patrons\n"; }
        }
-       }
 } else {
        my $birthday;
        if ( $mybranch ) {