use C4::Search;
use Storable qw(thaw freeze);
use URI::Escape;
-
+use C4::Members;
use MARC::File::XML;
use URI::Escape;
sub generate_subfield_form {
- my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $today_iso, $biblionumber, $temp, $loop_data, $i) = @_;
+ my ($tag, $subfieldtag, $value, $tagslib,$subfieldlib, $branches, $today_iso, $biblionumber, $temp, $loop_data, $i, $limitededition) = @_;
- my $frameworkcode = &GetFrameworkCode($biblionumber);
+ my $frameworkcode = &GetFrameworkCode($biblionumber);
+
my %subfield_data;
my $dbh = C4::Context->dbh;
}
my $attributes_no_value = qq(id="$subfield_data{id}" name="field_value" class="input_marceditor" size="50" maxlength="$subfield_data{maxlength}" );
my $attributes_no_value_textarea = qq(id="$subfield_data{id}" name="field_value" class="input_marceditor" rows="5" cols="64" );
+
+ # Getting list of subfields to keep when limited edition is enabled
+ my $subfieldsToAllowForLimitedEdition = C4::Context->preference('SubfieldsToAllowForLimitedEdition');
+ my @subfieldsToAllow = split(/ /, $subfieldsToAllowForLimitedEdition);
+
+ # If we're on limited edition, and our field is not in the list of subfields to allow,
+ # then it is read-only
+ $attributes_no_value .= 'readonly="readonly" '
+ if (
+ $limitededition
+ and !grep { $tag . '$' . $subfieldtag eq $_ } @subfieldsToAllow
+ );
+
my $attributes = qq($attributes_no_value value="$value" );
if ( $subfieldlib->{authorised_value} ) {
$subfield_data{marc_value} = qq(<input type="hidden" $attributes /> $authorised_lib{$value});
}
else {
- $subfield_data{marc_value} =CGI::scrolling_list( # FIXME: factor out scrolling_list
+ my @scrparam = (
-name => "field_value",
-values => \@authorised_values,
-default => $value,
-id => "tag_".$tag."_subfield_".$subfieldtag."_".$index_subfield,
-class => "input_marceditor",
);
+
+ # If we're on limited edition, and our field is not in the list of subfields to allow,
+ # then it is read-only
+ push @scrparam, (-readonly => "readonly"), (-disabled => "disabled")
+ if (
+ $limitededition
+ and !grep { $tag . '$' . $subfieldtag eq $_ } @subfieldsToAllow
+ );
+ $subfield_data{marc_value} =CGI::scrolling_list(@scrparam);
}
}
});
+# Does the user have a limited item edition permission?
+my $uid = GetMember( borrowernumber => $loggedinuser )->{userid} if ($loggedinuser) ;
+my $limitededition = haspermission($uid, {'editcatalogue' => 'limited_item_edition'}) if ($uid);
+# In case user is a superlibrarian, edition is not limited
+$limitededition = 0 if ($limitededition != 0 && $limitededition->{'superlibrarian'} eq 1);
+
my $today_iso = C4::Dates->today('iso');
my $tagslib = &GetMarcStructure(1,$frameworkcode);
my $record = GetMarcBiblio($biblionumber);
next if subfield_is_koha_internal_p($subfieldtag);
next if ($tagslib->{$tag}->{$subfieldtag}->{'tab'} ne "10");
- my $subfield_data = generate_subfield_form($tag, $subfieldtag, $value, $tagslib, $subfieldlib, $branches, $today_iso, $biblionumber, $temp, \@loop_data, $i);
-
+ my $subfield_data = generate_subfield_form($tag, $subfieldtag, $value, $tagslib, $subfieldlib, $branches, $today_iso, $biblionumber, $temp, \@loop_data, $i, $limitededition);
push @fields, "$tag$subfieldtag";
push (@loop_data, $subfield_data);
$i++;
my @values = (undef);
@values = $itemrecord->field($tag)->subfield($subtag) if ($itemrecord && defined($itemrecord->field($tag)) && defined($itemrecord->field($tag)->subfield($subtag)));
for my $value (@values){
- my $subfield_data = generate_subfield_form($tag, $subtag, $value, $tagslib, $tagslib->{$tag}->{$subtag}, $branches, $today_iso, $biblionumber, $temp, \@loop_data, $i);
+ my $subfield_data = generate_subfield_form($tag, $subtag, $value, $tagslib, $tagslib->{$tag}->{$subtag}, $branches, $today_iso, $biblionumber, $temp, \@loop_data, $i, $limitededition);
push (@loop_data, $subfield_data);
$i++;
}
}
function Check(f) {
var total_errors = CheckMandatorySubfields(f);
- if (total_errors > 0) {
+ if (total_errors==0) {
+ // Explanation about this line:
+ // In case of limited edition permission, we have to prevent user from modifying some fields.
+ // But there is no such thing as readonly attribute for select elements.
+ // So we use disabled instead. But disabled prevent values from being passed through the form at submit.
+ // So we "un-disable" the elements just before submitting.
+ // That's a bit clumsy, and if someone comes up with a better solution, feel free to improve that.
+ $("select[name=field_value]").removeAttr("disabled");
+ return true;
+ } else {
var alertString2 = _("Form not submitted because of the following problem(s)");
alertString2 += "\n------------------------------------------------------------------------------------\n";
alertString2 += "\n- " + _("%s mandatory fields empty (highlighted)").format(total_errors);
</div>
<div class="yui-u">
<div id="cataloguing_additem_newitem">
- <form method="post" action="/cgi-bin/koha/cataloguing/additem.pl" name="f">
+ <form id="f" method="post" action="/cgi-bin/koha/cataloguing/additem.pl" name="f">
<input type="hidden" name="op" value="[% op %]" />
[% IF (popup) %]
<input type="hidden" name="popup" value="1" />
use C4::ClassSource;
use C4::Dates;
use C4::Debug;
+use C4::Members;
use MARC::File::XML;
use List::MoreUtils qw/uniq/;
flagsrequired => $template_flag,
});
+# Does the user have a limited item edition permission?
+my $uid = GetMember( borrowernumber => $loggedinuser )->{userid} if ($loggedinuser) ;
+my $limitededition = haspermission($uid, {'tools' => 'items_limited_batchmod'}) if ($uid);
+# In case user is a superlibrarian, edition is not limited
+$limitededition = 0 if ($limitededition != 0 && $limitededition->{'superlibrarian'} eq 1);
my $today_iso = C4::Dates->today('iso');
$template->param(today_iso => $today_iso);
my $pref_itemcallnumber = C4::Context->preference('itemcallnumber');
+# Getting list of subfields to keep when limited batchmod edit is enabled
+my $subfieldsToAllowForBatchmod = C4::Context->preference('SubfieldsToAllowForLimitedBatchmod');
+my @subfieldsToAllow = split(/ /, $subfieldsToAllowForBatchmod);
foreach my $tag (sort keys %{$tagslib}) {
# loop through each subfield
foreach my $subfield (sort keys %{$tagslib->{$tag}}) {
next if subfield_is_koha_internal_p($subfield);
+ next if ($limitededition && !grep { $tag . '$' . $subfield eq $_ } @subfieldsToAllow );
next if ($tagslib->{$tag}->{$subfield}->{'tab'} ne "10");
# barcode and stocknumber are not meant to be batch-modified
next if $tagslib->{$tag}->{$subfield}->{'kohafield'} eq 'items.barcode';