Bug 11231: remove reference to ambiguous notes column from two hold request reports
authorFrancesca Moore <francescalamoore@gmail.com>
Tue, 14 Jan 2014 23:03:51 +0000 (12:03 +1300)
committerGalen Charlton <gmc@esilibrary.com>
Fri, 18 Apr 2014 23:21:04 +0000 (23:21 +0000)
The 'notes' column has been removed from the pending holds and hold
ratios reports as they were not displaying in the first place.

1.apply patch
2.verify that both reports work

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
circ/pendingreserves.pl
circ/reserveratios.pl

index 0110deb..c34c52c 100755 (executable)
@@ -124,7 +124,6 @@ if ( $run_report ) {
             GROUP_CONCAT(DISTINCT items.copynumber
                     ORDER BY items.itemnumber SEPARATOR '<br/>') l_copynumber,
             items.itemnumber,
-            notes,
             notificationdate,
             reminderdate,
             max(priority) as priority,
@@ -183,7 +182,6 @@ if ( $run_report ) {
                 itemcallnumber  => $data->{l_itemcallnumber},
                 enumchron       => $data->{l_enumchron},
                 copyno          => $data->{l_copynumber},
-                notes           => $data->{notes},
                 notificationdate=> $data->{notificationdate},
                 reminderdate    => $data->{reminderdate},
                 count           => $data->{icount},
index 55eb018..bb5eb24 100755 (executable)
@@ -99,7 +99,7 @@ my $strsth =
                        ORDER BY items.itemnumber SEPARATOR '<br/>') as l_location,
         GROUP_CONCAT(DISTINCT items.itype 
                        ORDER BY items.itemnumber SEPARATOR '<br/>') as l_itype,
-        notes,
+
         reserves.found,
         biblio.title,
         biblio.author,
@@ -141,7 +141,6 @@ while ( my $data = $sth->fetchrow_hashref ) {
             title            => $data->{title},
             subtitle            => $data->{subtitle},
             author           => $data->{author},
-            notes            => $data->{notes},
             itemnum          => $data->{itemnumber},
             biblionumber     => $data->{biblionumber},
             holdingbranch    => $data->{holdingbranch},